mx6: Allow configuring the NoC registers on i.MX6QP
Subsystems (3)
Fabio Estevam
reviewerPATCH v2 1/1 mx6: Allow configuring the NoC registers on i.MX6QP
The NoC registers on i.MX6QP needs to be configured, otherwise some usecases in the kernel behave incorrectly, such as rotation and resize.
Currently the NoC registers are not configured in the kernel, so configure them in U-Boot like it is done in the NXP U-Boot tree.
---
Changes since v1:
- Fix the build on mx6sxsabresd_defconfig (Stefano)
arch/arm/mach-imx/mx6/soc.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)
arch/arm/mach-imx/mx6/soc.c +35 -0
@@ -374,6 +374,37 @@ static void init_bandgap(void) } } +#if defined(CONFIG_MX6Q ) || defined(CONFIG_MX6QDL ) +static void noc_setup (void ) +{ +enable_ipu_clock (); + +writel (0x80000201 ,0xbb0608 ); +/* Bypass IPU1 QoS generator */ +writel (0x00000002 ,0x00bb048c ); +/* Bypass IPU2 QoS generator */ +writel (0x00000002 ,0x00bb050c ); +/* Bandwidth THR for of PRE0 */ +writel (0x00000200 ,0x00bb0690 ); +/* Bandwidth THR for of PRE1 */ +writel (0x00000200 ,0x00bb0710 ); +/* Bandwidth THR for of PRE2 */ +writel (0x00000200 ,0x00bb0790 ); +/* Bandwidth THR for of PRE3 */ +writel (0x00000200 ,0x00bb0810 ); +/* Saturation THR for of PRE0 */ +writel (0x00000010 ,0x00bb0694 ); +/* Saturation THR for of PRE1 */ +writel (0x00000010 ,0x00bb0714 ); +/* Saturation THR for of PRE2 */ +writel (0x00000010 ,0x00bb0794 ); +/* Saturation THR for of PRE */ +writel (0x00000010 ,0x00bb0814 ); + +disable_ipu_clock (); +} +#endif +int arch_cpu_init (void ) {struct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR ;
@@ -451,6 +482,10 @@ int arch_cpu_init(void)init_src (); +#if defined(CONFIG_MX6Q ) || defined(CONFIG_MX6QDL ) +if (is_mx6dqp ()) +noc_setup (); +#endif return 0 ; }
Signature · 1 line
2.17.1
PATCH v2 1/1 mx6: Allow configuring the NoC registers on i.MX6QP
Quoted 59 lines · Fabio Estevam
The NoC registers on i.MX6QP needs to be configured, otherwise some usecases in the kernel behave incorrectly, such as rotation and resize.
Currently the NoC registers are not configured in the kernel, so configure them in U-Boot like it is done in the NXP U-Boot tree.
Signed-off-by Fabio Estevam <[email protected]>Reviewed-by Peng Fan <[email protected]>---
Changes since v1:
- Fix the build onmx6sxsabresd_defconfig(Stefano)arch/arm/mach-imx/mx6/soc.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+)arch/arm/mach-imx/mx6/soc.c +31
-0@@ -374,6 +374,37 @@ static void init_bandgap(void) } } +#if defined(CONFIG_MX6Q ) || defined(CONFIG_MX6QDL ) +static void noc_setup (void ) +{ +enable_ipu_clock (); + +writel (0x80000201 ,0xbb0608 ); +/* Bypass IPU1 QoS generator */ +writel (0x00000002 ,0x00bb048c ); +/* Bypass IPU2 QoS generator */ +writel (0x00000002 ,0x00bb050c ); +/* Bandwidth THR for of PRE0 */ +writel (0x00000200 ,0x00bb0690 ); +/* Bandwidth THR for of PRE1 */ +writel (0x00000200 ,0x00bb0710 ); +/* Bandwidth THR for of PRE2 */ +writel (0x00000200 ,0x00bb0790 ); +/* Bandwidth THR for of PRE3 */ +writel (0x00000200 ,0x00bb0810 ); +/* Saturation THR for of PRE0 */ +writel (0x00000010 ,0x00bb0694 ); +/* Saturation THR for of PRE1 */ +writel (0x00000010 ,0x00bb0714 ); +/* Saturation THR for of PRE2 */ +writel (0x00000010 ,0x00bb0794 ); +/* Saturation THR for of PRE */ +writel (0x00000010 ,0x00bb0814 ); + +disable_ipu_clock (); +} +#endif +int arch_cpu_init (void ) {struct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR ;
arch/arm/mach-imx/mx6/soc.c int arch_cpu_init(void) · line 491
Quoted 10 lines
arch/arm/mach-imx/mx6/soc.c +4
-0@@ -451,6 +482,10 @@ int arch_cpu_init(void)init_src (); +#if defined(CONFIG_MX6Q ) || defined(CONFIG_MX6QDL ) +if (is_mx6dqp ()) +noc_setup (); +#endif return 0 ; }
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
Fabio Estevam
reviewerPATCH v2 1/1 mx6: Allow configuring the NoC registers on i.MX6QP
Hi Stefano,
Quoted 5 lines · Stefano Babic
Quoted 3 lines · Fabio Estevam
The NoC registers on i.MX6QP needs to be configured, otherwise some usecases in the kernel behave incorrectly, such as rotation and resize.
Quoted 7 lines
Quoted 5 lines
Currently the NoC registers are not configured in the kernel, so configure them in U-Boot like it is done in the NXP U-Boot tree.
Signed-off-by Fabio Estevam <[email protected]>Reviewed-by Peng Fan <[email protected]>Reviewed-by Stefano Babic <[email protected]>
Do you plan to apply this one to 2020.01?
Thanks