Skip to contentSkip to conversation

iputils: Whitelist CVE-2000-1213 CVE-2000-1214

PATCH In review Adrian Bunk 2 participants 5 messages Nov 4, 2019 – Nov 11, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iputils: Whitelist CVE-2000-1213 CVE-2000-1214

---
 meta/recipes-extended/iputils/iputils_s20190709.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-extended/iputils/iputils_s20190709.bb +4 -0
index d8f2470d0c..3f9e9917f0 100644
@@ -17,6 +17,10 @@ S = "${WORKDIR}/git"
 
 UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>s\d+)"
 
+# Fixed in 2000-10-10, but the versioning of iputils
+# breaks the version order.
+CVE_CHECK_WHITELIST += "CVE-2000-1213 CVE-2000-1214"
+
 PACKAGECONFIG ??= "libcap libgcrypt rarpd traceroute6"
 PACKAGECONFIG[libcap] = "-DUSE_CAP=true, -DUSE_CAP=false, libcap"
 PACKAGECONFIG[libgcrypt] = "-DUSE_CRYPTO=gcrypt, -DUSE_CRYPTO=none, libgcrypt"
Signature · 1 line
2.17.1
#1 lore raw

meta/recipes-extended/iputils/iputils_s20190709.bb S = "${WORKDIR}/git" · line 22

Quoted 3 lines · Adrian Bunk
meta/recipes-extended/iputils/iputils_s20190709.bb +3 -0
+# Fixed in 2000-10-10, but the versioning of iputils
+# breaks the version order.
+CVE_CHECK_WHITELIST += "CVE-2000-1213 CVE-2000-1214"

So the problem is that our PV matches the upstream git tags, which don't match the naming convention in the CPE entries.

The tags are of the form s20190709, but the CPE uses 2010-10-10.

If we assume that the CPE version scheme will remain the same then we can handle this for all cases in the recipe:

def cve_version(d):

    import re
    m = re.match(r"s(\d{4})(\d{2})(\d{2})", d.getVar("PV"))
    return "-".join(m.groups())

CVE_VERSION = "${@cve_version(d)}"

Ross

#2 lore raw
Quoted 8 lines · Ross Burton

meta/recipes-extended/iputils/iputils_s20190709.bb S = "${WORKDIR}/git" · line 22

Quoted 3 lines · Adrian Bunk
meta/recipes-extended/iputils/iputils_s20190709.bb +3 -0
+# Fixed in 2000-10-10, but the versioning of iputils
+# breaks the version order.
+CVE_CHECK_WHITELIST += "CVE-2000-1213 CVE-2000-1214"

So the problem is that our PV matches the upstream git tags, which don't match the naming convention in the CPE entries.

Quoted 4 lines

The tags are of the form s20190709, but the CPE uses 2010-10-10.

If we assume that the CPE version scheme will remain the same
...

CVE-2010-2529 had an explicit list of affected versions of the scheme 20100214.

These 19 year old ones from a time when CVE was new are outliers. I would expect versions in new CVE to match the OE versioning, except that the 's' might (or might not) be missing.

Quoted 1 line

Ross

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#3 lore raw
Quoted 14 lines · Adrian Bunk
Quoted 8 lines · Ross Burton

meta/recipes-extended/iputils/iputils_s20190709.bb S = "${WORKDIR}/git" · line 22

Quoted 3 lines · Adrian Bunk
meta/recipes-extended/iputils/iputils_s20190709.bb +3 -0
+# Fixed in 2000-10-10, but the versioning of iputils
+# breaks the version order.
+CVE_CHECK_WHITELIST += "CVE-2000-1213 CVE-2000-1214"

So the problem is that our PV matches the upstream git tags, which don't match the naming convention in the CPE entries.

Quoted 4 lines

The tags are of the form s20190709, but the CPE uses 2010-10-10.

If we assume that the CPE version scheme will remain the same
...

Quoted 6 lines

CVE-2010-2529 had an explicit list of affected versions of the scheme 20100214.

These 19 year old ones from a time when CVE was new are outliers. I would expect versions in new CVE to match the OE versioning, except that the 's' might (or might not) be missing.

<shakes fist>

Of course -2529 uses a different CPE product/vendor name to -1213 so didn't appear in my search.

Okay, lets use the whitelist approach.

Ross

#4 lore raw
In reply to Adrian Bunk

ping

Thanks
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed