Skip to contentSkip to conversation

ALSA: hda: hdmi - add Tigerlake support

PATCH In review Kai Vehmanen 3 participants 4 messages Nov 5, 2019 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda: hdmi - add Tigerlake support

Add Tigerlake HDMI codec support.

---
 sound/pci/hda/patch_hdmi.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
sound/pci/hda/patch_hdmi.c +13 -0
index b72553710ffb..3c720703ebb8 100644
@@ -2851,6 +2851,18 @@ static int patch_i915_icl_hdmi(struct hda_codec *codec)
 	return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map));
 }
 
+static int patch_i915_tgl_hdmi(struct hda_codec *codec)
+{
+	/*
+	 * pin to port mapping table where the value indicate the pin number and
+	 * the index indicate the port number with 1 base.
+	 */
+	static const int map[] = {0x4, 0x6, 0x8, 0xa, 0xb, 0xc, 0xd, 0xe, 0xf};
+
+	return intel_hsw_common_init(codec, 0x02, map, ARRAY_SIZE(map));
+}
+
+
 /* Intel Baytrail and Braswell; with eld notifier */
 static int patch_i915_byt_hdmi(struct hda_codec *codec)
 {
@@ -4153,6 +4165,7 @@ HDA_CODEC_ENTRY(0x8086280b, "Kabylake HDMI",	patch_i915_hsw_hdmi),
 HDA_CODEC_ENTRY(0x8086280c, "Cannonlake HDMI",	patch_i915_glk_hdmi),
 HDA_CODEC_ENTRY(0x8086280d, "Geminilake HDMI",	patch_i915_glk_hdmi),
 HDA_CODEC_ENTRY(0x8086280f, "Icelake HDMI",	patch_i915_icl_hdmi),
+HDA_CODEC_ENTRY(0x80862812, "Tigerlake HDMI",	patch_i915_tgl_hdmi),
 HDA_CODEC_ENTRY(0x80862880, "CedarTrail HDMI",	patch_generic_hdmi),
 HDA_CODEC_ENTRY(0x80862882, "Valleyview2 HDMI",	patch_i915_byt_hdmi),
 HDA_CODEC_ENTRY(0x80862883, "Braswell HDMI",	patch_i915_byt_hdmi),
Signature · 6 lines
2.17.1

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
#1 lore raw

Quoting Kai Vehmanen (2019-11-05 16:10:53)

Quoted 6 lines

Add Tigerlake HDMI codec support.

For thos watching,
https://patchwork.freedesktop.org/series/68972/#rev1
includes the revert so that this is tested. Not that the first run through BAT tgl died too early to be conclusive.
-Chris
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#2 lore raw

Hi,

Quoted 8 lines · Chris Wilson

Quoting Kai Vehmanen (2019-11-05 16:10:53)

Quoted 6 lines

Add Tigerlake HDMI codec support.

Quoted 4 lines

For thos watching,
https://patchwork.freedesktop.org/series/68972/#rev1
includes the revert so that this is tested. Not that the first run through BAT tgl died too early to be conclusive.

ack. The partial results do look good already. The boot log shows HDMI codec found and configured without errors:
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_5274/fi-tgl-u/boot0.txt

And the S3 suspend test did pass:
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_5274/fi-tgl-u/igt@[email protected]

So so far so good.

Br, Kai
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#3 lore raw
Quoted 18 lines · Kai Vehmanen

Hi,

Quoted 8 lines · Chris Wilson

Quoting Kai Vehmanen (2019-11-05 16:10:53)

Quoted 6 lines

Add Tigerlake HDMI codec support.

Quoted 4 lines

For thos watching,
https://patchwork.freedesktop.org/series/68972/#rev1
includes the revert so that this is tested. Not that the first run through BAT tgl died too early to be conclusive.

Quoted 8 lines

ack. The partial results do look good already. The boot log shows HDMI codec found and configured without errors:
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_5274/fi-tgl-u/boot0.txt

And the S3 suspend test did pass:
https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_5274/fi-tgl-u/igt@[email protected]

So so far so good.

OK, I applied the patch now. If any correction is needed, please submit a new on top of it.

thanks,

Takashi
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel