Skip to contentSkip to conversation

smb3: remove confusing dmesg when mounting with encryption ("seal")

bug report Dan Carpenter 2 participants 2 messages Nov 8, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hello Steve French,

This is a semi-automatic email about new static checker warnings.

The patch 6a364520b30e: "smb3: remove confusing dmesg when mounting with encryption ("seal")" from Nov 5, 2019, leads to the following Smatch complaint:

fs/cifs/connect.c:1091 cifs_handle_standard()
warn: variable dereferenced before check 'mid' (see line 1075)

fs/cifs/connect.c
1074 length = server->ops->check_message(buf, server->total_read, server,

  1075						    mid->decrypted);
                                                    ^^^^^^^^^^^^^^

New unchecked dereference.

1076 if (length != 0)
1077 cifs_dump_mem("Bad SMB: ", buf,
1078 min_t(unsigned int, server->total_read, 48));
1079
1080 if (server->ops->is_session_expired &&
1081 server->ops->is_session_expired(buf)) {
1082 cifs_reconnect(server);
1083 wake_up(&server->response_q);
1084 return -1;
1085 }
1086
1087 if (server->ops->is_status_pending &&
1088 server->ops->is_status_pending(buf, server))
1089 return -1;
1090
1091 if (!mid)

                    ^^^^

The old code assumed it could be NULL.

1092 return length;
1093

regards,
dan carpenter

#1 lore raw

This was fixed in a later version of this patch yesterday, but ... Pavel suggested just removing the warning message that prompted this patch - easier, and the warning message wasn't very useful.

Quoted 42 lines · Dan Carpenter

Hello Steve French,

This is a semi-automatic email about new static checker warnings.

The patch 6a364520b30e: "smb3: remove confusing dmesg when mounting with encryption ("seal")" from Nov 5, 2019, leads to the following Smatch complaint:

fs/cifs/connect.c:1091 cifs_handle_standard()
warn: variable dereferenced before check 'mid' (see line 1075)

fs/cifs/connect.c
1074 length = server->ops->check_message(buf, server->total_read, server,

  1075                                              mid->decrypted);
                                                    ^^^^^^^^^^^^^^

New unchecked dereference.

1076 if (length != 0)
1077 cifs_dump_mem("Bad SMB: ", buf,
1078 min_t(unsigned int, server->total_read, 48));
1079
1080 if (server->ops->is_session_expired &&
1081 server->ops->is_session_expired(buf)) {

  1082                  cifs_reconnect(server);
  1083                  wake_up(&server->response_q);
  1084                  return -1;
  1085          }
  1086
  1087          if (server->ops->is_status_pending &&
  1088              server->ops->is_status_pending(buf, server))
  1089                  return -1;
  1090
  1091          if (!mid)
                    ^^^^

The old code assumed it could be NULL.

1092 return length;
1093

regards,
dan carpenter

Signature · 3 lines
Thanks,

Steve