iommu/vt-d: Add Kconfig option to enable/disable scalable mode
PATCH v2 1/1 iommu/vt-d: Add Kconfig option to enable/disable scalable mode
This adds Kconfig option INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON to make it easier for distributions to enable or disable the Intel IOMMU scalable mode by default during kernel build.
--- drivers/iommu/Kconfig | 9 +++++++++ drivers/iommu/intel-iommu.c | 7 ++++++- 2 files changed, 15 insertions(+), 1 deletion(-)
drivers/iommu/Kconfig +9 -0
@@ -242,6 +242,15 @@ config INTEL_IOMMU_FLOPPY_WA workaround will setup a 1:1 mapping for the first 16MiB to make floppy (an ISA device) work. +config INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON + prompt "Enable Intel IOMMU scalable mode by default" + depends on INTEL_IOMMU + help + Selecting this option will enable the scalable mode if + hardware presents the capability. If this option is not + selected, scalable mode support could also be enabled + by passing intel_iommu=sm_on to the kernel. + config IRQ_REMAP bool "Support for Interrupt Remapping" depends on X86_64 && X86_IO_APIC && PCI_MSI && ACPI
drivers/iommu/intel-iommu.c +6 -1
@@ -355,9 +355,14 @@ static phys_addr_t intel_iommu_iova_to_phys(struct iommu_domain *domain,int dmar_disabled =0 ;#else int dmar_disabled =1 ; -#endif /*CONFIG_INTEL_IOMMU_DEFAULT_ON*/ +#endif /* CONFIG_INTEL_IOMMU_DEFAULT_ON */ +#ifdef INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON +int intel_iommu_sm =1 ; +#else int intel_iommu_sm; +#endif /* INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON */ +int intel_iommu_enabled =0 ;EXPORT_SYMBOL_GPL (intel_iommu_enabled);
Signature · 1 line
2.17.1
Quoted 20 lines · Lu Baolu
This adds
KconfigoptionINTEL_IOMMU_SCALABLE_MODE_DEFAULT_ONto make it easier for distributions to enable or disable the Intel IOMMU scalable mode by default during kernel build.Signed-off-by Lu Baolu <[email protected]>---
drivers/iommu/Kconfig| 9 +++++++++drivers/iommu/intel-iommu.c| 7 ++++++-2 files changed, 15 insertions(+), 1 deletion(-)drivers/iommu/Kconfig +0
-0@@ -242,6 +242,15 @@ config INTEL_IOMMU_FLOPPY_WA workaround will setup a 1:1 mapping for the first
drivers/iommu/Kconfig config INTEL_IOMMU_FLOPPY_WA · line 252
Quoted 10 lines
drivers/iommu/Kconfig +8
-016MiB to make floppy (an ISA device) work. +config INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON + prompt "Enable Intel IOMMU scalable mode by default" + depends on INTEL_IOMMU + help + Selecting this option will enable the scalable mode if + hardware presents the capability. If this option is not + selected, scalable mode support could also be enabled + by passing intel_iommu=sm_on to the kernel.
Maybe a sentence or two to describe what the scalable mode is in layman's terms could be useful, so developers don’t need to search around for the Kconfig selection?
Quoted 31 lines
drivers/iommu/Kconfig +1
-0+config
IRQ_REMAPbool "Support for Interrupt Remapping" depends on X86_64 && X86_IO_APIC && PCI_MSI && ACPIdrivers/iommu/intel-iommu.c +6
-1@@ -355,9 +355,14 @@ static phys_addr_t intel_iommu_iova_to_phys(struct iommu_domain *domain,int dmar_disabled =0 ;#else int dmar_disabled =1 ; -#endif /*CONFIG_INTEL_IOMMU_DEFAULT_ON*/ +#endif /* CONFIG_INTEL_IOMMU_DEFAULT_ON */ +#ifdef INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON +int intel_iommu_sm =1 ; +#else int intel_iommu_sm; +#endif /* INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON */ +int intel_iommu_enabled =0 ;EXPORT_SYMBOL_GPL (intel_iommu_enabled);Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi,
Quoted 22 lines · Qian Cai
Quoted 22 lines · Lu Baolu
This adds
KconfigoptionINTEL_IOMMU_SCALABLE_MODE_DEFAULT_ONto make it easier for distributions to enable or disable the Intel IOMMU scalable mode by default during kernel build.Signed-off-by Lu Baolu <[email protected]>---
drivers/iommu/Kconfig| 9 +++++++++drivers/iommu/intel-iommu.c| 7 ++++++-2 files changed, 15 insertions(+), 1 deletion(-)drivers/iommu/Kconfig +0
-0@@ -242,6 +242,15 @@ config INTEL_IOMMU_FLOPPY_WA workaround will setup a 1:1 mapping for the first 16MiB to make floppy (an ISA device) work.
Quoted 13 lines
drivers/iommu/Kconfig config INTEL_IOMMU_FLOPPY_WA · line 252
Quoted 8 lines
drivers/iommu/Kconfig +8
-0+config INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON + prompt "Enable Intel IOMMU scalable mode by default" + depends on INTEL_IOMMU + help + Selecting this option will enable the scalable mode if + hardware presents the capability. If this option is not + selected, scalable mode support could also be enabled + by passing intel_iommu=sm_on to the kernel.Maybe a sentence or two to describe what the scalable mode is in layman's terms could be useful, so developers don’t need to search around for the
Kconfigselection?
How about "pasid based multiple stages DMA translation"?
Best regards,
baolu
Quoted 34 lines
Quoted 32 lines
drivers/iommu/Kconfig +1
-0+config
IRQ_REMAPbool "Support for Interrupt Remapping" depends on X86_64 && X86_IO_APIC && PCI_MSI && ACPIdrivers/iommu/intel-iommu.c +6
-1@@ -355,9 +355,14 @@ static phys_addr_t intel_iommu_iova_to_phys(struct iommu_domain *domain,int dmar_disabled =0 ;#else int dmar_disabled =1 ; -#endif /*CONFIG_INTEL_IOMMU_DEFAULT_ON*/ +#endif /* CONFIG_INTEL_IOMMU_DEFAULT_ON */ +#ifdef INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON +int intel_iommu_sm =1 ; +#else int intel_iommu_sm; +#endif /* INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON */ +int intel_iommu_enabled =0 ;EXPORT_SYMBOL_GPL (intel_iommu_enabled);Signature · 6 lines
2.17.1 _______________________________________________ iommu mailing list [email protected] https://lists.linuxfoundation.org/mailman/listinfo/iommu
Quoted 5 lines · Lu Baolu
How about "pasid based multiple stages DMA translation"?
It is better but I am still not sure how developers should select it or not when asking. Ideally, should it mention pros and cons of this? At minimal, there should be a line said “if not sure what this is, select N”?
Hi,
Quoted 8 lines · Qian Cai
Quoted 5 lines · Lu Baolu
How about "pasid based multiple stages DMA translation"?
It is better but I am still not sure how developers should select it or not when asking. Ideally, should it mention pros and cons of this? At minimal, there should be a line said “if not sure what this is, select N”?
Actually, I'd recommend "if not sure, use the default value". :-)
Best regards,
baolu
drivers/iommu/Kconfig config INTEL_IOMMU_FLOPPY_WA · line 253
Quoted 13 lines · Lu Baolu
drivers/iommu/Kconfig +9
-0+config INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON + prompt "Enable Intel IOMMU scalable mode by default" + depends on INTEL_IOMMU + help + Selecting this option will enable the scalable mode if + hardware presents the capability. If this option is not + selected, scalable mode support could also be enabled + by passing intel_iommu=sm_on to the kernel. +
Does it also make sense to mention which hardware presents this capability or how to check it?
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi,
Quoted 4 lines · Qian Cai
Quoted 4 lines · Lu Baolu
Quoted 12 lines
drivers/iommu/Kconfig config INTEL_IOMMU_FLOPPY_WA · line 253
Quoted 9 lines
drivers/iommu/Kconfig +9
-0+config INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON + prompt "Enable Intel IOMMU scalable mode by default" + depends on INTEL_IOMMU + help + Selecting this option will enable the scalable mode if + hardware presents the capability. If this option is not + selected, scalable mode support could also be enabled + by passing intel_iommu=sm_on to the kernel. +Does it also make sense to mention which hardware presents this capability or how to check it?
The scalable mode is defined in VT-d 3.0. The scalable mode capability could be checked by reading /sys/devices/virtual/iommu/dmar*/intel- iommu/ecap. It's currently not friendly for reading. You need to decode it according to the spec.
Best regards,
baolu
Quoted 8 lines · Lu Baolu
The scalable mode is defined in VT-d 3.0. The scalable mode capability could be checked by reading
/sys/devices/virtual/iommu/dmar*/intel-iommu/ecap. It's currently not friendly for reading. You need to decode it according to the spec.
This looks like some perfect information to put in the Kconfig description.
_______________________________________________
iommu mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/iommu
Hi,
Quoted 11 lines · Qian Cai
Quoted 8 lines · Lu Baolu
The scalable mode is defined in VT-d 3.0. The scalable mode capability could be checked by reading
/sys/devices/virtual/iommu/dmar*/intel-iommu/ecap. It's currently not friendly for reading. You need to decode it according to the spec.This looks like some perfect information to put in the
Kconfigdescription.
Okay. Will add it in the next version.
Best regards,
baolu