habanalabs: re-factor memory module code
PATCH 1/1 habanalabs: re-factor memory module code
From: Omer Shpigelman <[email protected]>
Some of the functions in the memory module code were too long and/or contained multiple operations that are not always done together. Re-factor the code by dividing those functions to smaller functions which are more readable and maintainable.
Signed-off-by Omer Shpigelman <[email protected]>
Reviewed-by Oded Gabbay <[email protected]>
Signed-off-by Oded Gabbay <[email protected]>
--- drivers/misc/habanalabs/goya/goya.c | 2 +- drivers/misc/habanalabs/habanalabs.h | 4 +- drivers/misc/habanalabs/memory.c | 281 +++++++++++++++------------ 3 files changed, 158 insertions(+), 129 deletions(-)
drivers/misc/habanalabs/goya/goya.c +1 -1
@@ -3935,7 +3935,7 @@ static int goya_parse_cb_no_ext_queue(struct hl_device *hdev,return 0 ;dev_err (hdev->dev, -"Internal CB address %px + 0x%x is not in SRAM nor in DRAM\n" , +"Internal CB address 0x%px + 0x%x is not in SRAM nor in DRAM\n" , parser->user_cb, parser->user_cb_size);return -EFAULT ;
drivers/misc/habanalabs/habanalabs.h +2 -2
@@ -692,7 +692,7 @@ struct hl_ctx_mgr {* @sgt: pointer to the scatter-gather table that holds the pages. * @dir: for DMA unmapping, the direction must be supplied, so save it. * @debugfs_list: node in debugfs list of command submissions. -* @addr: user-space virtual pointer to the start of the memory area. +* @addr: user-space virtual address of the start of the memory area. * @size: size of the memory area to pin & map. * @dma_mapped: true if the SG was mapped to DMA addresses, false otherwise. */
@@ -1527,7 +1527,7 @@ void hl_vm_fini(struct hl_device *hdev);int hl_pin_host_memory (struct hl_device *hdev,u64 addr,u64 size,struct hl_userptr *userptr); -int hl_unpin_host_memory (struct hl_device *hdev,struct hl_userptr *userptr); +void hl_unpin_host_memory (struct hl_device *hdev,struct hl_userptr *userptr);void hl_userptr_delete_list (struct hl_device *hdev,struct list_head *userptr_list); bool hl_userptr_is_pinned(struct hl_device *hdev, u64 addr, u32 size,
drivers/misc/habanalabs/memory.c +155 -126
475 lines not on this page · raw message
Signature · 1 line
2.17.1