Skip to contentSkip to conversation

insane: improve textrel warning message

PATCH New Ross Burton 1 participant 1 message Nov 11, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 insane: improve textrel warning message

Clean the displayed path so it clearly shows the package name and path in that package.

---
 meta/classes/insane.bbclass | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
meta/classes/insane.bbclass +3 -1
index 9605ac2baee..f856cf6a2b6 100644
@@ -340,9 +340,11 @@ def package_qa_textrel(path, name, d, elf, messages):
     for line in phdrs.split("\n"):
         if textrel_re.match(line):
             sane = False
+            break
 
     if not sane:
-        package_qa_add_message(messages, "textrel", "ELF binary '%s' has relocations in .text" % path)
+        path = package_qa_clean_path(path, d, name)
+        package_qa_add_message(messages, "textrel", "%s: ELF binary %s has relocations in .text" % (name, path))
 
 QAPATHTEST[ldflags] = "package_qa_hash_style"
 def package_qa_hash_style(path, name, d, elf, messages):
Signature · 1 line
2.20.1