Skip to contentSkip to conversation

xfs: remove the unused m_chsize field

PATCH In review Christoph Hellwig 4 participants 4 messages Nov 11, 2019 – Nov 12, 2019 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: remove the unused m_chsize field

---
 fs/xfs/xfs_mount.h | 1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_mount.h +0 -1
index 2dceb446e651..43145a4ab690 100644
@@ -155,7 +155,6 @@ typedef struct xfs_mount {
 	int			m_swidth;	/* stripe width */
 	uint8_t			m_sectbb_log;	/* sectlog - BBSHIFT */
 	const struct xfs_nameops *m_dirnameops;	/* vector of dir name ops */
-	uint			m_chsize;	/* size of next field */
 	atomic_t		m_active_trans;	/* number trans frozen */
 	struct xfs_mru_cache	*m_filestream;  /* per-mount filestream data */
 	struct delayed_work	m_reclaim_work;	/* background inode reclaim */
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Christoph Hellwig

Heh, what was that even used for?

--D

Quoted 19 lines
---
 fs/xfs/xfs_mount.h | 1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_mount.h +0 -1
index 2dceb446e651..43145a4ab690 100644
@@ -155,7 +155,6 @@ typedef struct xfs_mount {
 	int			m_swidth;	/* stripe width */
 	uint8_t			m_sectbb_log;	/* sectlog - BBSHIFT */
 	const struct xfs_nameops *m_dirnameops;	/* vector of dir name ops */
-	uint			m_chsize;	/* size of next field */
 	atomic_t		m_active_trans;	/* number trans frozen */
 	struct xfs_mru_cache	*m_filestream;  /* per-mount filestream data */
 	struct delayed_work	m_reclaim_work;	/* background inode reclaim */
Signature · 1 line
2.20.1
#3 lore raw
In reply to Darrick J. Wong
Quoted 6 lines · Darrick J. Wong
Quoted 1 line · Christoph Hellwig

Heh, what was that even used for?

fs/xfs/xfs_mount.h typedef struct xfs_mount { · line 158

Quoted 1 line
fs/xfs/xfs_mount.h +0 -1
-	uint			m_chsize;	/* size of next field */

Inode cluster hash size.

We used to keep a linked list of all the inodes in a cluster in a separate structure, so that we could easily iterate them when needed (writeback/cluster freeing). They were kept in a separate hash table so that they could be used as a quick reference inode cluster buffer cache as well (IIRC it was to speed up things like xfs_imap_to_bp()) without having the overhead of a full buffer cache lookup...

The need for all this went away with the radix tree indexing and gang lookups - I guess I missed removing this last fragment.

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]