phy: generic: add error trace to detect PHY issue in uclass
Subsystems (7)
PATCH 1/7 phy: generic: add error trace to detect PHY issue in uclass
Add an error trace for PHY errors directly in generic phy functions provided by PHY uclass.
---
This patch is requested by Marek Vasut to avoid code duplication in usb host serie for dwc2:
See http://patchwork.ozlabs.org/patch/1176048/#2297595
[U-Boot,RESEND,1/5] usb: host: dwc2: add phy support
drivers/phy/phy-uclass.c | 40 +++++++++++++++++++++++++++++++++++----- 1 file changed, 35 insertions(+), 5 deletions(-)
drivers/phy/phy-uclass.c +35 -5
@@ -109,56 +109,86 @@ int generic_phy_get_by_name(struct udevice *dev, const char *phy_name,int generic_phy_init (struct phy *phy) {struct phy_ops const *ops; +int ret;if (!phy)return 0 ; ops =phy_dev_ops (phy->dev); -return ops->init ? ops->init (phy) :0 ; + ret = ops->init ? ops->init (phy) :0 ; +if (ret) +dev_err (phy->dev,"PHY: Failed to init %s: %d.\n" , + phy->dev->name, ret); + +return ret; }int generic_phy_reset (struct phy *phy) {struct phy_ops const *ops; +int ret;if (!phy)return 0 ; ops =phy_dev_ops (phy->dev); -return ops->reset ? ops->reset (phy) :0 ; + ret = ops->reset ? ops->reset (phy) :0 ; +if (ret) +dev_err (phy->dev,"PHY: Failed to reset %s: %d.\n" , + phy->dev->name, ret); + +return ret; }int generic_phy_exit (struct phy *phy) {struct phy_ops const *ops; +int ret;if (!phy)return 0 ; ops =phy_dev_ops (phy->dev); -return ops->exit ? ops->exit (phy) :0 ; + ret = ops->exit ? ops->exit (phy) :0 ; +if (ret) +dev_err (phy->dev,"PHY: Failed to exit %s: %d.\n" , + phy->dev->name, ret); + +return ret; }int generic_phy_power_on (struct phy *phy) {struct phy_ops const *ops; +int ret;if (!phy)return 0 ; ops =phy_dev_ops (phy->dev); -return ops->power_on ? ops->power_on (phy) :0 ; + ret = ops->power_on ? ops->power_on (phy) :0 ; +if (ret) +dev_err (phy->dev,"PHY: Failed to power on %s: %d.\n" , + phy->dev->name, ret); + +return ret; }int generic_phy_power_off (struct phy *phy) {struct phy_ops const *ops; +int ret;if (!phy)return 0 ; ops =phy_dev_ops (phy->dev); -return ops->power_off ? ops->power_off (phy) :0 ; + ret = ops->power_off ? ops->power_off (phy) :0 ; +if (ret) +dev_err (phy->dev,"PHY: Failed to power off %s: %d.\n" , + phy->dev->name, ret); + +return ret; }UCLASS_DRIVER (phy) = {
Signature · 1 line
2.17.1
PATCH 2/7 usb: gadget: dwc2: change trace level for phy errors managed by uclass
As the error message is now displayed by generic phy functions, the dev_err can be change to dev_dbg.
---
drivers/usb/gadget/dwc2_udc_otg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/usb/gadget/dwc2_udc_otg.c +3 -3
@@ -980,7 +980,7 @@ int dwc2_phy_setup(struct udevice *dev, struct phy **array, int *num_phys)for (i =0 ; i < count; i++) { ret =generic_phy_init (&usb_phys[i]);if (ret) { -dev_err (dev,"Can't init USB PHY%d for %s\n" , +dev_dbg (dev,"Can't init USB PHY%d for %s\n" , i, dev->name); goto phys_init_err; }
@@ -989,7 +989,7 @@ int dwc2_phy_setup(struct udevice *dev, struct phy **array, int *num_phys)for (i =0 ; i < count; i++) { ret =generic_phy_power_on (&usb_phys[i]);if (ret) { -dev_err (dev,"Can't power USB PHY%d for %s\n" , +dev_dbg (dev,"Can't power USB PHY%d for %s\n" , i, dev->name); goto phys_poweron_err; }
@@ -1027,7 +1027,7 @@ void dwc2_phy_shutdown(struct udevice *dev, struct phy *usb_phys, int num_phys) ret =generic_phy_power_off (&usb_phys[i]); ret |=generic_phy_exit (&usb_phys[i]);if (ret) { -dev_err (dev,"Can't shutdown USB PHY%d for %s\n" , +dev_dbg (dev,"Can't shutdown USB PHY%d for %s\n" , i, dev->name); } }
Signature · 1 line
2.17.1
PATCH 3/7 board: sunxi: change trace level for phy errors managed by uclass
In reply to Patrick DelaunayAs the error message is now displayed by generic phy functions, the pr_err can be change to pr_idebug.
---
board/sunxi/board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
board/sunxi/board.c +1 -1
@@ -705,7 +705,7 @@ int g_dnl_board_usb_cable_connected(void) ret =generic_phy_init (&phy);if (ret) { -pr_err ("failed to init %s USB PHY\n" , dev->name); +pr_debug ("failed to init %s USB PHY\n" , dev->name);return ret; }
Signature · 1 line
2.17.1
PATCH 4/7 usb: host: ohci: change trace level for phy errors managed by uclass
In reply to Patrick DelaunayAs the error message is now displayed by generic phy functions, the dev_err can be change to dev_dbg.
---
drivers/usb/host/ohci-generic.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/host/ohci-generic.c +4 -4
@@ -38,13 +38,13 @@ static int ohci_setup_phy(struct udevice *dev, int index) }else { ret =generic_phy_init (&priv->phy);if (ret) { -dev_err (dev,"failed to init usb phy\n" ); +dev_dbg (dev,"failed to init usb phy\n" );return ret; } ret =generic_phy_power_on (&priv->phy);if (ret) { -dev_err (dev,"failed to power on usb phy\n" ); +dev_dbg (dev,"failed to power on usb phy\n" );return generic_phy_exit (&priv->phy); } }
@@ -60,13 +60,13 @@ static int ohci_shutdown_phy(struct udevice *dev)if (generic_phy_valid (&priv->phy)) { ret =generic_phy_power_off (&priv->phy);if (ret) { -dev_err (dev,"failed to power off usb phy\n" ); +dev_dbg (dev,"failed to power off usb phy\n" );return ret; } ret =generic_phy_exit (&priv->phy);if (ret) { -dev_err (dev,"failed to power off usb phy\n" ); +dev_dbg (dev,"failed to power off usb phy\n" );return ret; } }
Signature · 1 line
2.17.1
PATCH 5/7 usb: host: ehci-hcd: change trace level for phy errors managed by uclass
In reply to Patrick DelaunayAs the error message is now displayed by generic phy functions, the pr_err can be change to pr_debug.
---
drivers/usb/host/ehci-hcd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/host/ehci-hcd.c +4 -4
@@ -1697,13 +1697,13 @@ int ehci_setup_phy(struct udevice *dev, struct phy *phy, int index) }else { ret =generic_phy_init (phy);if (ret) { -dev_err (dev,"failed to init usb phy\n" ); +dev_dbg (dev,"failed to init usb phy\n" );return ret; } ret =generic_phy_power_on (phy);if (ret) { -dev_err (dev,"failed to power on usb phy\n" ); +dev_dbg (dev,"failed to power on usb phy\n" );return generic_phy_exit (phy); } }
@@ -1721,13 +1721,13 @@ int ehci_shutdown_phy(struct udevice *dev, struct phy *phy)if (generic_phy_valid (phy)) { ret =generic_phy_power_off (phy);if (ret) { -dev_err (dev,"failed to power off usb phy\n" ); +dev_dbg (dev,"failed to power off usb phy\n" );return ret; } ret =generic_phy_exit (phy);if (ret) { -dev_err (dev,"failed to power off usb phy\n" ); +dev_dbg (dev,"failed to power off usb phy\n" );return ret; } }
Signature · 1 line
2.17.1
PATCH 6/7 usb: dwc3: change trace level for phy errors managed by uclass
In reply to Patrick DelaunayAs the error message is now displayed by generic phy functions, the pr_err can be change to pr_debug.
---
drivers/usb/dwc3/core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/usb/dwc3/core.c +6 -6
@@ -832,8 +832,8 @@ int dwc3_setup_phy(struct udevice *dev, struct phy **array, int *num_phys)for (i =0 ; i < count; i++) { ret =generic_phy_init (&usb_phys[i]);if (ret) { -pr_err ("Can't init USB PHY%d for %s\n" , - i, dev->name); +pr_debug ("Can't init USB PHY%d for %s\n" , + i, dev->name); goto phys_init_err; } }
@@ -841,8 +841,8 @@ int dwc3_setup_phy(struct udevice *dev, struct phy **array, int *num_phys)for (i =0 ; i < count; i++) { ret =generic_phy_power_on (&usb_phys[i]);if (ret) { -pr_err ("Can't power USB PHY%d for %s\n" , - i, dev->name); +pr_debug ("Can't power USB PHY%d for %s\n" , + i, dev->name); goto phys_poweron_err; } }
@@ -878,8 +878,8 @@ int dwc3_shutdown_phy(struct udevice *dev, struct phy *usb_phys, int num_phys) ret =generic_phy_power_off (&usb_phys[i]); ret |=generic_phy_exit (&usb_phys[i]);if (ret) { -pr_err ("Can't shutdown USB PHY%d for %s\n" , - i, dev->name); +pr_debug ("Can't shutdown USB PHY%d for %s\n" , + i, dev->name); } }
Signature · 1 line
2.17.1
PATCH 7/7 ata: dwc-ahci: change trace level for phy errors managed by uclass
In reply to Patrick DelaunayAs the error message is now displayed by generic phy functions, the pr_err can be change to pr_debug.
---
drivers/ata/dwc_ahci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/ata/dwc_ahci.c +2 -2
@@ -62,13 +62,13 @@ static int dwc_ahci_probe(struct udevice *dev) ret =generic_phy_init (&phy);if (ret) { -pr_err ("unable to initialize the sata phy\n" ); +pr_debug ("unable to initialize the sata phy\n" );return ret; } ret =generic_phy_power_on (&phy);if (ret) { -pr_err ("unable to power on the sata phy\n" ); +pr_debug ("unable to power on the sata phy\n" );return ret; }
Signature · 1 line
2.17.1