microvm: fix memory leak in microvm_fix_kernel_cmdline
PATCH 1/1 microvm: fix memory leak in microvm_fix_kernel_cmdline
In microvm_fix_kernel_cmdline(), fw_cfg_modify_string() is duplicating cmdline instead of taking ownership of it. Free it afterwards to avoid leaking it.
Reported-by Coverity (CID 1407218)
Suggested-by Peter Maydell <[email protected]>
Signed-off-by Sergio Lopez <[email protected]>
--- hw/i386/microvm.c | 2 ++ 1 file changed, 2 insertions(+)
hw/i386/microvm.c +2 -0
@@ -331,6 +331,8 @@ static void microvm_fix_kernel_cmdline(MachineState *machine)fw_cfg_modify_i32 (x86ms->fw_cfg,FW_CFG_CMDLINE_SIZE ,strlen (cmdline) +1 );fw_cfg_modify_string (x86ms->fw_cfg,FW_CFG_CMDLINE_DATA , cmdline); + +g_free (cmdline); }static void microvm_machine_state_init (MachineState *machine)
Signature · 1 line
2.23.0
Paolo Bonzini
AppliedQuoted 17 lines · Sergio Lopez
In
microvm_fix_kernel_cmdline(),fw_cfg_modify_string()is duplicating cmdline instead of taking ownership of it. Free it afterwards to avoid leaking it.Reported-by Coverity (CID 1407218)Suggested-by Peter Maydell <[email protected]>Signed-off-by Sergio Lopez <[email protected]>--- hw/i386/microvm.c | 2 ++ 1 file changed, 2 insertions(+)hw/i386/microvm.c +0
-0
hw/i386/microvm.c static void microvm_fix_kernel_cmdline(MachineState *machine) · line 338
Quoted 8 lines
hw/i386/microvm.c +2
-0@@ -331,6 +331,8 @@ static void microvm_fix_kernel_cmdline(MachineState *machine)fw_cfg_modify_i32 (x86ms->fw_cfg,FW_CFG_CMDLINE_SIZE ,strlen (cmdline) +1 );fw_cfg_modify_string (x86ms->fw_cfg,FW_CFG_CMDLINE_DATA , cmdline); + +g_free (cmdline); }static void microvm_machine_state_init (MachineState *machine)
Queued, thanks.
Paolo