Skip to contentSkip to conversation

drm/komeda: Fix komeda driver build error

PATCH In review james qian wang (Arm Technology China) 2 participants 2 messages Nov 13, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/komeda: Fix komeda driver build error

Fix the build errors lead by

'commit 4039f0293bbd ("drm/komeda: Add option to print WARN- and INFO-level IRQ events")'

---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/arm/display/komeda/komeda_dev.h +2 -2
index 15f52e304c08..d406a4d83352 100644
@@ -51,12 +51,12 @@
 
 #define KOMEDA_WARN_EVENTS	KOMEDA_ERR_CSCE
 
-#define KOMEDA_INFO_EVENTS ({0 \
+#define KOMEDA_INFO_EVENTS (0 \
 			    | KOMEDA_EVENT_VSYNC \
 			    | KOMEDA_EVENT_FLIP \
 			    | KOMEDA_EVENT_EOW \
 			    | KOMEDA_EVENT_MODE \
-			    })
+			    )
 
 /* malidp device id */
 enum {
Signature · 6 lines
2.20.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · james qian wang (Arm Technology China)

Fix the build errors lead by

'commit 4039f0293bbd ("drm/komeda: Add option to print WARN- and INFO-level IRQ events")'

Please also re-enable the komde driver (including all options) in all the defconfigs in drm-rerere. And maybe type some scripts to compile test before pushing :-)
-Daniel

Quoted 26 lines
---
 drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/arm/display/komeda/komeda_dev.h +2 -3
index 15f52e304c08..d406a4d83352 100644
@@ -51,12 +51,12 @@
 
 #define KOMEDA_WARN_EVENTS     KOMEDA_ERR_CSCE
 
-#define KOMEDA_INFO_EVENTS ({0 \
+#define KOMEDA_INFO_EVENTS (0 \
                            | KOMEDA_EVENT_VSYNC \
                            | KOMEDA_EVENT_FLIP \
                            | KOMEDA_EVENT_EOW \
                            | KOMEDA_EVENT_MODE \
-                           })
+                           )
 
 /* malidp device id */
 enum {
--

2.20.1

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch