Skip to contentSkip to conversation

rsxx: add missed destroy_workqueue calls in remove

PATCH Applied Chuhong Yuan 2 participants 2 messages Nov 13, 2019 – Nov 14, 2019 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rsxx: add missed destroy_workqueue calls in remove

The driver misses calling destroy_workqueue in remove like what is done when probe fails.
Add the missed calls to fix it.

---
 drivers/block/rsxx/core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/block/rsxx/core.c +2 -0
index 76b73ddf8fd7..10f6368117d8 100644
@@ -1000,8 +1000,10 @@ static void rsxx_pci_remove(struct pci_dev *dev)
 
 	cancel_work_sync(&card->event_work);
 
+	destroy_workqueue(card->event_wq);
 	rsxx_destroy_dev(card);
 	rsxx_dma_destroy(card);
+	destroy_workqueue(card->creg_ctrl.creg_wq);
 
 	spin_lock_irqsave(&card->irq_lock, flags);
 	rsxx_disable_ier_and_isr(card, CR_INTR_ALL);
Signature · 1 line
2.23.0
maintainer Applied
#1 lore raw
Quoted 3 lines · Chuhong Yuan

The driver misses calling destroy_workqueue in remove like what is done when probe fails.
Add the missed calls to fix it.

Applied, thanks.

Signature · 1 line
Jens Axboe