Skip to contentSkip to conversation

pinctrl: rza1: remove unnecessary static inline function

PATCH In review Matti Vaittinen 2 participants 2 messages Nov 13, 2019 – Nov 21, 2019

Subsystems (2)
GPIO Pin control
lore
Share & tools
lore

Matti Vaittinen

author
#0 lore raw

PATCH v2 1/2 pinctrl: rza1: remove unnecessary static inline function

Having static inline oneliner does not benefit too mucg when it is only called from another oneliner function. Remove some of the 'onion'. This simplifies also the coming usage of the gpiolib defines. We can do conversion from chip bits to gpiolib direction defines as last step in the get_direction callback. Drivers can use chip specific values in driver internal functions and do conversion only once.

Signed-off-by Matti Vaittinen <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

---

Changes since v1: Subject fixed as pointed out by Geert.

 drivers/pinctrl/pinctrl-rza1.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/pinctrl/pinctrl-rza1.c +1 -7
index 017fc6b3e27e..215db220d795 100644
@@ -617,12 +617,6 @@ static void rza1_pin_reset(struct rza1_port *port, unsigned int pin)
 	spin_unlock_irqrestore(&port->lock, irqflags);
 }
 
-static inline int rza1_pin_get_direction(struct rza1_port *port,
-					 unsigned int pin)
-{
-	return !!rza1_get_bit(port, RZA1_PM_REG, pin);
-}
-
 /**
  * rza1_pin_set_direction() - set I/O direction on a pin in port mode
  *

@@ -783,7 +777,7 @@ static int rza1_gpio_get_direction(struct gpio_chip *chip, unsigned int gpio)
 {
 	struct rza1_port *port = gpiochip_get_data(chip);
 
-	return rza1_pin_get_direction(port, gpio);
+	return !!rza1_get_bit(port, RZA1_PM_REG, gpio);
 }
 
 static int rza1_gpio_direction_input(struct gpio_chip *chip,

base-commit: 70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c

Signature · 14 lines
2.21.0


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
#1 lore raw
Quoted 8 lines · Matti Vaittinen

Having static inline oneliner does not benefit too mucg when it is only called from another oneliner function. Remove some of the 'onion'. This simplifies also the coming usage of the gpiolib defines. We can do conversion from chip bits to gpiolib direction defines as last step in the get_direction callback. Drivers can use chip specific values in driver internal functions and do conversion only once.

Quoted 6 lines
Signed-off-by Matti Vaittinen <[email protected]>
Reviewed-by Geert Uytterhoeven <[email protected]>
Acked-by Geert Uytterhoeven <[email protected]>

---

Changes since v1: Subject fixed as pointed out by Geert.

Patch applied.

Yours,
Linus Walleij