gpio: mmio: remove untrue leftover comment
PATCH 1/1 gpio: mmio: remove untrue leftover comment
The comment should have been removed when new GPIO direction definitions were taken in use as the function logic was changed. It is now perfectly valid and Ok to hit the return from the bottom of the direction getting function.
---
Sorry guys. Just noticed that I should've removed this comment in original patch series.
drivers/gpio/gpio-mmio.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpio/gpio-mmio.c +0 -1
@@ -386,7 +386,6 @@ static int bgpio_get_dir(struct gpio_chip *gc, unsigned int gpio)if (!(gc->read_reg (gc->reg_dir_in) &bgpio_line2mask (gc, gpio)))return GPIO_LINE_DIRECTION_OUT ; -/* This should not happen */ return GPIO_LINE_DIRECTION_IN ; }
base-commit: 70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c
Signature · 14 lines
2.21.0 -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
Bartosz Golaszewski
Appliedśr., 13 lis 2019 o 09:44 Matti Vaittinen
<[email protected]> napisał(a):
Quoted 40 lines
The comment should have been removed when new GPIO direction definitions were taken in use as the function logic was changed. It is now perfectly valid and Ok to hit the return from the bottom of the direction getting function.
Signed-off-by Matti Vaittinen <[email protected]>---
Sorry guys. Just noticed that I should've removed this comment in original patch series.
drivers/gpio/gpio-mmio.c | 1 - 1 file changed, 1 deletion(-)drivers/gpio/gpio-mmio.c +0
-1@@ -386,7 +386,6 @@ static int bgpio_get_dir(struct gpio_chip *gc, unsigned int gpio)if (!(gc->read_reg (gc->reg_dir_in) &bgpio_line2mask (gc, gpio)))return GPIO_LINE_DIRECTION_OUT ; -/* This should not happen */ return GPIO_LINE_DIRECTION_IN ; }base-commit:
70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c--
2.21.0--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
Quoted 4 lines
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
Queued for v5.5, thanks!
Bartosz