Skip to contentSkip to conversation

auto-t: add ctrl_interface to testOWE

PATCH In review James Prestwood 2 participants 6 messages Nov 13, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/5 auto-t: add ctrl_interface to testOWE

This is now required for any test using HostapdCLI

---
 autotests/testOWE/ssidGroup20.conf | 1 +
 autotests/testOWE/ssidOWE.conf     | 1 +
 2 files changed, 2 insertions(+)
autotests/testOWE/ssidGroup20.conf +1 -0
index 72f84091..afd5c0a4 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=ssidGroup20
autotests/testOWE/ssidOWE.conf +1 -0
index b9c79d82..a0a4f26c 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=ssidOWE
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/5 auto-t: add ctrl_interface to testFILS

This is now required for any test using HostapdCLI

---
 autotests/testFILS/ssidFILS-256.conf | 1 +
 autotests/testFILS/ssidFILS-384.conf | 1 +
 2 files changed, 2 insertions(+)
autotests/testFILS/ssidFILS-256.conf +1 -0
index bf86d3f4..b3f3139a 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=ssidFILS-256
autotests/testFILS/ssidFILS-384.conf +1 -0
index a090d537..9a3a3059 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=ssidFILS-384
Signature · 1 line
2.17.1
#2 lore raw

PATCH 3/5 auto-t: add ctrl_interface to testHT-VHT

In reply to James Prestwood

This is now required for any test using HostapdCLI

---
 autotests/testHT-VHT/ht.conf         | 1 +
 autotests/testHT-VHT/non-ht-vht.conf | 1 +
 autotests/testHT-VHT/vht.conf        | 1 +
 3 files changed, 3 insertions(+)
autotests/testHT-VHT/ht.conf +1 -0
index b5dbc0d5..9a84b063 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=a
 channel=2
 ssid=testSSID
autotests/testHT-VHT/non-ht-vht.conf +1 -0
index ae6e2dac..6df06a02 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 ssid=testSSID
autotests/testHT-VHT/vht.conf +1 -0
index 23453a76..9a7ec0d7 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 ssid=testSSID
 wpa=2
 wpa_pairwise=CCMP
Signature · 1 line
2.17.1
#3 lore raw

PATCH 4/5 auto-t: add ctrl_interface to testHotspot

In reply to James Prestwood

This is now required for any test using HostapdCLI

---
 autotests/testHotspot/ssidHotspotUnconfigured.conf | 1 +
 autotests/testHotspot/ssidWPA2-1.conf              | 1 +
 autotests/testHotspot/ssidWPA2-2.conf              | 1 +
 autotests/testHotspot/ssidWPA2-3.conf              | 1 +
 4 files changed, 4 insertions(+)
autotests/testHotspot/ssidHotspotUnconfigured.conf +1 -0
index 5eff0b10..287dab6c 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=1
 wpa=2
autotests/testHotspot/ssidWPA2-1.conf +1 -0
index bc1b760c..0c9aede5 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=2
 ssid=ssidWPA2-1
autotests/testHotspot/ssidWPA2-2.conf +1 -0
index 59b05986..2058d4a3 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=3
 ssid=ssidWPA2-2
autotests/testHotspot/ssidWPA2-3.conf +1 -0
index c330eb8a..d536ebd1 100644
@@ -1,3 +1,4 @@
+ctrl_interface=/var/run/hostapd
 hw_mode=g
 channel=4
 ssid=ssidWPA2-3
Signature · 1 line
2.17.1
#4 lore raw

PATCH 5/5 hotspot: fix double free between hostpot and knownnetworks

In reply to James Prestwood

The module framework was changed to call the module exit functions in the reverse order as the init functions. This uncovered/caused known networks to try and free the network_info structures after hotspot had already freed them. Since known networks clean up the network_info's anyways, we don't actually need hotspot to do any cleanup.

---
 src/hotspot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/hotspot.c +1 -1
index 68fc5a66..6a95757b 100644
@@ -524,7 +524,7 @@ static void hotspot_exit(void)
 {
 	l_dir_watch_destroy(hs20_dir_watch);
 
-	l_queue_destroy(hs20_settings, hs20_config_free);
+	l_queue_destroy(hs20_settings, NULL);
 	hs20_settings = NULL;
 }
 
Signature · 1 line
2.17.1
#5 lore raw
In reply to James Prestwood

Hi James,

Quoted 6 lines · James Prestwood

This is now required for any test using HostapdCLI

---
  autotests/testOWE/ssidGroup20.conf | 1 +
  autotests/testOWE/ssidOWE.conf     | 1 +
  2 files changed, 2 insertions(+)

all applied, thanks.

Regards,
-Denis