Skip to contentSkip to conversation

include/configs: ls1012a: add pfe stop command

PATCH Superseded Biwen Li 2 participants 3 messages Nov 14, 2019 – Nov 15, 2019

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Biwen Li

author
#0 lore raw

PATCH v2 1/1 include/configs: ls1012a: add pfe stop command

This adds pfe stop command before enter linux kernel to fix a problem that ethernet won't be workable after enter linux

Why need execute the command before enter
linux kernel?
- There is a h/w limitation in LS1012A PFE, to
re-initialize PFE it has to be safe shutdown,
these steps are done through PFE stop.

---
Changes in v2:
- trim subject
- add why

 include/configs/ls1012a2g5rdb.h | 2 +-
 include/configs/ls1012afrdm.h   | 2 +-
 include/configs/ls1012afrwy.h   | 4 ++--
 include/configs/ls1012ardb.h    | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
include/configs/ls1012a2g5rdb.h +1 -1
index cb329385d9..5943b69716 100644
@@ -85,7 +85,7 @@
 	"installer=load mmc 0:2 $load_addr "	\
 		   "/flex_installer_arm64.itb; "	\
 		   "bootm $load_addr#$board\0"	\
-	"qspi_bootcmd=echo Trying load from qspi..;"	\
+	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
 		"sf probe && sf read $load_addr "	\
 		"$kernel_addr $kernel_size; env exists secureboot "	\
 		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
include/configs/ls1012afrdm.h +1 -1
index 8c7d4e558d..8a3ebf06f2 100644
@@ -60,7 +60,7 @@
 	"installer=load usb 0:2 $load_addr "	\
 		   "/flex_installer_arm64.itb; "	\
 		   "bootm $load_addr#$board\0"	\
-	"qspi_bootcmd=echo Trying load from qspi..;"	\
+	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
 		"sf probe && sf read $load_addr "	\
 		"$kernel_addr $kernel_size && bootm $load_addr#$board\0"
 
include/configs/ls1012afrwy.h +2 -2
index 1b0f1566d3..a2ca326cfc 100644
@@ -109,13 +109,13 @@
 	"installer=load mmc 0:2 $load_addr "	\
 		   "/flex_installer_arm64.itb; "	\
 		   "bootm $load_addr#$board\0"	\
-	"qspi_bootcmd=echo Trying load from qspi..;"	\
+	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
 		"sf probe && sf read $load_addr "	\
 		"$kernel_addr $kernel_size; env exists secureboot "	\
 		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
 		"$kernelheader_size && esbc_validate ${kernelheader_addr_r}; " \
 		"bootm $load_addr#$board\0"	\
-	"sd_bootcmd=echo Trying load from sd card..;"		\
+	"sd_bootcmd=pfe stop; echo Trying load from sd card..;"		\
 		"mmcinfo; mmc read $load_addr "			\
 		"$kernel_addr_sd $kernel_size_sd ;"		\
 		"env exists secureboot && mmc read $kernelheader_addr_r "\
include/configs/ls1012ardb.h +1 -1
index a5e27404f8..39166fea7d 100644
@@ -109,7 +109,7 @@
 	"installer=load mmc 0:2 $load_addr "	\
 		   "/flex_installer_arm64.itb; "	\
 		   "bootm $load_addr#$board\0"	\
-	"qspi_bootcmd=echo Trying load from qspi..;"	\
+	"qspi_bootcmd=pfe stop; echo Trying load from qspi..;"	\
 		"sf probe && sf read $load_addr "	\
 		"$kernel_addr $kernel_size; env exists secureboot "	\
 		"&& sf read $kernelheader_addr_r $kernelheader_addr "	\
Signature · 1 line
2.17.1
#1 lore raw

PATCH v2 1/1 include/configs: ls1012a: add pfe stop command

Quoted 12 lines

-----Original Message-----
From: Biwen Li <[email protected]>
Sent: Thursday, November 14, 2019 10:15 AM
To: Shengzhou Liu <[email protected]>; Alison Wang <[email protected]>; Jagdish Gediya <[email protected]>; Rajesh Bhagat <[email protected]>; Priyanka Jain <[email protected]>
Cc: Jiafei Pan <[email protected]>; Xiaobo Xie <[email protected]>; u- boot at lists.denx.de; Biwen Li <[email protected]>
Subject: [v2] include/configs: ls1012a: add pfe stop command

Quoted 4 lines

This adds pfe stop command before enter linux kernel to fix a problem that ethernet won't be workable after enter linux

Why need execute the command before enter linux kernel?

No need to add question. The description needs to be in passive voice. Add something like. 'pfe stop' command is required because

Quoted 10 lines

- There is a h/w limitation in LS1012A PFE, to
re-initialize PFE it has to be safe shutdown,
these steps are done through PFE stop.

---
Changes in v2:
- trim subject
- add why

<snip>
-priyankajain

author
#2 lore raw

PATCH v2 1/1 include/configs: ls1012a: add pfe stop command

Quoted 24 lines

-----Original Message-----
From: Priyanka Jain <[email protected]>
Sent: 2019年11月15日 12:57
To: Biwen Li <[email protected]>; Shengzhou Liu <[email protected]>; Alison Wang <[email protected]>; Jagdish Gediya <[email protected]>; Rajesh Bhagat <[email protected]>
Cc: Jiafei Pan <[email protected]>; Xiaobo Xie <[email protected]>; u-boot at lists.denx.de; Biwen Li <[email protected]>
Subject: RE: [v2] include/configs: ls1012a: add pfe stop command

Quoted 10 lines

-----Original Message-----
From: Biwen Li <[email protected]>
Sent: Thursday, November 14, 2019 10:15 AM
To: Shengzhou Liu <[email protected]>; Alison Wang <[email protected]>; Jagdish Gediya <[email protected]>; Rajesh Bhagat <[email protected]>; Priyanka Jain <[email protected]>
Cc: Jiafei Pan <[email protected]>; Xiaobo Xie <[email protected]>; u- boot at lists.denx.de; Biwen Li <[email protected]>
Subject: [v2] include/configs: ls1012a: add pfe stop command

Quoted 6 lines
Quoted 4 lines

This adds pfe stop command before enter linux kernel to fix a problem that ethernet won't be workable after enter linux

Why need execute the command before enter linux kernel?

No need to add question. The description needs to be in passive voice. Add something like. 'pfe stop' command is required because

Okay, will be update in v3.

Quoted 12 lines
Quoted 10 lines

- There is a h/w limitation in LS1012A PFE, to
re-initialize PFE it has to be safe shutdown,
these steps are done through PFE stop.

---
Changes in v2:
- trim subject
- add why

<snip>
-priyankajain