Skip to contentSkip to conversation

systemd: remove ${PN}-xorg-xinitrc

PATCH New [email protected] 1 participant 1 message Nov 15, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 systemd: remove ${PN}-xorg-xinitrc

From: Kai Kang <[email protected]>

In 50-systemd-user.sh which is packaged to sub-package ${PN}-xorg-xinitrc, it exports environment variables DISPLAY and XAUTHORITY to systemd. It fails to start systemd services which require these environment variables such as thunar.service:

root@qemux86-64:~# systemctl --user status thunar
● thunar.service - Thunar file manager
Loaded: loaded (/usr/lib/systemd/user/thunar.service; disabled; vendor preset: enabled)
Active: inactive (dead)
Docs: man:Thunar(1)
Nov 14 07:47:29 qemux86-64 systemd[352]: Starting Thunar file manager...
Nov 14 07:47:29 qemux86-64 Thunar[873]: cannot open display:
Nov 14 07:47:29 qemux86-64 systemd[352]: thunar.service: Main process exited, code=exited, status=1/FAILURE
Nov 14 07:47:29 qemux86-64 systemd[352]: thunar.service: Failed with result 'exit-code'.
Nov 14 07:47:29 qemux86-64 systemd[352]: Failed to start Thunar file manager.

It is not convenient to make all such kind of packages require package ${PN}-xorg-xinitrc, so remove the sub-package and merge the only file provided by it to main package.

No recipe depends on ${PN}-xorg-xinitrc in oe-core and meta-openembedded now, so no need to set rprovides for it.

---
 meta/recipes-core/systemd/systemd_243.bb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
meta/recipes-core/systemd/systemd_243.bb +1 -3
index 54fcc6a5d1..b0fadb23ad 100644
@@ -316,7 +316,6 @@ PACKAGES =+ "\
     ${PN}-rpm-macros \
     ${PN}-binfmt \
     ${PN}-zsh-completion \
-    ${PN}-xorg-xinitrc \
     ${PN}-container \
     ${PN}-journal-gatewayd \
     ${PN}-journal-upload \
@@ -378,8 +377,6 @@ FILES_${PN}-kernel-install = "${bindir}/kernel-install \
 FILES_${PN}-rpm-macros = "${exec_prefix}/lib/rpm \
                          "
 
-FILES_${PN}-xorg-xinitrc = "${sysconfdir}/X11/xinit/xinitrc.d/*"
-
 FILES_${PN}-zsh-completion = "${datadir}/zsh/site-functions"
 
 FILES_${PN}-binfmt = "${sysconfdir}/binfmt.d/ \
@@ -528,6 +525,7 @@ FILES_${PN} = " ${base_bindir}/* \
                 ${sysconfdir}/xdg/ \
                 ${sysconfdir}/init.d/README \
                 ${sysconfdir}/resolv-conf.systemd \
+                ${sysconfdir}/X11/xinit/xinitrc.d/* \
                 ${rootlibexecdir}/systemd/* \
                 ${systemd_unitdir}/* \
                 ${base_libdir}/security/*.so \
Signature · 1 line
2.17.1