Skip to contentSkip to conversation

8250-men-mcb: fix signed/unsigned confusion

DISCUSSION Pavel Machek 2 participants 2 messages Nov 15, 2019 – Nov 16, 2019 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 12 lines · Greg KH
Quoted 11 lines · Pavel Machek

Hi!

Commit 5210a3a722543fc25b8830d2236dcbe2c8178468 fixes part of signed/unsigned confusion, but not all of it.

8250-men-mcb: fix error checking when get_num_ports returns -ENODEV Upstream commit f50b6805dbb993152025ec04dea094c40cc93a0c

Fix function returning -ENODEV to signed prototype, and make error check consistent between two functions.

Quoted 8 lines
Quoted 2 lines

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond

Not sure what is supposed to be friendly about this bot.

Anyway, it would be nice if authors of 5210a3a722543fc25b8830d2236dcbe2c8178468 picked this up. I have no way to test it.

Pavel

Signature · 2 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw
Quoted 16 lines · Pavel Machek
Quoted 15 lines · Greg KH
Quoted 13 lines · Pavel Machek

Hi!

Commit 5210a3a722543fc25b8830d2236dcbe2c8178468 fixes part of signed/unsigned confusion, but not all of it.

8250-men-mcb: fix error checking when get_num_ports returns -ENODEV Upstream commit f50b6805dbb993152025ec04dea094c40cc93a0c

Fix function returning -ENODEV to signed prototype, and make error check consistent between two functions.

Quoted 7 lines
Quoted 5 lines

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond

Not sure what is supposed to be friendly about this bot.

How was it not? Did it not say exactly what was wrong with the patch and how to change it to make it acceptable?

Quoted 3 lines

Anyway, it would be nice if authors of 5210a3a722543fc25b8830d2236dcbe2c8178468 picked this up. I have no way to test it.

As the bot said, this patch is not acceptable as-is, sorry. There's no way it can be 'picked up' in this format.

thanks,

greg k-h