8250-men-mcb: fix signed/unsigned confusion
A message that is not in the archive (sent off-list or not yet received): [email protected]
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 12 lines · Greg KH
Quoted 11 lines · Pavel Machek
Hi!
Commit
5210a3a722543fc25b8830d2236dcbe2c8178468fixes part of signed/unsigned confusion, but not all of it.8250-men-mcb: fix error checking when
get_num_portsreturns-ENODEVUpstream commitf50b6805dbb993152025ec04dea094c40cc93a0cFix function returning
-ENODEVto signed prototype, and make error check consistent between two functions.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Pavel Machek <[email protected]>Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond
Not sure what is supposed to be friendly about this bot.
Anyway, it would be nice if authors of 5210a3a722543fc25b8830d2236dcbe2c8178468 picked this up. I have no way to test it.
Pavel
Signature · 2 lines
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Quoted 16 lines · Pavel Machek
Quoted 15 lines · Greg KH
Quoted 13 lines · Pavel Machek
Hi!
Commit
5210a3a722543fc25b8830d2236dcbe2c8178468fixes part of signed/unsigned confusion, but not all of it.8250-men-mcb: fix error checking when
get_num_portsreturns-ENODEVUpstream commitf50b6805dbb993152025ec04dea094c40cc93a0cFix function returning
-ENODEVto signed prototype, and make error check consistent between two functions.Signed-off-by Pavel Machek <[email protected]>
Quoted 7 lines
Quoted 5 lines
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond
Not sure what is supposed to be friendly about this bot.
How was it not? Did it not say exactly what was wrong with the patch and how to change it to make it acceptable?
Quoted 3 lines
Anyway, it would be nice if authors of
5210a3a722543fc25b8830d2236dcbe2c8178468picked this up. I have no way to test it.
As the bot said, this patch is not acceptable as-is, sorry. There's no way it can be 'picked up' in this format.
thanks,
greg k-h