Skip to contentSkip to conversation

media: venus: firmware: Use %pR to print IO resource

PATCH In review Andy Shevchenko 2 participants 3 messages Nov 15, 2019 – Jan 8, 2020

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: venus: firmware: Use %pR to print IO resource

Replace explicit use of members of struct resource by %pR to print the resource.

---
 drivers/media/platform/qcom/venus/firmware.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/platform/qcom/venus/firmware.c +1 -2
index d3d1748a7ef6..de6812fb55f4 100644
@@ -100,8 +100,7 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
 
 	mem_va = memremap(r.start, *mem_size, MEMREMAP_WC);
 	if (!mem_va) {
-		dev_err(dev, "unable to map memory region: %pa+%zx\n",
-			&r.start, *mem_size);
+		dev_err(dev, "unable to map memory region: %pR\n", &r);
 		ret = -ENOMEM;
 		goto err_release_fw;
 	}
Signature · 1 line
2.24.0
#1 lore raw
Quoted 2 lines · Andy Shevchenko

Replace explicit use of members of struct resource by %pR to print the resource.

Any comment on this?

Quoted 23 lines
---
 drivers/media/platform/qcom/venus/firmware.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/media/platform/qcom/venus/firmware.c +1 -2
index d3d1748a7ef6..de6812fb55f4 100644
@@ -100,8 +100,7 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
 
 	mem_va = memremap(r.start, *mem_size, MEMREMAP_WC);
 	if (!mem_va) {
-		dev_err(dev, "unable to map memory region: %pa+%zx\n",
-			&r.start, *mem_size);
+		dev_err(dev, "unable to map memory region: %pR\n", &r);
 		ret = -ENOMEM;
 		goto err_release_fw;
 	}
Signature · 1 line
2.24.0
Signature · 2 lines
With Best Regards,
Andy Shevchenko
Acked-by on v1 1/1
#2 lore raw
In reply to Andy Shevchenko

Hi Andy,

Thanks for the patch!

Quoted 7 lines · Andy Shevchenko

Replace explicit use of members of struct resource by %pR to print the resource.

---
 drivers/media/platform/qcom/venus/firmware.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Quoted 16 lines
drivers/media/platform/qcom/venus/firmware.c +1 -2
index d3d1748a7ef6..de6812fb55f4 100644
@@ -100,8 +100,7 @@ static int venus_load_fw(struct venus_core *core, const char *fwname,
 
 	mem_va = memremap(r.start, *mem_size, MEMREMAP_WC);
 	if (!mem_va) {
-		dev_err(dev, "unable to map memory region: %pa+%zx\n",
-			&r.start, *mem_size);
+		dev_err(dev, "unable to map memory region: %pR\n", &r);
 		ret = -ENOMEM;
 		goto err_release_fw;
 	}
Signature · 2 lines
regards,
Stan