Skip to contentSkip to conversation

crypto: mips/chacha - select CRYPTO_SKCIPHER, not CRYPTO_BLKCIPHER

PATCH In review Eric Biggers 3 participants 3 messages Nov 17, 2019 – Nov 22, 2019 Crypto API

lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH 1/1 crypto: mips/chacha - select CRYPTO_SKCIPHER, not CRYPTO_BLKCIPHER

From: Eric Biggers <[email protected]>

Another instance of CRYPTO_BLKCIPHER made it in just after it was renamed to CRYPTO_SKCIPHER. Fix it.

Signed-off-by Eric Biggers <[email protected]>
---
 crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
crypto/Kconfig +1 -1
index 472c2ad36063..5575d48473bd 100644
@@ -1487,7 +1487,7 @@ config CRYPTO_CHACHA20_X86_64
 config CRYPTO_CHACHA_MIPS
 	tristate "ChaCha stream cipher algorithms (MIPS 32r2 optimized)"
 	depends on CPU_MIPS32_R2
-	select CRYPTO_BLKCIPHER
+	select CRYPTO_SKCIPHER
 	select CRYPTO_ARCH_HAVE_LIB_CHACHA
 
 config CRYPTO_SEED
Signature · 1 line
2.24.0
Acked-by on v1 1/1
#1 lore raw
Quoted 7 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Another instance of CRYPTO_BLKCIPHER made it in just after it was renamed to CRYPTO_SKCIPHER. Fix it.

Signed-off-by Eric Biggers <[email protected]>

Thanks Eric

Acked-by Ard Biesheuvel <[email protected]>
Quoted 20 lines
---
 crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
crypto/Kconfig +1 -2
index 472c2ad36063..5575d48473bd 100644
@@ -1487,7 +1487,7 @@ config CRYPTO_CHACHA20_X86_64
 config CRYPTO_CHACHA_MIPS
        tristate "ChaCha stream cipher algorithms (MIPS 32r2 optimized)"
        depends on CPU_MIPS32_R2
-       select CRYPTO_BLKCIPHER
+       select CRYPTO_SKCIPHER
        select CRYPTO_ARCH_HAVE_LIB_CHACHA
 
 config CRYPTO_SEED
--

2.24.0

maintainer
#2 lore raw
In reply to Eric Biggers
Quoted 9 lines · Eric Biggers

From: Eric Biggers <[email protected]>

Another instance of CRYPTO_BLKCIPHER made it in just after it was renamed to CRYPTO_SKCIPHER. Fix it.

Signed-off-by Eric Biggers <[email protected]>
---
 crypto/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt