Skip to contentSkip to conversation

rrm: remove use of floating point math

PATCH Applied James Prestwood 2 participants 2 messages Nov 18, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rrm: remove use of floating point math

The RCPI value was using floating point values as per the spec. But instead we can just use the signal strength coming from the kernel in mili mdm and scale the hard coded values by a factor of 100.

---
 src/rrm.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
src/rrm.c +3 -5
index 4c736910..2b0a22fb 100644
@@ -25,7 +25,6 @@
 #endif
 
 #include <stdint.h>
-#include <math.h>
 #include <linux/if_ether.h>
 
 #include <ell/ell.h>
@@ -247,7 +246,6 @@ static size_t build_report_for_bss(struct rrm_beacon_req_info *beacon,
 					uint8_t *to)
 {
 	uint8_t *start = to;
-	double dbms = bss->signal_strength / 100;
 
 	*to++ = beacon->oper_class;
 	*to++ = scan_freq_to_channel(bss->frequency, NULL);
@@ -259,10 +257,10 @@ static size_t build_report_for_bss(struct rrm_beacon_req_info *beacon,
 	*to++ = rrm_phy_type(bss);
 
 	/* 802.11 Table 9-154 - RCPI values */
-	if (dbms < -109.5)
+	if (bss->signal_strength < -10950)
 		*to++ = 0;
-	else if (dbms >= -109.5 && dbms < 0)
-		*to++ = (uint8_t)floor(2 * (dbms + 110));
+	else if (bss->signal_strength >= -10950 && bss->signal_strength < 0)
+		*to++ = (uint8_t)((2 * (bss->signal_strength + 11000)) / 100);
 	else
 		*to++ = 220;
 
Signature · 1 line
2.17.1
#1 lore raw

Hi James,

Quoted 7 lines · James Prestwood

The RCPI value was using floating point values as per the spec. But instead we can just use the signal strength coming from the kernel in mili mdm and scale the hard coded values by a factor of 100.

---
  src/rrm.c | 8 +++-----
  1 file changed, 3 insertions(+), 5 deletions(-)

Applied, thanks.

Regards,
-Denis