Skip to contentSkip to conversation

travis.yml: Remove the redundant clang-with-MAIN_SOFTMMU_TARGETS entry

PATCH In review Thomas Huth 3 participants 3 messages Nov 19, 2019 – Dec 18, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 travis.yml: Remove the redundant clang-with-MAIN_SOFTMMU_TARGETS entry

We test clang with the MAIN_SOFTMMU_TARGETS twice, once without sanitizers and once with sanitizers enabled. That's somewhat redundant since if compilation and tests succeeded with sanitizers enabled, it should also work fine without sanitizers. Thus remove the clang entry without sanitizers to speed up the CI testing a little bit.

---
 .travis.yml | 6 ------
 1 file changed, 6 deletions(-)
.travis.yml +0 -6
index b9a026c8ee..47875bdafe 100644
@@ -181,12 +181,6 @@ matrix:
       compiler: clang
 
 
-    - env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
-      compiler: clang
-
-
     - env:
         - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Thomas Huth

We test clang with the MAIN_SOFTMMU_TARGETS twice, once without sanitizers and once with sanitizers enabled. That's somewhat redundant since if compilation and tests succeeded with sanitizers enabled, it should also work fine without sanitizers. Thus remove the clang entry without sanitizers to speed up the CI testing a little bit.

---
  .travis.yml | 6 ------
  1 file changed, 6 deletions(-)
Quoted 18 lines
.travis.yml +0 -6
index b9a026c8ee..47875bdafe 100644
@@ -181,12 +181,6 @@ matrix:
        compiler: clang
 
 
-    - env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
-      compiler: clang
-
-
      - env:
          - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
          - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
#2 lore raw
In reply to Thomas Huth
Quoted 5 lines · Thomas Huth

We test clang with the MAIN_SOFTMMU_TARGETS twice, once without sanitizers and once with sanitizers enabled. That's somewhat redundant since if compilation and tests succeeded with sanitizers enabled, it should also work fine without sanitizers. Thus remove the clang entry without sanitizers to speed up the CI testing a little bit.

Queued to pullreq/testing-logging-misc, thanks.

Quoted 23 lines
---
 .travis.yml | 6 ------
 1 file changed, 6 deletions(-)
.travis.yml +0 -6
index b9a026c8ee..47875bdafe 100644
@@ -181,12 +181,6 @@ matrix:
       compiler: clang
 
 
-    - env:
-        - CONFIG="--disable-user --target-list=${MAIN_SOFTMMU_TARGETS}"
-        - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-default"
-      compiler: clang
-
-
     - env:
         - CONFIG="--target-list=${MAIN_SOFTMMU_TARGETS} "
         - CACHE_NAME="${TRAVIS_BRANCH}-linux-clang-sanitize"
Signature · 1 line
Alex Bennée