Skip to contentSkip to conversation

drm/amdgpu: apply gpr/gds workaround before enabling GFX EDC mode

PATCH In review Hawking Zhang 2 participants 2 messages Nov 20, 2019 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amdgpu: apply gpr/gds workaround before enabling GFX EDC mode

gfx memory should be initialized before enabling
DED and FUE field in mmGB_EDC_MODE

Change-Id I248a087364cbd9858cba32a70be456af3f07c90d
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +4 -4
index 0d6965ba7a86..68359059e390 100644
@@ -4213,10 +4213,6 @@ static int gfx_v9_0_ecc_late_init(void *handle)
 	struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 	int r;
 
-	r = amdgpu_gfx_ras_late_init(adev);
-	if (r)
-		return r;
-
 	r = gfx_v9_0_do_edc_gds_workarounds(adev);
 	if (r)
 		return r;
@@ -4226,6 +4222,10 @@ static int gfx_v9_0_ecc_late_init(void *handle)
 	if (r)
 		return r;
 
+	r = amdgpu_gfx_ras_late_init(adev);
+	if (r)
+		return r;
+
 	return 0;
 }
 
Signature · 6 lines
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

A message that is not in the archive (sent off-list or not yet received): 20191120123643.16416-1-Hawking.Zhang-5C7GfCeVMHo@public.gmane.org

Reviewed-by
#2 lore raw

________________________________
From: Hawking Zhang <[email protected]>
Sent: Wednesday, November 20, 2019 7:36 AM
To: [email protected] <[email protected]>; Chen, Guchun <[email protected]>; Clements, John <[email protected]>; Deucher, Alexander <[email protected]>
Cc: Zhang, Hawking <[email protected]>
Subject: [PATCH] drm/amdgpu: apply gpr/gds workaround before enabling GFX EDC mode

gfx memory should be initialized before enabling
DED and FUE field in mmGB_EDC_MODE

Change-Id I248a087364cbd9858cba32a70be456af3f07c90d
---
 drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c +4 -4
index 0d6965ba7a86..68359059e390 100644
@@ -4213,10 +4213,6 @@ static int gfx_v9_0_ecc_late_init(void *handle)
         struct amdgpu_device *adev = (struct amdgpu_device *)handle;
         int r;
 
-       r = amdgpu_gfx_ras_late_init(adev);
-       if (r)
-               return r;
-
         r = gfx_v9_0_do_edc_gds_workarounds(adev);
         if (r)
                 return r;
@@ -4226,6 +4222,10 @@ static int gfx_v9_0_ecc_late_init(void *handle)
         if (r)
                 return r;
 
+       r = amdgpu_gfx_ras_late_init(adev);
+       if (r)
+               return r;
+
         return 0;
 }
 

--
2.17.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx