xen: Add missing va_end() in hypercall_create_continuation()
PATCH 1/1 xen: Add missing va_end() in hypercall_create_continuation()
From: Julien Grall <[email protected]>
The documentation requires va_start() to always be matched with a corresponding va_end(). However, this is not the case in the path used for bad format.
This was introduced by XSA-296.
Coverity-ID: 1488727
--- xen/arch/arm/domain.c | 1 + xen/arch/x86/hypercall.c | 1 + 2 files changed, 2 insertions(+)
xen/arch/arm/domain.c +1 -0
@@ -467,6 +467,7 @@ unsigned long hypercall_create_continuation(return rc; bad_fmt: +va_end (args);gprintk (XENLOG_ERR ,"Bad hypercall continuation format '%c'\n" , *p);ASSERT_UNREACHABLE ();domain_crash (current->domain);
xen/arch/x86/hypercall.c +1 -0
@@ -157,6 +157,7 @@ unsigned long hypercall_create_continuation(return op; bad_fmt: +va_end (args);gprintk (XENLOG_ERR ,"Bad hypercall continuation format '%c'\n" , *p);ASSERT_UNREACHABLE ();domain_crash (curr->domain);
Signature · 7 lines
2.24.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 11 lines · Julien Grall
From: Julien Grall <[email protected]>
The documentation requires
va_start()to always be matched with a correspondingva_end(). However, this is not the case in the path used for bad format.This was introduced by XSA-296.
Coverity-ID: 1488727
Fixes 0bf9f8d3e3 ("xen/hypercall: Don't use BUG() for parameter checking in hypercall_create_continuation()")Signed-off-by Julien Grall <[email protected]>
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Andrew Cooper
Reviewed-byQuoted 7 lines · Jan Beulich
Quoted 6 lines · Julien Grall
From: Julien Grall <[email protected]>
The documentation requires
va_start()to always be matched with a correspondingva_end(). However, this is not the case in the path used for bad format.
Quoted 6 lines
Quoted 5 lines
This was introduced by XSA-296.
Coverity-ID: 1488727
Fixes 0bf9f8d3e3 ("xen/hypercall: Don't use BUG() for parameter checking in hypercall_create_continuation()")Signed-off-by Julien Grall <[email protected]>Reviewed-by Jan Beulich <[email protected]>
+ Juergen. This is a bugfix to XSA-296 so will end up going out on older branches.
~Andrew
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Quoted 8 lines · Andrew Cooper
Quoted 7 lines · Jan Beulich
Quoted 6 lines · Julien Grall
From: Julien Grall <[email protected]>
The documentation requires
va_start()to always be matched with a correspondingva_end(). However, this is not the case in the path used for bad format.
Quoted 8 lines
Quoted 6 lines
Quoted 5 lines
This was introduced by XSA-296.
Coverity-ID: 1488727
Fixes 0bf9f8d3e3 ("xen/hypercall: Don't use BUG() for parameter checking in hypercall_create_continuation()")Signed-off-by Julien Grall <[email protected]>Reviewed-by Jan Beulich <[email protected]>Reviewed-by Andrew Andrew Cooper <[email protected]>
Juergen
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel