aplay: Limit VUMeter progress bar to 100 for negative as well
PATCH v2 1/1 aplay: Limit VUMeter progress bar to 100 for negative as well
While the progress bar cannot be negative, GCC concludes that it can be and assumes tmp can be written past the end. Fixes this GCC warning:
aplay.c:1747:18: warning: '%02d' directive writing between 2 and 11 bytes
into a region of size 4 [-Wformat-overflow=]
1747 | sprintf(tmp, "%02d%%", maxperc[c]);
Signed-off-by Rosen Penev <[email protected]>
---
v2: Reworded
aplay/aplay.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
aplay/aplay.c +3 -1
@@ -54,6 +54,8 @@#include "formats.h" #include "version.h" +#define ABS (a) (a) < 0 ? -(a) : (a) +#ifdef SND_CHMAP_API_VERSION #define CONFIG_SUPPORT_CHMAP 1#endif
@@ -1741,7 +1743,7 @@ static void print_vu_meter_stereo(int *perc, int *maxperc) line[bar_length +6 +1 + p] ='+' ; else line[bar_length - p -1 ] ='+' ; -if (maxperc[c] >99 ) +if (ABS (maxperc[c]) >99 )sprintf (tmp,"MAX" );else sprintf (tmp,"%02d%%" , maxperc[c]);
Signature · 6 lines
2.23.0 _______________________________________________ Alsa-devel mailing list [email protected] https://mailman.alsa-project.org/mailman/listinfo/alsa-devel