Skip to contentSkip to conversation

arm64: dts: meson-sm1-sei610: gpio-keys: switch to IRQs

PATCH In review Kevin Hilman 3 participants 3 messages Nov 21, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: meson-sm1-sei610: gpio-keys: switch to IRQs

From: Kevin Hilman <[email protected]>

Switch the GPIO buttons/switches to use interrupts instead of polling. While at it, add the mic mute switch and the power button.

---
 .../boot/dts/amlogic/meson-sm1-sei610.dts     | 26 +++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-sm1-sei610.dts +24 -2
index 5bd07469766b..2c90f4713d0e 100644
@@ -46,25 +46,47 @@
 	};
 
 	gpio-keys {
-		compatible = "gpio-keys-polled";
-		poll-interval = <100>;
+		compatible = "gpio-keys";
 
 		key1 {
 			label = "A";
 			linux,code = <BTN_0>;
 			gpios = <&gpio GPIOH_6 GPIO_ACTIVE_LOW>;
+			interrupt-parent = <&gpio_intc>;
+			interrupts = <34 IRQ_TYPE_EDGE_BOTH>;
 		};
 
 		key2 {
 			label = "B";
 			linux,code = <BTN_1>;
 			gpios = <&gpio GPIOH_7 GPIO_ACTIVE_LOW>;
+			interrupt-parent = <&gpio_intc>;
+			interrupts = <35 IRQ_TYPE_EDGE_BOTH>;
 		};
 
 		key3 {
 			label = "C";
 			linux,code = <BTN_2>;
 			gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
+			interrupt-parent = <&gpio_intc>;
+			interrupts = <2 IRQ_TYPE_EDGE_BOTH>;
+		};
+
+		mic_mute {
+			label = "MicMute";
+			linux,code = <SW_MUTE_DEVICE>;
+			linux,input-type = <EV_SW>;
+			gpios = <&gpio_ao GPIOE_2 GPIO_ACTIVE_LOW>;
+			interrupt-parent = <&gpio_intc>;
+			interrupts = <99 IRQ_TYPE_EDGE_BOTH>;
+		};
+
+		power_key {
+			label = "PowerKey";
+			linux,code = <KEY_POWER>;
+			gpios = <&gpio_ao GPIOAO_3 GPIO_ACTIVE_LOW>;
+			interrupt-parent = <&gpio_intc>;
+			interrupts = <3 IRQ_TYPE_EDGE_BOTH>;
 		};
 	};
 
Signature · 7 lines
2.22.0


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Kevin Hilman

From: Kevin Hilman <[email protected]>

Switch the GPIO buttons/switches to use interrupts instead of polling. While at it, add the mic mute switch and the power button.

(I don't have the schematics of the board so I have to assume that the GPIOs are the right ones - based on that)

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer
#2 lore raw

Hi Martin,

Quoted 11 lines · Martin Blumenstingl
Quoted 7 lines · Kevin Hilman

From: Kevin Hilman <[email protected]>

Switch the GPIO buttons/switches to use interrupts instead of polling. While at it, add the mic mute switch and the power button.

(I don't have the schematics of the board so I have to assume that the GPIOs are the right ones - based on that)

I have the schematics, and I also forgot to mention that I tested this on the SEI610 board, and can watch the interrupt counts in /proc/interrupts increase for each of the buttons/switches.

Quoted 1 line

Thanks for the review,

Kevin

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel