x86/resctrl: Add task resctrl information display
Subsystems (4)
PATCH v4 1/1 x86/resctrl: Add task resctrl information display
Monitoring tools that want to find out which resctrl control and monitor groups a task belongs to must currently read the "tasks" file in every group until they locate the process ID.
Add an additional file /proc/{pid}/resctrl to provide this information.
The output is as followed according to Thomas's suggestion, for example:
1) ""
Resctrl is not available.
2) "/"
Task is part of the root group, task is not associated to any monitoring group.
3) "/mon_groups/mon0"
Task is part of the root group and monitoring group mon0.
4) "/group0"
Task is part of control group group0, task is not associated to any monitoring group.
5) "/group0/mon_groups/mon1"
Task is part of control group group0 and monitoring group mon1.
---
v2: Reduce indentation level in proc_resctrl_show()
according to Boris's suggestion.
Create the include/linux/resctrl.h header and declare proc_resctrl_show() in this file, so that other architectures would probably use it in the future. Different architectures should implement architectural specific proc_resctrl_show() accordingly.
v3: Return empty string if the resctrl filesystem has
not been mounted per Boris's suggestion. Rename the config from CPU_RESCTRL to PROC_CPU_RESCTRL to better represent its usage. Move PROC_CPU_RESCTRL from arch/Kconfig to fs/proc/Kconfig.
And let PROC_CPU_RESCTRL to be depended on PROC_FS.
v4: According to Thomas's suggestion, changed the output
from multiple lines to one single line.
--- arch/x86/Kconfig | 1 + arch/x86/kernel/cpu/resctrl/rdtgroup.c | 78 ++++++++++++++++++++++++++ fs/proc/Kconfig | 4 ++ fs/proc/base.c | 7 +++ include/linux/resctrl.h | 16 ++++++ 5 files changed, 106 insertions(+) create mode 100644 include/linux/resctrl.h
arch/x86/Kconfig +1 -0
@@ -455,6 +455,7 @@ config X86_CPU_RESCTRL bool "x86 CPU resource control support" depends on X86 && (CPU_SUP_INTEL || CPU_SUP_AMD) select KERNFS + select PROC_CPU_RESCTRL if PROC_FS help Enable x86 CPU resource control support.
arch/x86/kernel/cpu/resctrl/rdtgroup.c +78 -0
84 lines not on this page · raw message
fs/proc/Kconfig +4 -0
@@ -103,3 +103,7 @@ config PROC_CHILDREN config PROC_PID_ARCH_STATUS def_bool n depends on PROC_FS + +config PROC_CPU_RESCTRL + def_bool n + depends on PROC_FS
fs/proc/base.c +7 -0
@@ -94,6 +94,7 @@#include <linux/sched/debug.h> #include <linux/sched/stat.h> #include <linux/posix-timers.h> +#include <linux/resctrl.h> #include <trace/events/oom.h> #include "internal.h" #include "fd.h"
@@ -3060,6 +3061,9 @@ static const struct pid_entry tgid_base_stuff[] = {#endif #ifdef CONFIG_CGROUPS ONE("cgroup", S_IRUGO, proc_cgroup_show), +#endif +#ifdef CONFIG_PROC_CPU_RESCTRL +ONE ("resctrl" ,S_IRUGO , proc_resctrl_show), #endifONE ("oom_score" ,S_IRUGO , proc_oom_score), REG("oom_adj", S_IRUGO|S_IWUSR, proc_oom_adj_operations),
@@ -3460,6 +3464,9 @@ static const struct pid_entry tid_base_stuff[] = {#endif #ifdef CONFIG_CGROUPS ONE("cgroup", S_IRUGO, proc_cgroup_show), +#endif +#ifdef CONFIG_PROC_CPU_RESCTRL +ONE ("resctrl" ,S_IRUGO , proc_resctrl_show), #endifONE ("oom_score" ,S_IRUGO , proc_oom_score), REG("oom_adj", S_IRUGO|S_IWUSR, proc_oom_adj_operations),
include/linux/resctrl.h new file +16 -0
@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _RESCTRL_H +#define _RESCTRL_H + +#ifdef CONFIG_PROC_CPU_RESCTRL + +#include <linux/proc_fs.h> + +int proc_resctrl_show (struct seq_file *m, +struct pid_namespace *ns, +struct pid *pid, +struct task_struct *tsk); + +#endif + +#endif /* _RESCTRL_H */
Signature · 1 line
2.17.1
Quoted 12 lines · Chen Yu
Monitoring tools that want to find out which resctrl control and monitor groups a task belongs to must currently read the "tasks" file in every group until they locate the process ID.
Add an additional file
/proc/{pid}/resctrlto provide this information.arch/x86/kernel/cpu/resctrl/rdtgroup.c +1
-0+seq_printf (s,"/%s" , rdtg->kn->name);
arch/x86/kernel/cpu/resctrl/rdtgroup.c static int rdtgroup_tasks_show(struct kernfs_open_file *of, · line 791
Quoted 10 lines
arch/x86/kernel/cpu/resctrl/rdtgroup.c +10
-0+list_for_each_entry (crg, &rdtg->mon.crdtgrp_list, + mon.crdtgrp_list) { +if (tsk->rmid != crg->mon.rmid) +continue ; +seq_printf (s,"%smon_groups/%s" , + rdtg == &rdtgroup_default ?"" :"/" , + crg->kn->name); +break ; + } +seq_puts (s,"\n" );
This should be seq_putc().
include/linux/resctrl.h line 7
Quoted 10 lines
include/linux/resctrl.h new file +7
-0@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _RESCTRL_H +#define _RESCTRL_H + +#ifdef CONFIG_PROC_CPU_RESCTRL + +#include <linux/proc_fs.h>
Forward declaring stuff should be more than enough.
Quoted 8 lines
include/linux/resctrl.h new file +8
-0+int proc_resctrl_show (struct seq_file *m, +struct pid_namespace *ns, +struct pid *pid, +struct task_struct *tsk); + +#endif + +#endif /* _RESCTRL_H */
Hi Alexey,
thanks for looking at this patch.
Quoted 12 lines · Alexey Dobriyan
Quoted 10 lines · Chen Yu
Monitoring tools that want to find out which resctrl control and monitor groups a task belongs to must currently read the "tasks" file in every group until they locate the process ID.
Add an additional file
/proc/{pid}/resctrlto provide this information.arch/x86/kernel/cpu/resctrl/rdtgroup.c +0
-0
Quoted 15 lines
arch/x86/kernel/cpu/resctrl/rdtgroup.c static int rdtgroup_tasks_show(struct kernfs_open_file *of, · line 791
Quoted 11 lines
arch/x86/kernel/cpu/resctrl/rdtgroup.c +11
-0+seq_printf (s,"/%s" , rdtg->kn->name); +list_for_each_entry (crg, &rdtg->mon.crdtgrp_list, + mon.crdtgrp_list) { +if (tsk->rmid != crg->mon.rmid) +continue ; +seq_printf (s,"%smon_groups/%s" , + rdtg == &rdtgroup_default ?"" :"/" , + crg->kn->name); +break ; + } +seq_puts (s,"\n" );This should be
seq_putc().
Okay, changed in next version.
Quoted 4 lines
Quoted 4 lines
include/linux/resctrl.h new file +1
-0@@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0 */
Quoted 9 lines
include/linux/resctrl.h line 7
Quoted 6 lines
include/linux/resctrl.h new file +6
-0+#ifndef _RESCTRL_H +#define _RESCTRL_H + +#ifdef CONFIG_PROC_CPU_RESCTRL + +#include <linux/proc_fs.h> Forward declaring stuff should be more than enough.
Okay, deleted in next version.
Then after removing this header, the .c files(besides proc/fs/base.c) who include resctrl.h should be responsible to import corresondling headers themselves.
Thanks,
Chenyu
Quoted 8 lines
Quoted 8 lines
include/linux/resctrl.h new file +8
-0+int proc_resctrl_show (struct seq_file *m, +struct pid_namespace *ns, +struct pid *pid, +struct task_struct *tsk); + +#endif + +#endif /* _RESCTRL_H */