Skip to contentSkip to conversation

Input: snvs_pwrkey - remove gratuitous NULL initializers

PATCH In review Dmitry Torokhov 2 participants 2 messages Nov 25, 2019 – Nov 26, 2019

Subsystems (2)
lore
Share & tools
lore

Dmitry Torokhov

author maintainer
#0 lore raw

PATCH 1/1 Input: snvs_pwrkey - remove gratuitous NULL initializers

Gratuitous NULL initializers rarely help and often prevent compiler from warning about using uninitialized variable. Let's remove them.

---
 drivers/input/keyboard/snvs_pwrkey.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/input/keyboard/snvs_pwrkey.c +2 -2
index fd6f244f403d..2f5e3ab5ed63 100644
@@ -108,8 +108,8 @@ static void imx_snvs_pwrkey_act(void *pdata)
 
 static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
 {
-	struct pwrkey_drv_data *pdata = NULL;
-	struct input_dev *input = NULL;
+	struct pwrkey_drv_data *pdata;
+	struct input_dev *input;
 	struct device_node *np;
 	int error;
 	u32 vid;
Signature · 5 lines
2.24.0.432.g9d3f5f5b63-goog


-- 
Dmitry
Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines

Subject: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers

Gratuitous NULL initializers rarely help and often prevent compiler from warning about using uninitialized variable. Let's remove them.

Quoted 25 lines
---
 drivers/input/keyboard/snvs_pwrkey.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/input/keyboard/snvs_pwrkey.c +2 -3
index fd6f244f403d..2f5e3ab5ed63 100644
@@ -108,8 +108,8 @@ static void imx_snvs_pwrkey_act(void *pdata)
 
 static int imx_snvs_pwrkey_probe(struct platform_device *pdev)  {
-	struct pwrkey_drv_data *pdata = NULL;
-	struct input_dev *input = NULL;
+	struct pwrkey_drv_data *pdata;
+	struct input_dev *input;
 	struct device_node *np;
 	int error;
 	u32 vid;
--

2.24.0.432.g9d3f5f5b63-goog

--
Dmitry