Skip to contentSkip to conversation

drm: radeon: replace 0 with NULL

PATCH Applied Jules Irenge 4 participants 5 messages Nov 26, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: radeon: replace 0 with NULL

Replace 0 with NULL to fix sparse tool warning
warning: Using plain integer as NULL pointer

---
 drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_audio.c +1 -1
index b9aea5776d3d..2269cfced788 100644
@@ -288,7 +288,7 @@ static void radeon_audio_interface_init(struct radeon_device *rdev)
 	} else {
 		rdev->audio.funcs = &r600_funcs;
 		rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
-		rdev->audio.dp_funcs = 0;
+		rdev->audio.dp_funcs = NULL;
 	}
 }
 
Signature · 1 line
2.23.0
maintainer Acked-by on v1 1/1
#1 lore raw

Am 26.11.19 um 01:35 schrieb Jules Irenge:

Quoted 4 lines

Replace 0 with NULL to fix sparse tool warning
warning: Using plain integer as NULL pointer

Quoted 9 lines
---
  drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_audio.c +0 -0
index b9aea5776d3d..2269cfced788 100644

drivers/gpu/drm/radeon/radeon_audio.c static void radeon_audio_interface_init(struct radeon_device *rdev) · line 294

Quoted 8 lines
drivers/gpu/drm/radeon/radeon_audio.c +1 -1
@@ -288,7 +288,7 @@ static void radeon_audio_interface_init(struct radeon_device *rdev)
  	} else {
  		rdev->audio.funcs = &r600_funcs;
  		rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
-		rdev->audio.dp_funcs = 0;
+		rdev->audio.dp_funcs = NULL;
  	}
  }
 

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by
#2 lore raw
Quoted 13 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Christian König
Sent: 2019/November/26, Tuesday 5:10 AM
To: Jules Irenge <[email protected]>; Deucher, Alexander <[email protected]>
Cc: Zhou, David(ChunMing) <[email protected]>; [email protected]; [email protected]; [email protected]; dri- [email protected]; [email protected]
Subject: Re: [PATCH] drm: radeon: replace 0 with NULL

Quoted 7 lines

Am 26.11.19 um 01:35 schrieb Jules Irenge:

Quoted 4 lines

Replace 0 with NULL to fix sparse tool warning
warning: Using plain integer as NULL pointer

Quoted 12 lines

Review

Quoted 6 lines
---
  drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/radeon/radeon_audio.c

drivers/gpu/drm/radeon/radeon_audio.c static void radeon_audio_interface_init(struct

Quoted 4 lines

index b9aea5776d3d..2269cfced788 100644

drivers/gpu/drm/radeon/radeon_audio.c +0 -0
@@ -288,7 +288,7 @@ static void radeon_audio_interface_init(struct

radeon_device *rdev)

Quoted 12 lines

drivers/gpu/drm/radeon/radeon_audio.c static void radeon_audio_interface_init(struct radeon_device *rdev) · line 294

Quoted 8 lines
drivers/gpu/drm/radeon/radeon_audio.c +1 -1
  	} else {
  		rdev->audio.funcs = &r600_funcs;
  		rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
-		rdev->audio.dp_funcs = 0;
+		rdev->audio.dp_funcs = NULL;
  	}
  }
 

_______________________________________________
amd-gfx mailing list
[email protected]

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by
#3 lore raw
In reply to Christian König
Quoted 13 lines

-----Original Message-----
From: amd-gfx <[email protected]> On Behalf Of Christian König
Sent: 2019/November/26, Tuesday 5:10 AM
To: Jules Irenge <[email protected]>; Deucher, Alexander <[email protected]>
Cc: Zhou, David(ChunMing) <[email protected]>; [email protected]; [email protected]; [email protected]; dri- [email protected]; [email protected]
Subject: Re: [PATCH] drm: radeon: replace 0 with NULL

Quoted 7 lines

Am 26.11.19 um 01:35 schrieb Jules Irenge:

Quoted 4 lines

Replace 0 with NULL to fix sparse tool warning
warning: Using plain integer as NULL pointer

Quoted 22 lines

Review

Quoted 6 lines
---
  drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/radeon/radeon_audio.c

drivers/gpu/drm/radeon/radeon_audio.c static void radeon_audio_interface_init(struct

Quoted 4 lines

index b9aea5776d3d..2269cfced788 100644

drivers/gpu/drm/radeon/radeon_audio.c +0 -0
@@ -288,7 +288,7 @@ static void radeon_audio_interface_init(struct

radeon_device *rdev)

drivers/gpu/drm/radeon/radeon_audio.c static void radeon_audio_interface_init(struct radeon_device *rdev) · line 294

Quoted 8 lines
drivers/gpu/drm/radeon/radeon_audio.c +1 -1
  	} else {
  		rdev->audio.funcs = &r600_funcs;
  		rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
-		rdev->audio.dp_funcs = 0;
+		rdev->audio.dp_funcs = NULL;
  	}
  }
 

_______________________________________________

Quoted 8 lines

amd-gfx mailing list
[email protected]
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
freedesktop.org%2Fmailman%2Flistinfo%2Famd- gfx&amp;data=02%7C01%7Czhan.liu%40amd.com%7C35832a2894894c44817d 08d77258c9ea%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C1%7C63710 3597981850872&amp;sdata=FdouIs7Prawx3UhK4z8AEgV0nYJJcyrGNp56G0w hNZU%3D&amp;reserved=0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Applied
#4 lore raw
In reply to Jules Irenge

Applied. thanks!

Alex

Quoted 29 lines · Jules Irenge

Replace 0 with NULL to fix sparse tool warning
warning: Using plain integer as NULL pointer

---
 drivers/gpu/drm/radeon/radeon_audio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_audio.c +1 -2
index b9aea5776d3d..2269cfced788 100644
@@ -288,7 +288,7 @@ static void radeon_audio_interface_init(struct radeon_device *rdev)
        } else {
                rdev->audio.funcs = &r600_funcs;
                rdev->audio.hdmi_funcs = &r600_hdmi_funcs;
-               rdev->audio.dp_funcs = 0;
+               rdev->audio.dp_funcs = NULL;
        }
 }
 
--

2.23.0

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel