insane: fix GitHub /archive/ test
PATCH 1/1 insane: fix GitHub /archive/ test
This test was failing to split the URL list to individual URLs, so if SRC_URI is something like this then the test incorrectly triggers:
SRC_URI = "git://github.com/foo http://example.com/archive/foo"
Fix this by splitting the SRC_URI list and iterating through the URIs one at time.
[ YOCTO #13660 ]
Signed-off-by Ross Burton <[email protected]>
--- meta/classes/insane.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
meta/classes/insane.bbclass +3 -3
@@ -893,9 +893,9 @@ def package_qa_check_src_uri(pn, d, messages): if "${PN}" in d.getVar("SRC_URI", False): package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d) - pn = d.getVar("SRC_URI") - if re.search(r"github\.com/.+/.+/archive/.+", pn): - package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) + for url in d.getVar("SRC_URI").split(): + if re.search(r"github\.com/.+/.+/archive/.+", url): + package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) # The PACKAGE FUNC to scan each package
Signature · 1 line
2.20.1
Quoted 9 lines · Ross Burton
This test was failing to split the URL list to individual URLs, so if
SRC_URIis something like this then the test incorrectly triggers:
SRC_URI= "git://github.com/foohttp://example.com/archive/foo"Fix this by splitting the
SRC_URIlist and iterating through the URIs one at time.[ YOCTO #13660 ]
Test-by Armin Kuster <[email protected]>
Quoted 23 lines
Signed-off-by Ross Burton <[email protected]>--- meta/classes/insane.bbclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)meta/classes/insane.bbclass +3
-3@@ -893,9 +893,9 @@ def package_qa_check_src_uri(pn, d, messages): if "${PN}" in d.getVar("SRC_URI", False): package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses PN not BPN" % pn, d) - pn = d.getVar("SRC_URI") - if re.search(r"github\.com/.+/.+/archive/.+", pn): - package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) + for url in d.getVar("SRC_URI").split(): + if re.search(r"github\.com/.+/.+/archive/.+", url): + package_qa_handle_error("src-uri-bad", "%s: SRC_URI uses unstable GitHub archives" % pn, d) # The PACKAGE FUNC to scan each package