xhci: enable XHCI_TRUST_TX_LENGTH quirk for ThunderX2 builtin hosts
Subsystems (2)
PATCH 1/1 xhci: enable XHCI_TRUST_TX_LENGTH quirk for ThunderX2 builtin hosts
When using a USB webcam on a ThunderX2 workstation, the kernel log gets flooded with messages like
xhci_hcd 0000:00:0f.0:
WARN Successful completion on short TX for slot 7 ep 2: needs XHCI_TRUST_TX_LENGTH quirk?
Enabling the quirk manually makes the issue go away, so let's enable it unconditionally for this hardware.
--- drivers/usb/host/xhci-pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/usb/host/xhci-pci.c +2 -1
@@ -256,7 +256,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)if ((pdev->vendor ==PCI_VENDOR_ID_BROADCOM || pdev->vendor ==PCI_VENDOR_ID_CAVIUM ) && pdev->device ==0x9026 ) - xhci->quirks |=XHCI_RESET_PLL_ON_DISCONNECT ; + xhci->quirks |=XHCI_RESET_PLL_ON_DISCONNECT | +XHCI_TRUST_TX_LENGTH ;if (xhci->quirks &XHCI_RESET_ON_RESUME ) xhci_dbg_trace(xhci, trace_xhci_dbg_quirks,
Signature · 1 line
2.20.1
Quoted 9 lines · Ard Biesheuvel
When using a USB webcam on a ThunderX2 workstation, the kernel log gets flooded with messages like
xhci_hcd0000:00:0f.0:
WARN Successful completion on short TX for slot 7 ep 2: needsXHCI_TRUST_TX_LENGTHquirk?Enabling the quirk manually makes the issue go away, so let's enable it unconditionally for this hardware.
This issue starts to be common for many vendors, many report successful completions after a initial short transfer in a TD
Does the patch below help in your case? It worked for a Renesas controller with similar issues. It's a more generic solution.
drivers/usb/host/xhci-ring.c +2 -1
@@ -2381,7 +2381,8 @@ static int handle_tx_event(struct xhci_hcd *xhci,case COMP_SUCCESS :if (EVENT_TRB_LEN (le32_to_cpu (event->transfer_len)) ==0 )break ; -if (xhci->quirks &XHCI_TRUST_TX_LENGTH ) +if (xhci->quirks &XHCI_TRUST_TX_LENGTH || + ep_ring->last_td_was_short) trb_comp_code =COMP_SHORT_PACKET ;else xhci_warn_ratelimited(xhci,
Ard Biesheuvel
Tested-byQuoted 23 lines · Mathias Nyman
Quoted 9 lines · Ard Biesheuvel
When using a USB webcam on a ThunderX2 workstation, the kernel log gets flooded with messages like
xhci_hcd0000:00:0f.0:
WARN Successful completion on short TX for slot 7 ep 2: needsXHCI_TRUST_TX_LENGTHquirk?Enabling the quirk manually makes the issue go away, so let's enable it unconditionally for this hardware.
This issue starts to be common for many vendors, many report successful completions after a initial short transfer in a TD
Does the patch below help in your case? It worked for a Renesas controller with similar issues. It's a more generic solution.
drivers/usb/host/xhci-ring.c +0
-0
drivers/usb/host/xhci-ring.c static int handle_tx_event(struct xhci_hcd *xhci, · line 2388
Quoted 9 lines
drivers/usb/host/xhci-ring.c +2
-1@@ -2381,7 +2381,8 @@ static int handle_tx_event(struct xhci_hcd *xhci,case COMP_SUCCESS :if (EVENT_TRB_LEN (le32_to_cpu (event->transfer_len)) ==0 )break ; -if (xhci->quirks &XHCI_TRUST_TX_LENGTH ) +if (xhci->quirks &XHCI_TRUST_TX_LENGTH || + ep_ring->last_td_was_short) trb_comp_code =COMP_SHORT_PACKET ;else xhci_warn_ratelimited(xhci,
Yes, that works too. If you roll that into a patch
and please consider cc'ing stable as well.
Quoted 37 lines · Ard Biesheuvel
Quoted 23 lines · Mathias Nyman
Quoted 9 lines · Ard Biesheuvel
When using a USB webcam on a ThunderX2 workstation, the kernel log gets flooded with messages like
xhci_hcd0000:00:0f.0:
WARN Successful completion on short TX for slot 7 ep 2: needsXHCI_TRUST_TX_LENGTHquirk?Enabling the quirk manually makes the issue go away, so let's enable it unconditionally for this hardware.
This issue starts to be common for many vendors, many report successful completions after a initial short transfer in a TD
Does the patch below help in your case? It worked for a Renesas controller with similar issues. It's a more generic solution.
drivers/usb/host/xhci-ring.c +0
-0drivers/usb/host/xhci-ring.c static int handle_tx_event(struct xhci_hcd *xhci, · line 2388
Quoted 9 lines
drivers/usb/host/xhci-ring.c +2
-1@@ -2381,7 +2381,8 @@ static int handle_tx_event(struct xhci_hcd *xhci,case COMP_SUCCESS :if (EVENT_TRB_LEN (le32_to_cpu (event->transfer_len)) ==0 )break ; -if (xhci->quirks &XHCI_TRUST_TX_LENGTH ) +if (xhci->quirks &XHCI_TRUST_TX_LENGTH || + ep_ring->last_td_was_short) trb_comp_code =COMP_SHORT_PACKET ;else xhci_warn_ratelimited(xhci,Yes, that works too. If you roll that into a patch
Quoted 4 lines
Tested-by Ard Biesheuvel <[email protected]>and please consider cc'ing stable as well.
Will do, thanks
-Mathias