Skip to contentSkip to conversation

platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk_systems DMI table

PATCH In review Michael Haener 2 participants 3 messages Nov 29, 2019 – Nov 30, 2019 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk_systems DMI table

The CONNECT X300 uses the PMC clock for on-board components and gets stuck during boot if the clock is disabled. Therefore, add this device to the critical systems list.
Tested on CONNECT X300.

Fixes 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
---
 drivers/platform/x86/pmc_atom.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/platform/x86/pmc_atom.c +8 -0
index 07d1b911e72f..57f06ca114a6 100644
@@ -429,6 +429,14 @@ static const struct dmi_system_id critclk_systems[] = {
 			DMI_MATCH(DMI_PRODUCT_VERSION, "6AV7882-0"),
 		},
 	},
+	{
+		.ident = "CONNECT X300",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "A5E45074588")
+		},
+	},
+
 	{ /*sentinel*/ }
 };
 
Signature · 1 line
2.11.0
#1 lore raw
Quoted 5 lines · Michael Haener

The CONNECT X300 uses the PMC clock for on-board components and gets stuck during boot if the clock is disabled. Therefore, add this device to the critical systems list.
Tested on CONNECT X300.

Thank you for your patch!
Can you be more specific about the clock (which one? For example plt2) and if possible type of hardware IP which is connected to it (for example, Realtek Ethernet)?

Quoted 28 lines
Fixes 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
---
 drivers/platform/x86/pmc_atom.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/platform/x86/pmc_atom.c +8 -1
index 07d1b911e72f..57f06ca114a6 100644
@@ -429,6 +429,14 @@ static const struct dmi_system_id critclk_systems[] = {
                        DMI_MATCH(DMI_PRODUCT_VERSION, "6AV7882-0"),
                },
        },
+       {
+               .ident = "CONNECT X300",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
+                       DMI_MATCH(DMI_PRODUCT_VERSION, "A5E45074588")
+               },
+       },
+
        { /*sentinel*/ }
 };
 
--

2.11.0

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 19 lines

From: Andy Shevchenko <[email protected]>
Sent: Freitag, 29. November 2019 11:16
To: Häner, Michael (SI BP R&D ZG FW CCP) <[email protected]>
Cc: Andy Shevchenko <[email protected]>; Darren Hart <[email protected]>; Platform Driver <platform-driver- [email protected]>; Linux Kernel Mailing List <linux- [email protected]>
Subject: Re: [PATCH] platform/x86: pmc_atom: Add Siemens CONNECT X300 to critclk_systems DMI table

Quoted 5 lines · Michael Haener

The CONNECT X300 uses the PMC clock for on-board components and gets stuck during boot if the clock is disabled. Therefore, add this device to the critical systems list.
Tested on CONNECT X300.

Quoted 4 lines

Thank you for your patch!
Can you be more specific about the clock (which one? For example plt2) and if possible type of hardware IP which is connected to it (for example, Realtek Ethernet)?

I'm sorry, I don't have more detailed information. I only identified the bug by git bisect.

Quoted 28 lines

Review

Quoted 8 lines
Fixes 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
---
 drivers/platform/x86/pmc_atom.c | 8 ++++++++
 1 file changed, 8 insertions(+)
(quoted diff) +0 -0

b/drivers/platform/x86/pmc_atom.c

drivers/platform/x86/pmc_atom.c static const struct dmi_system_id critclk_systems[]

Quoted 4 lines

index 07d1b911e72f..57f06ca114a6 100644

drivers/platform/x86/pmc_atom.c +0 -0
@@ -429,6 +429,14 @@ static const struct dmi_system_id critclk_systems[]

= {

Quoted 14 lines
drivers/platform/x86/pmc_atom.c +8 -0
                        DMI_MATCH(DMI_PRODUCT_VERSION, "6AV7882-0"),
                },
        },
+       {
+               .ident = "CONNECT X300",
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "SIEMENS AG"),
+                       DMI_MATCH(DMI_PRODUCT_VERSION, "A5E45074588")
+               },
+       },
+
        { /*sentinel*/ }
 };
 
Quoted 8 lines
Quoted 3 lines

--
2.11.0

--
With Best Regards,
Andy Shevchenko

With Best Regards,
Michael Haener