Skip to contentSkip to conversation

ci: Use libcap-ng

PATCH In review Dr. David Alan Gilbert (git) 5 participants 7 messages Nov 29, 2019 – Dec 2, 2019

lore
Share & tools
lore
Acked-by on v1 1/1
#1 lore raw
In reply to Dr. David Alan Gilbert (git)
Quoted 17 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using it. This also means we'll be testing the scsi pr manager and the bridge helper.

---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
.gitlab-ci.yml +0 -0
index be57c6a454..62a9609798 100644

.gitlab-ci.yml build-user: · line 65

Quoted 8 lines
.gitlab-ci.yml +1 -1
@@ -59,7 +59,7 @@ build-user:
 
 build-clang:
  script:
- - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
+ - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-ng-dev
       xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
  - ./configure --cc=clang --cxx=clang++ --enable-werror
       --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
#0 lore raw

PATCH 1/1 ci: Use libcap-ng

From: "Dr. David Alan Gilbert" <[email protected]>

We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using it. This also means we'll be testing the scsi pr manager and the bridge helper.

---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
.gitlab-ci.yml +1 -1
index be57c6a454..62a9609798 100644
@@ -59,7 +59,7 @@ build-user:
 
 build-clang:
  script:
- - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
+ - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-ng-dev
       xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
  - ./configure --cc=clang --cxx=clang++ --enable-werror
       --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
Signature · 1 line
2.23.0
Reviewed-by on v1 1/1
#2 lore raw
Quoted 17 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using it. This also means we'll be testing the scsi pr manager and the bridge helper.

---
 .gitlab-ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
.gitlab-ci.yml +0 -0
index be57c6a454..62a9609798 100644

.gitlab-ci.yml build-user: · line 65

Quoted 8 lines
.gitlab-ci.yml +1 -1
@@ -59,7 +59,7 @@ build-user:
 
 build-clang:
  script:
- - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
+ - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-ng-dev
       xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
  - ./configure --cc=clang --cxx=clang++ --enable-werror
       --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu

Regards,
Daniel

Signature · 3 lines
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|
Reviewed-by on v1 1/1
#3 lore raw
In reply to Dr. David Alan Gilbert (git)
Quoted 4 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using

It is not obvious you are referring to "virtfs-proxy-helper: switch from libcap to libcap-ng" he recently posted.

Since Greg is going to take Paolo's patch, I'd suggest he also takes this one, so he can update the commit description with either "the previous patch" or the commit sha1.

Quoted 2 lines

it. This also means we'll be testing the scsi pr manager and the bridge helper.

This is good news.

Quoted 19 lines
---
  .gitlab-ci.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
.gitlab-ci.yml +1 -1
index be57c6a454..62a9609798 100644
@@ -59,7 +59,7 @@ build-user:
 
  build-clang:
   script:
- - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
+ - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-ng-dev
        xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
   - ./configure --cc=clang --cxx=clang++ --enable-werror
        --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
Reviewed-by on v1 1/1
#4 lore raw
In reply to Dr. David Alan Gilbert (git)
Quoted 4 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using

It is not obvious you are referring to "virtfs-proxy-helper: switch from libcap to libcap-ng" he recently posted.

Since Greg is going to take Paolo's patch, I'd suggest he also takes this one, so he can update the commit description with either "the previous patch" or the commit sha1.

Quoted 2 lines

it. This also means we'll be testing the scsi pr manager and the bridge helper.

This is good news.

Quoted 19 lines
---
  .gitlab-ci.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
.gitlab-ci.yml +1 -1
index be57c6a454..62a9609798 100644
@@ -59,7 +59,7 @@ build-user:
 
  build-clang:
   script:
- - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
+ - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-ng-dev
        xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
   - ./configure --cc=clang --cxx=clang++ --enable-werror
        --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
#5 lore raw
Quoted 6 lines · On Fri, 29 Nov 2019 16:51:29 +0100 Philippe Mathieu-Daudé <[email protected]>…
Quoted 4 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using

Quoted 7 lines

It is not obvious you are referring to "virtfs-proxy-helper: switch from libcap to libcap-ng" he recently posted.

Since Greg is going to take Paolo's patch, I'd suggest he also takes this one, so he can update the commit description with either "the previous patch" or the commit sha1.

I'm okay to take this one and to adapt the changelog if I get an ack from Thomas.

Quoted 27 lines
Quoted 2 lines

it. This also means we'll be testing the scsi pr manager and the bridge helper.

This is good news.

Quoted 19 lines
---
  .gitlab-ci.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
.gitlab-ci.yml +1 -1
index be57c6a454..62a9609798 100644
@@ -59,7 +59,7 @@ build-user:
 
  build-clang:
   script:
- - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-dev
+ - apt-get install -y -qq clang libsdl2-dev libattr1-dev libcap-ng-dev
        xfslibs-dev libiscsi-dev libnfs-dev libseccomp-dev gnutls-dev librbd-dev
   - ./configure --cc=clang --cxx=clang++ --enable-werror
        --target-list="alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu
#6 lore raw
Quoted 12 lines · Greg Kurz
Quoted 9 lines · On Fri, 29 Nov 2019 16:51:29 +0100 Philippe Mathieu-Daudé <[email protected]>…
Quoted 4 lines · Dr. David Alan Gilbert (git)

From: "Dr. David Alan Gilbert" <[email protected]>

We currently enable libcap-dev in build-clang to pick up the 9p proxy helper. Paolo's patch changes that to use libcap-ng, so switch to using

It is not obvious you are referring to "virtfs-proxy-helper: switch from libcap to libcap-ng" he recently posted.

Quoted 7 lines
Quoted 4 lines

Since Greg is going to take Paolo's patch, I'd suggest he also takes this one, so he can update the commit description with either "the previous patch" or the commit sha1.

I'm okay to take this one and to adapt the changelog if I get an ack from Thomas.

Feel free to recycle my Ack from here:

https://lists.gnu.org/archive/html/qemu-devel/2019-11/msg05178.html

Cheers,
Thomas