Skip to contentSkip to conversation

add support for videostrong KII Pro

PATCH In review Mohammad Rasim 3 participants 9 messages Nov 30, 2019 – Dec 9, 2019

Subsystems (2)
lore
Share & tools
lore
#1 lore raw

PATCH v4 1/3 dt-bindings: Add vendor prefix for Videostrong

In reply to Mohammad Rasim

Videostrong Technology Co., Ltd., A manufacturer of Android Players & STB (Android with DVB Hybrid box & DVB-T2/S2/C/ISDB-T/DTMB-TH/ATSC) as well as HD media players.

---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index fd6fa07c45b8..a6c83d70aa74 100644
@@ -1008,6 +1008,8 @@ patternProperties:
     description: Variscite Ltd.
   "^via,.*":
     description: VIA Technologies, Inc.
+  "^videostrong,.*":
+    description: Videostrong Technology Co., Ltd.
   "^virtio,.*":
     description: Virtual I/O Device Specification, developed by the OASIS consortium
   "^vishay,.*":

--
2.24.0

#0 lore raw

v4 cover add support for videostrong KII Pro

This patchset adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design.

Device specifications:
- SOC: Amlogic S905
- RAM: 2GB DDR3
- Storage: 16GB
- Connectivity:
- 10/100M Ethernet (IC Plus IP101GR)
- 802.11 b/g/n/ac Wi-Fi (Ampak AP6335 BT/WIFI combo)
- Bluetooth 4.0 (Ampak AP6335 BT/WIFI combo)
- Video out: HDMI 2.0 up to 4K @ 60Hz, and 3.5mm AV (composite video) jack
- Audio out: HDMI, AV (stereo audio) and optical S/PDIF
- Tuner: AVL6862 DVB-C/T/T2 + DVB-S/S2 demod and Rafael Micro R848 tuner
- Ports:
- x1 micro SD card slot up to 32GB
- 4x USB 2.0 host ports
- Misc:
- Power button and LED, IR receiver

Changes since RFC v1:
- add commit description to the cover letter
- update bluetooth bindings
- use lowercase name for the dts filename,vendor prefix and compatible
- add copyrights to the new files
- include "meson-gxbb-p20x.dtsi" instead of "meson-gxbb-p201.dts"

Changes since RFC v2:
- Fix styling issues

Changes since v1:
- add leds node to the device tree
- add gpio-keys-polled node to the device tree

Changes since v2:
- use phy-handle to describe the phy
- The blutooth compatible is now merged,change the commit message accordingly

Changes since v3:
- fix typo in the binding commit message
- add device bindings to arm/amlogic.yaml
- remove deprecated "label" property from the gpio-leds node
- rename button@0 to button-reset
- add the device specs to the dts commit message

Mohammad Rasim (3):
dt-bindings: Add vendor prefix for Videostrong
dt-bindings: arm: amlogic: add Videostrong KII Pro bindings
arm64: dts: meson-gxbb: add support for Videostrong KII Pro

 .../devicetree/bindings/arm/amlogic.yaml      |  1 +
 .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../boot/dts/amlogic/meson-gxbb-kii-pro.dts   | 78 +++++++++++++++++++
 4 files changed, 82 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts

--
2.24.0

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic

#2 lore raw

PATCH v4 2/3 dt-bindings: arm: amlogic: add Videostrong KII Pro bindings

Add the compatible for the Amlogic gxbb(s905) based kii pro

---
 Documentation/devicetree/bindings/arm/amlogic.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/amlogic.yaml +1 -0
index 99015cef8bb1..8c97b8867e2f 100644
@@ -59,6 +59,7 @@ properties:
               - friendlyarm,nanopi-k2
               - hardkernel,odroid-c2
               - nexbox,a95x
+              - videostrong,kii-pro
               - wetek,hub
               - wetek,play2
           - const: amlogic,meson-gxbb

--
2.24.0

#4 lore raw

PATCH v4 3/3 arm64: dts: meson-gxbb: add support for Videostrong KII Pro

In reply to Mohammad Rasim

This patch adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design

Device specifications:
- SOC: Amlogic S905
- RAM: 2GB DDR3
- Storage: 16GB
- Connectivity:
- 10/100M Ethernet (IC Plus IP101GR)
- 802.11 b/g/n/ac Wi-Fi (Ampak AP6335 BT/WIFI combo)
- Bluetooth 4.0 (Ampak AP6335 BT/WIFI combo)
- Video out: HDMI 2.0 up to 4K @ 60Hz, and 3.5mm AV (composite video) jack
- Audio out: HDMI, AV (stereo audio) and optical S/PDIF
- Tuner: AVL6862 DVB-C/T/T2 + DVB-S/S2 demod and Rafael Micro R848 tuner
- Ports:
- x1 micro SD card slot up to 32GB
- 4x USB 2.0 host ports
- Misc:
- Power button and LED, IR receiver

---
 arch/arm64/boot/dts/amlogic/Makefile          |  1 +
 .../boot/dts/amlogic/meson-gxbb-kii-pro.dts   | 78 +++++++++++++++++++
 2 files changed, 79 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts
arch/arm64/boot/dts/amlogic/Makefile +1 -0
index 84afecba9ec0..a795a170dcab 100644
@@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +78 -0

78 lines not on this page · raw message

--
2.24.0

#5 lore raw

Re: [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro

In reply to Mohammad Rasim

[...]

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 23

Quoted 7 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +7 -0
+       leds {
+               compatible = "gpio-leds";
+               status {
+                       gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
+                       default-state = "off";
+                       color = <LED_COLOR_ID_RED>;
+                       function = LED_FUNCTION_STATUS;

why is LED_FUNCTION_STATUS not enclosed in <> like color above?

Martin

#6 lore raw

Re: [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro

Quoted 10 lines · Martin Blumenstingl

[...]

arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts line 23

Quoted 7 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +7 -0
+       leds {
+               compatible = "gpio-leds";
+               status {
+                       gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
+                       default-state = "off";
+                       color = <LED_COLOR_ID_RED>;
+                       function = LED_FUNCTION_STATUS;

why is LED_FUNCTION_STATUS not enclosed in <> like color above?

Well, the examples in the documentation enclose the color and don't enclose function
https://github.com/torvalds/linux/blob/596cf45cbf6e4fa7bcb0df33e373a7d062b644b5/Documentation/devicetree/bindings/leds/common.txt#L140

Regards

Quoted 2 lines

Martin

#7 lore raw

Re: [PATCH v4 3/3] arm64: dts: meson-gxbb: add support for Videostrong KII Pro

Quoted 10 lines · Mohammad Rasim
Quoted 8 lines · Martin Blumenstingl

[...]

Quoted 7 lines
arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts new file +7 -0
+       leds {
+               compatible = "gpio-leds";
+               status {
+                       gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>;
+                       default-state = "off";
+                       color = <LED_COLOR_ID_RED>;
+                       function = LED_FUNCTION_STATUS;
Quoted 5 lines
Quoted 2 lines

why is LED_FUNCTION_STATUS not enclosed in <> like color above?

Well, the examples in the documentation enclose the color and don't enclose function
https://github.com/torvalds/linux/blob/596cf45cbf6e4fa7bcb0df33e373a7d062b644b5/Documentation/devicetree/bindings/leds/common.txt#L140

sorry for the noise, only now I realize that the LED_FUNCTION_*s are string definitions and not numeric values
in this case all is fine

I learnt something new today ;)

Martin

maintainer
#8 lore raw
In reply to Mohammad Rasim

Hi Mohammad,

Quoted 19 lines · Mohammad Rasim

This patchset adds support for the Videostrong KII Pro tv box which is based on the gxbb-p201 reference design.

Device specifications:
- SOC: Amlogic S905
- RAM: 2GB DDR3
- Storage: 16GB
- Connectivity:
- 10/100M Ethernet (IC Plus IP101GR)
- 802.11 b/g/n/ac Wi-Fi (Ampak AP6335 BT/WIFI combo)
- Bluetooth 4.0 (Ampak AP6335 BT/WIFI combo)
- Video out: HDMI 2.0 up to 4K @ 60Hz, and 3.5mm AV (composite video) jack
- Audio out: HDMI, AV (stereo audio) and optical S/PDIF
- Tuner: AVL6862 DVB-C/T/T2 + DVB-S/S2 demod and Rafael Micro R848 tuner
- Ports:
- x1 micro SD card slot up to 32GB
- 4x USB 2.0 host ports
- Misc:
- Power button and LED, IR receiver

Series queued for v5.6.

Thanks for adding a new board upstream!

Kevin

_______________________________________________
linux-amlogic mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-amlogic