fix the SPDX syntax and bash interprester pointer
PATCH 2/2 fix the SPDX syntax and bash interprester pointer
SPDX syntax was complining by checkpatch fixed it,added space before it. And add bash interpreter to find by the env .
--- scripts/kernel_modules_info.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
scripts/kernel_modules_info.sh +2 -2
@@ -1,5 +1,5 @@ -#!/bin/bash - -#SPDX-License-Identifier: GPL-2.0 +#!/usr/bin/env bash +# SPDX-License-Identifier: GPL-2.0 #=============================================================================== # # FILE: kernel_modules_info.sh
Signature · 1 line
2.24.0
Quoted 14 lines · Bhaskar Chowdhury
SPDX syntax was complining by checkpatch fixed it,added space before it. And add bash interpreter to find by the env .
Signed-off-by Bhaskar Chowdhury <[email protected]>--- scripts/kernel_modules_info.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)scripts/kernel_modules_info.sh +0
-0
scripts/kernel_modules_info.sh line 5
Quoted 7 lines
scripts/kernel_modules_info.sh +2
-2@@ -1,5 +1,5 @@ -#!/bin/bash - -#SPDX-License-Identifier: GPL-2.0 +#!/usr/bin/env bash +# SPDX-License-Identifier: GPL-2.0 #=============================================================================== # # FILE: kernel_modules_info.sh
a. There is no good reason for patch 2/2. Just merge the 2 patches.
b. The big header comment in patch 1/2 is not needed and is unwanted. Just put some or all of that in the patch description/comment message.
Signature · 1 line
~Randy
Quoted 25 lines · Randy Dunlap
Quoted 14 lines · Bhaskar Chowdhury
SPDX syntax was complining by checkpatch fixed it,added space before it. And add bash interpreter to find by the env .
Signed-off-by Bhaskar Chowdhury <[email protected]>--- scripts/kernel_modules_info.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)scripts/kernel_modules_info.sh +0
-0scripts/kernel_modules_info.sh line 5
Quoted 7 lines
scripts/kernel_modules_info.sh +2
-2@@ -1,5 +1,5 @@ -#!/bin/bash - -#SPDX-License-Identifier: GPL-2.0 +#!/usr/bin/env bash +# SPDX-License-Identifier: GPL-2.0 #=============================================================================== # # FILE: kernel_modules_info.sha. There is no good reason for patch 2/2. Just merge the 2 patches.
Quoted 3 lines
b. The big header comment in patch 1/2 is not needed and is unwanted. Just put some or all of that in the patch description/comment message.
Sure, will do.
Quoted 4 lines
Signature · 2 lines
-- ~Randy