Skip to contentSkip to conversation

ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89

PATCH In review Hans de Goede 3 participants 3 messages Dec 3, 2019 – Dec 4, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89

When the Teclast X89 quirk was added we did not have jack-detection support yet.

Note the over-current detection limit is set to 2mA instead of the usual 1.5mA because this tablet tends to give false-positive button-presses when it is set to 1.5mA.

---
 sound/soc/intel/boards/bytcr_rt5640.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
sound/soc/intel/boards/bytcr_rt5640.c +6 -2
index dd2b5ad08659..243f683bc02a 100644
@@ -707,13 +707,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
 					BYT_RT5640_MCLK_EN),
 	},
 	{
+		/* Teclast X89 */
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
 			DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
 		},
 		.driver_data = (void *)(BYT_RT5640_IN3_MAP |
-					BYT_RT5640_MCLK_EN |
-					BYT_RT5640_SSP0_AIF1),
+					BYT_RT5640_JD_SRC_JD1_IN4P |
+					BYT_RT5640_OVCD_TH_2000UA |
+					BYT_RT5640_OVCD_SF_1P0 |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
 	},
 	{	/* Toshiba Satellite Click Mini L9W-B */
 		.matches = {
Signature · 6 lines
2.23.0

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Hans de Goede

When the Teclast X89 quirk was added we did not have jack-detection support yet.

Note the over-current detection limit is set to 2mA instead of the usual 1.5mA because this tablet tends to give false-positive button-presses when it is set to 1.5mA.

Thanks Hans!

Quoted 19 lines
---
  sound/soc/intel/boards/bytcr_rt5640.c | 8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)
sound/soc/intel/boards/bytcr_rt5640.c +1 -0
index dd2b5ad08659..243f683bc02a 100644
@@ -707,13 +707,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
  					BYT_RT5640_MCLK_EN),
  	},
  	{
+		/* Teclast X89 */
  		.matches = {
  			DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
  			DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
  		},
  		.driver_data = (void *)(BYT_RT5640_IN3_MAP |

sound/soc/intel/boards/bytcr_rt5640.c static const struct dmi_system_id byt_rt5640_quirk_table[] = { · line 723

Quoted 10 lines
sound/soc/intel/boards/bytcr_rt5640.c +5 -2
-					BYT_RT5640_MCLK_EN |
-					BYT_RT5640_SSP0_AIF1),
+					BYT_RT5640_JD_SRC_JD1_IN4P |
+					BYT_RT5640_OVCD_TH_2000UA |
+					BYT_RT5640_OVCD_SF_1P0 |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
  	},
  	{	/* Toshiba Satellite Click Mini L9W-B */
  		.matches = {

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

maintainer
#2 lore raw

[alsa-devel] Applied "ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89" to the asoc tree

In reply to Hans de Goede

The patch

ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89

has been applied to the asoc tree at

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

From 7eccc05c7101f34cc36afe9405d15de6d4099fb4 Mon Sep 17 00:00:00 2001
From: Hans de Goede <[email protected]>
Date: Tue, 3 Dec 2019 23:14:42 +0100
Subject: [PATCH] ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89

When the Teclast X89 quirk was added we did not have jack-detection support yet.

Note the over-current detection limit is set to 2mA instead of the usual 1.5mA because this tablet tends to give false-positive button-presses when it is set to 1.5mA.

---
 sound/soc/intel/boards/bytcr_rt5640.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
sound/soc/intel/boards/bytcr_rt5640.c +6 -2
index 9c1aa4ec9cba..cb511ea3b771 100644
@@ -705,13 +705,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
 					BYT_RT5640_MCLK_EN),
 	},
 	{
+		/* Teclast X89 */
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
 			DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
 		},
 		.driver_data = (void *)(BYT_RT5640_IN3_MAP |
-					BYT_RT5640_MCLK_EN |
-					BYT_RT5640_SSP0_AIF1),
+					BYT_RT5640_JD_SRC_JD1_IN4P |
+					BYT_RT5640_OVCD_TH_2000UA |
+					BYT_RT5640_OVCD_SF_1P0 |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
 	},
 	{	/* Toshiba Satellite Click Mini L9W-B */
 		.matches = {
Signature · 6 lines
2.20.1

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel