Skip to contentSkip to conversation

drm/amd/powerplay: drop unnecessary warning prompt

PATCH In review Evan Quan 2 participants 2 messages Dec 4, 2019

Subsystems (2)
lore
Share & tools
lore

Evan Quan

author
#0 lore raw

PATCH 1/1 drm/amd/powerplay: drop unnecessary warning prompt

As the check may be done with purpose and the warning output will be confusing.

Change-Id Ie0928c324a8161d44068f8ce648d56f6d9e8cd3d
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +1 -3
index 3f13986d8e50..70b296a8fef8 100644
@@ -280,10 +280,8 @@ static int arcturus_get_workload_type(struct smu_context *smu, enum PP_SMC_POWER
 		return -EINVAL;
 
 	mapping = arcturus_workload_map[profile];
-	if (!(mapping.valid_mapping)) {
-		pr_warn("Unsupported SMU power source: %d\n", profile);
+	if (!(mapping.valid_mapping))
 		return -EINVAL;
-	}
 
 	return mapping.map_to;
 }
Signature · 6 lines
2.24.0

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Evan Quan

As the check may be done with purpose and the warning output will be confusing.

Change-Id Ie0928c324a8161d44068f8ce648d56f6d9e8cd3d
Quoted 23 lines
---
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c +1 -4
index 3f13986d8e50..70b296a8fef8 100644
@@ -280,10 +280,8 @@ static int arcturus_get_workload_type(struct smu_context *smu, enum PP_SMC_POWER
                return -EINVAL;
 
        mapping = arcturus_workload_map[profile];
-       if (!(mapping.valid_mapping)) {
-               pr_warn("Unsupported SMU power source: %d\n", profile);
+       if (!(mapping.valid_mapping))
                return -EINVAL;
-       }
 
        return mapping.map_to;
 }
--

2.24.0

Quoted 4 lines

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx