Skip to contentSkip to conversation

ASoC: tas2552: add missed regulator_bulk_disable in remove

PATCH In review Chuhong Yuan 2 participants 2 messages Dec 6, 2019 – Dec 9, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: tas2552: add missed regulator_bulk_disable in remove

The driver forgets to call regulator_bulk_disable() in remove like that in probe failure.
Add the missed call to fix it.

---
 sound/soc/codecs/tas2552.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/codecs/tas2552.c +3 -0
index 56671f21cfe5..0e19ec76aae0 100644
@@ -616,6 +616,9 @@ static void tas2552_component_remove(struct snd_soc_component *component)
 	pm_runtime_put(component->dev);
 
 	gpiod_set_value(tas2552->enable_gpio, 0);
+
+	regulator_bulk_disable(ARRAY_SIZE(tas2552->supplies),
+					tas2552->supplies);
 };
 
 #ifdef CONFIG_PM
Signature · 1 line
2.24.0
maintainer
#1 lore raw
Quoted 3 lines · Chuhong Yuan

The driver forgets to call regulator_bulk_disable() in remove like that in probe failure.
Add the missed call to fix it.

Another runtime PM interaction here.