Skip to contentSkip to conversation

spi: spi-cavium-thunderx: Add missing pci_release_regions()

PATCH New Chuhong Yuan 1 participant 1 message Dec 6, 2019 SPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spi: spi-cavium-thunderx: Add missing pci_release_regions()

The driver forgets to call pci_release_regions() in probe failure and remove.
Add the missed calls to fix it.

---
 drivers/spi/spi-cavium-thunderx.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/spi/spi-cavium-thunderx.c +2 -0
index d12e149f1a41..fd6b9caffaf0 100644
@@ -82,6 +82,7 @@ static int thunderx_spi_probe(struct pci_dev *pdev,
 
 error:
 	clk_disable_unprepare(p->clk);
+	pci_release_regions(pdev);
 	spi_master_put(master);
 	return ret;
 }
@@ -96,6 +97,7 @@ static void thunderx_spi_remove(struct pci_dev *pdev)
 		return;
 
 	clk_disable_unprepare(p->clk);
+	pci_release_regions(pdev);
 	/* Put everything in a known state. */
 	writeq(0, p->register_base + OCTEON_SPI_CFG(p));
 }
Signature · 1 line
2.24.0