Skip to contentSkip to conversation

watchdog: tqmx86_wdt: Fix build error

PATCH In review YueHaibing 2 participants 2 messages Dec 6, 2019 Watchdog device drivers

lore
Share & tools
lore

YueHaibing

author
#0 lore raw

PATCH 1/1 watchdog: tqmx86_wdt: Fix build error

If TQMX86_WDT is y and WATCHDOG_CORE is m, building fails:

drivers/watchdog/tqmx86_wdt.o: In function `tqmx86_wdt_probe':
tqmx86_wdt.c:(.text+0x46e): undefined reference to watchdog_init_timeout' tqmx86_wdt.c:(.text+0x4e0): undefined reference to devm_watchdog_register_device'

Select WATCHDOG_CORE to fix this.

Fixes e3c21e088f89 ("watchdog: tqmx86: Add watchdog driver for the IO controller")
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index 1679e0d..20bd967 100644
@@ -1444,6 +1444,7 @@ config SMSC37B787_WDT
 config TQMX86_WDT
 	tristate "TQ-Systems TQMX86 Watchdog Timer"
 	depends on X86
+	select WATCHDOG_CORE
 	help
 	This is the driver for the hardware watchdog timer in the TQMX86 IO
 	controller found on some of their ComExpress Modules.
Signature · 1 line
2.7.4
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 11 lines · YueHaibing

If TQMX86_WDT is y and WATCHDOG_CORE is m, building fails:

drivers/watchdog/tqmx86_wdt.o: In function `tqmx86_wdt_probe':
tqmx86_wdt.c:(.text+0x46e): undefined reference to watchdog_init_timeout' tqmx86_wdt.c:(.text+0x4e0): undefined reference to devm_watchdog_register_device'

Select WATCHDOG_CORE to fix this.

Fixes e3c21e088f89 ("watchdog: tqmx86: Add watchdog driver for the IO controller")
Quoted 17 lines
---
  drivers/watchdog/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/watchdog/Kconfig +1 -0
index 1679e0d..20bd967 100644
@@ -1444,6 +1444,7 @@ config SMSC37B787_WDT
  config TQMX86_WDT
  	tristate "TQ-Systems TQMX86 Watchdog Timer"
  	depends on X86
+	select WATCHDOG_CORE
  	help
  	This is the driver for the hardware watchdog timer in the TQMX86 IO
  	controller found on some of their ComExpress Modules.