Skip to contentSkip to conversation

imx: dts: tbs2910: add u-boot dtsi to shrink image size

PATCH New Anatolij Gustschin 4 participants 7 messages Dec 6, 2019 – Jan 9, 2020

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 imx: dts: tbs2910: add u-boot dtsi to shrink image size

Use U-Boot specific board dtsi to remove some not used nodes and properties. With this change applied considerable size reduction has been observed:

  $ ./tools/buildman/buildman -b tbs2910 -f tbs2910 || \
    ./tools/buildman/buildman -b tbs2910 -sS tbs2910
  ...
  Summary of 2 commits for 1 boards (1 thread, 12 jobs per thread)
  01: Merge branch '2019-12-05-master-imports'
         arm:  w+   tbs2910
  02: imx: dts: tbs2910: add u-boot dtsi to shrink image size
         arm: (for 1/1 boards) all -24448.0 text -24448.0

---
This patch was only build-tested, maybe this removes to much and needs some tweaking. I'd appreciate if someone could test it on actual hardware and finish the work, so we hopefully can solve frequent CI build breakage caused by this target.

 arch/arm/dts/imx6q-tbs2910-u-boot.dtsi | 219 +++++++++++++++++++++++++
 1 file changed, 219 insertions(+)
 create mode 100644 arch/arm/dts/imx6q-tbs2910-u-boot.dtsi
arch/arm/dts/imx6q-tbs2910-u-boot.dtsi new file +219 -0
new file mode 100644
index 0000000000..3e9307f17f
@@ -0,0 +1,219 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * U-Boot specific modifications for original tbs2910 DTS.
+ * This drops not used nodes/properties to reduce the image size.
+ */
+
+/ {
+	/delete-property/ model;
+	/delete-property/ compatible;
+
+	aliases {
+		/delete-property/ can0;
+		/delete-property/ can1;
+		/delete-property/ gpio3;
+		/delete-property/ gpio4;
+		/delete-property/ gpio5;
+		/delete-property/ ipu1;
+		/delete-property/ mmc3;
+		/delete-property/ spi0;
+		/delete-property/ spi1;
+		/delete-property/ spi2;
+		/delete-property/ spi3;
+		/delete-property/ spi4;
+		/delete-property/ serial2;
+		/delete-property/ serial3;
+		/delete-property/ serial4;
+		/delete-property/ video1;
+	};
+
+	/delete-node/ cpus;
+	/delete-node/ capture-subsystem;
+	/delete-node/ chosen;
+	/delete-node/ display-subsystem;
+	/delete-node/ fan;
+	/delete-node/ ir_recv;
+	/delete-node/ leds;
+	/delete-node/ memory;
+	/delete-node/ sound-sgtl5000;
+	/delete-node/ sound-spdif;
+
+	soc {
+		u-boot,dm-pre-reloc;
+		/delete-property/ ranges;
+		/delete-node/ timer at a00600;
+
+		aips-bus at 2000000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 207c000;
+			spba-bus at 2000000 {
+				/delete-property/ ranges;
+				/delete-node/ spba at 203c000;
+			};
+		};
+
+		aips-bus at 2100000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 217c000;
+			/delete-node/ mlb at 218c000;
+			/delete-node/ romcp at 21ac000;
+			/delete-node/ tzasc at 21d0000;
+			/delete-node/ tzasc at 21d4000;
+			/delete-node/ vdoa at 21e4000;
+		};
+	};
+};
+
+&anatop {
+	/delete-node/ regulator-1p1;
+	/delete-node/ regulator-2p5;
+	/delete-node/ regulator-3p0;
+	/delete-node/ regulator-vddcore;
+	/delete-node/ regulator-vddpu;
+	/delete-node/ regulator-vddsoc;
+};
+
+&sata {
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ interrupts;
+	/delete-property/ interrupts;
+	/delete-property/ fsl,transmit-level-mV;
+	/delete-property/ fsl,transmit-boost-mdB;
+	/delete-property/ fsl,transmit-atten-16ths;
+	/delete-property/ fsl,receive-eq-mdB;
+};
+
+&pcie {
+	/delete-property/ reg-names;
+	/delete-property/ device_type;
+	/delete-property/ bus-range;
+	/delete-property/ ranges;
+	/delete-property/ num-lanes;
+	/delete-property/ interrupts;
+	/delete-property/ interrupt-names;
+	/delete-property/ #interrupt-cells;
+	/delete-property/ interrupt-map-mask;
+	/delete-property/ interrupt-map;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+};
+
+&uart1 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+&uart2 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+/delete-node/ &L2;
+/delete-node/ &asrc;
+/delete-node/ &audmux;
+/delete-node/ &can1;
+/delete-node/ &can2;
+/delete-node/ &crypto;
+/delete-node/ &dcic1;
+/delete-node/ &dcic2;
+/delete-node/ &dma_apbh;
+/delete-node/ &ecspi1;
+/delete-node/ &ecspi2;
+/delete-node/ &ecspi3;
+/delete-node/ &ecspi4;
+/delete-node/ &ecspi5;
+/delete-node/ &epit1;
+/delete-node/ &epit2;
+/delete-node/ &esai;
+/delete-node/ &gpt;
+/delete-node/ &gpio4;
+/delete-node/ &gpio5;
+/delete-node/ &gpio6;
+/delete-node/ &gpu_3d;
+/delete-node/ &gpu_2d;
+/delete-node/ &gpu_vg;
+/delete-node/ &gpmi;
+/delete-node/ &ipu2;
+/delete-node/ &kpp;
+/delete-node/ &ldb;
+/delete-node/ &mipi_csi;
+/delete-node/ &mmdc0;
+/delete-node/ &mmdc1;
+/delete-node/ &ocotp;
+/delete-node/ &ocram;
+/delete-node/ &pinctrl_gpio_fan;
+/delete-node/ &pinctrl_ir;
+/delete-node/ &pinctrl_gpio_leds;
+/delete-node/ &pinctrl_sgtl5000;
+/delete-node/ &pinctrl_spdif;
+/delete-node/ &pmu;
+/delete-node/ &pwm1;
+/delete-node/ &pwm2;
+/delete-node/ &pwm3;
+/delete-node/ &pwm4;
+/delete-node/ &sdma;
+/delete-node/ &reg_2p5v;
+/delete-node/ &sgtl5000;
+/delete-node/ &snvs;
+/delete-node/ &spdif;
+/delete-node/ &src;
+/delete-node/ &ssi1;
+/delete-node/ &ssi2;
+/delete-node/ &ssi3;
+/delete-node/ &tempmon;
+/delete-node/ &uart3;
+/delete-node/ &uart4;
+/delete-node/ &uart5;
+/delete-node/ &usbh2;
+/delete-node/ &usbh3;
+/delete-node/ &usdhc1;
+/delete-node/ &vpu;
+/delete-node/ &wdog2;
+/delete-node/ &weim;
+
+&gpr {
+	/delete-node/ ipu1_csi0_mux;
+	/delete-node/ ipu2_csi1_mux;
+};
+
+&gpc {
+	/delete-node/ pgc;
+};
+
+&hdmi {
+	/delete-node/ port at 2;
+	/delete-node/ port at 3;
+};
+
+&mipi_dsi {
+	ports {
+		/delete-node/ port at 2;
+		/delete-node/ port at 3;
+	};
+};
+
+&ipu1 {
+	u-boot,dm-pre-reloc;
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ resets;
+	/delete-node/ port at 0;
+	/delete-node/ port at 1;
+
+	port at 2 {
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+	port at 3 {
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+};
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 imx: dts: tbs2910: add u-boot dtsi to shrink image size

Quoted 239 lines · Anatolij Gustschin

Use U-Boot specific board dtsi to remove some not used nodes and properties. With this change applied considerable size reduction has been observed:

  $ ./tools/buildman/buildman -b tbs2910 -f tbs2910 || \
    ./tools/buildman/buildman -b tbs2910 -sS tbs2910
  ...
  Summary of 2 commits for 1 boards (1 thread, 12 jobs per thread)
  01: Merge branch '2019-12-05-master-imports'
         arm:  w+   tbs2910
  02: imx: dts: tbs2910: add u-boot dtsi to shrink image size
         arm: (for 1/1 boards) all -24448.0 text -24448.0

---
This patch was only build-tested, maybe this removes to much and needs some tweaking. I'd appreciate if someone could test it on actual hardware and finish the work, so we hopefully can solve frequent CI build breakage caused by this target.

 arch/arm/dts/imx6q-tbs2910-u-boot.dtsi | 219 +++++++++++++++++++++++++
 1 file changed, 219 insertions(+)
 create mode 100644 arch/arm/dts/imx6q-tbs2910-u-boot.dtsi
arch/arm/dts/imx6q-tbs2910-u-boot.dtsi new file +209 -0
new file mode 100644
index 0000000000..3e9307f17f
@@ -0,0 +1,219 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * U-Boot specific modifications for original tbs2910 DTS.
+ * This drops not used nodes/properties to reduce the image size.
+ */
+
+/ {
+	/delete-property/ model;
+	/delete-property/ compatible;
+
+	aliases {
+		/delete-property/ can0;
+		/delete-property/ can1;
+		/delete-property/ gpio3;
+		/delete-property/ gpio4;
+		/delete-property/ gpio5;
+		/delete-property/ ipu1;
+		/delete-property/ mmc3;
+		/delete-property/ spi0;
+		/delete-property/ spi1;
+		/delete-property/ spi2;
+		/delete-property/ spi3;
+		/delete-property/ spi4;
+		/delete-property/ serial2;
+		/delete-property/ serial3;
+		/delete-property/ serial4;
+		/delete-property/ video1;
+	};
+
+	/delete-node/ cpus;
+	/delete-node/ capture-subsystem;
+	/delete-node/ chosen;
+	/delete-node/ display-subsystem;
+	/delete-node/ fan;
+	/delete-node/ ir_recv;
+	/delete-node/ leds;
+	/delete-node/ memory;
+	/delete-node/ sound-sgtl5000;
+	/delete-node/ sound-spdif;
+
+	soc {
+		u-boot,dm-pre-reloc;
+		/delete-property/ ranges;
+		/delete-node/ timer at a00600;
+
+		aips-bus at 2000000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 207c000;
+			spba-bus at 2000000 {
+				/delete-property/ ranges;
+				/delete-node/ spba at 203c000;
+			};
+		};
+
+		aips-bus at 2100000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 217c000;
+			/delete-node/ mlb at 218c000;
+			/delete-node/ romcp at 21ac000;
+			/delete-node/ tzasc at 21d0000;
+			/delete-node/ tzasc at 21d4000;
+			/delete-node/ vdoa at 21e4000;
+		};
+	};
+};
+
+&anatop {
+	/delete-node/ regulator-1p1;
+	/delete-node/ regulator-2p5;
+	/delete-node/ regulator-3p0;
+	/delete-node/ regulator-vddcore;
+	/delete-node/ regulator-vddpu;
+	/delete-node/ regulator-vddsoc;
+};
+
+&sata {
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ interrupts;
+	/delete-property/ interrupts;
+	/delete-property/ fsl,transmit-level-mV;
+	/delete-property/ fsl,transmit-boost-mdB;
+	/delete-property/ fsl,transmit-atten-16ths;
+	/delete-property/ fsl,receive-eq-mdB;
+};
+
+&pcie {
+	/delete-property/ reg-names;
+	/delete-property/ device_type;
+	/delete-property/ bus-range;
+	/delete-property/ ranges;
+	/delete-property/ num-lanes;
+	/delete-property/ interrupts;
+	/delete-property/ interrupt-names;
+	/delete-property/ #interrupt-cells;
+	/delete-property/ interrupt-map-mask;
+	/delete-property/ interrupt-map;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+};
+
+&uart1 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+&uart2 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+/delete-node/ &L2;
+/delete-node/ &asrc;
+/delete-node/ &audmux;
+/delete-node/ &can1;
+/delete-node/ &can2;
+/delete-node/ &crypto;
+/delete-node/ &dcic1;
+/delete-node/ &dcic2;
+/delete-node/ &dma_apbh;
+/delete-node/ &ecspi1;
+/delete-node/ &ecspi2;
+/delete-node/ &ecspi3;
+/delete-node/ &ecspi4;
+/delete-node/ &ecspi5;
+/delete-node/ &epit1;
+/delete-node/ &epit2;
+/delete-node/ &esai;
+/delete-node/ &gpt;
+/delete-node/ &gpio4;
+/delete-node/ &gpio5;
+/delete-node/ &gpio6;
+/delete-node/ &gpu_3d;
+/delete-node/ &gpu_2d;
+/delete-node/ &gpu_vg;
+/delete-node/ &gpmi;
+/delete-node/ &ipu2;
+/delete-node/ &kpp;
+/delete-node/ &ldb;
+/delete-node/ &mipi_csi;
+/delete-node/ &mmdc0;
+/delete-node/ &mmdc1;
+/delete-node/ &ocotp;
+/delete-node/ &ocram;
+/delete-node/ &pinctrl_gpio_fan;
+/delete-node/ &pinctrl_ir;
+/delete-node/ &pinctrl_gpio_leds;
+/delete-node/ &pinctrl_sgtl5000;
+/delete-node/ &pinctrl_spdif;
+/delete-node/ &pmu;
+/delete-node/ &pwm1;
+/delete-node/ &pwm2;
+/delete-node/ &pwm3;
+/delete-node/ &pwm4;
+/delete-node/ &sdma;
+/delete-node/ &reg_2p5v;
+/delete-node/ &sgtl5000;
+/delete-node/ &snvs;
+/delete-node/ &spdif;
+/delete-node/ &src;
+/delete-node/ &ssi1;
+/delete-node/ &ssi2;
+/delete-node/ &ssi3;
+/delete-node/ &tempmon;
+/delete-node/ &uart3;
+/delete-node/ &uart4;
+/delete-node/ &uart5;
+/delete-node/ &usbh2;
+/delete-node/ &usbh3;
+/delete-node/ &usdhc1;
+/delete-node/ &vpu;
+/delete-node/ &wdog2;
+/delete-node/ &weim;
+
+&gpr {
+	/delete-node/ ipu1_csi0_mux;
+	/delete-node/ ipu2_csi1_mux;
+};
+
+&gpc {
+	/delete-node/ pgc;
+};
+
+&hdmi {
+	/delete-node/ port at 2;
+	/delete-node/ port at 3;
+};
+
+&mipi_dsi {
+	ports {
+		/delete-node/ port at 2;
+		/delete-node/ port at 3;
+	};
+};
+
+&ipu1 {
+	u-boot,dm-pre-reloc;
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ resets;
+	/delete-node/ port at 0;
+	/delete-node/ port at 1;

arch/arm/dts/imx6q-tbs2910-u-boot.dtsi line 219

Quoted 10 lines
arch/arm/dts/imx6q-tbs2910-u-boot.dtsi new file +10 -0
+
+	port at 2 {
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+	port at 3 {
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+};

This gets an important conversation started. Perhaps we should expand OF_SPL_REMOVE_PROPS for full U-Boot, with some gating symbol for the platforms that do want to pass through the full DT to the OS?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191206/e214f008/attachment.sig>
#2 lore raw

PATCH 1/1 imx: dts: tbs2910: add u-boot dtsi to shrink image size

Quoted 243 lines · Tom Rini
Quoted 241 lines · Anatolij Gustschin

Use U-Boot specific board dtsi to remove some not used nodes and properties. With this change applied considerable size reduction has been observed:

  $ ./tools/buildman/buildman -b tbs2910 -f tbs2910 || \
    ./tools/buildman/buildman -b tbs2910 -sS tbs2910
  ...
  Summary of 2 commits for 1 boards (1 thread, 12 jobs per thread)
  01: Merge branch '2019-12-05-master-imports'
         arm:  w+   tbs2910
  02: imx: dts: tbs2910: add u-boot dtsi to shrink image size
         arm: (for 1/1 boards) all -24448.0 text -24448.0

---
This patch was only build-tested, maybe this removes to much and needs some tweaking. I'd appreciate if someone could test it on actual hardware and finish the work, so we hopefully can solve frequent CI build breakage caused by this target.

 arch/arm/dts/imx6q-tbs2910-u-boot.dtsi | 219 +++++++++++++++++++++++++
 1 file changed, 219 insertions(+)
 create mode 100644 arch/arm/dts/imx6q-tbs2910-u-boot.dtsi
arch/arm/dts/imx6q-tbs2910-u-boot.dtsi new file +211 -0
new file mode 100644
index 0000000000..3e9307f17f
@@ -0,0 +1,219 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * U-Boot specific modifications for original tbs2910 DTS.
+ * This drops not used nodes/properties to reduce the image size.
+ */
+
+/ {
+	/delete-property/ model;
+	/delete-property/ compatible;
+
+	aliases {
+		/delete-property/ can0;
+		/delete-property/ can1;
+		/delete-property/ gpio3;
+		/delete-property/ gpio4;
+		/delete-property/ gpio5;
+		/delete-property/ ipu1;
+		/delete-property/ mmc3;
+		/delete-property/ spi0;
+		/delete-property/ spi1;
+		/delete-property/ spi2;
+		/delete-property/ spi3;
+		/delete-property/ spi4;
+		/delete-property/ serial2;
+		/delete-property/ serial3;
+		/delete-property/ serial4;
+		/delete-property/ video1;
+	};
+
+	/delete-node/ cpus;
+	/delete-node/ capture-subsystem;
+	/delete-node/ chosen;
+	/delete-node/ display-subsystem;
+	/delete-node/ fan;
+	/delete-node/ ir_recv;
+	/delete-node/ leds;
+	/delete-node/ memory;
+	/delete-node/ sound-sgtl5000;
+	/delete-node/ sound-spdif;
+
+	soc {
+		u-boot,dm-pre-reloc;
+		/delete-property/ ranges;
+		/delete-node/ timer at a00600;
+
+		aips-bus at 2000000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 207c000;
+			spba-bus at 2000000 {
+				/delete-property/ ranges;
+				/delete-node/ spba at 203c000;
+			};
+		};
+
+		aips-bus at 2100000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 217c000;
+			/delete-node/ mlb at 218c000;
+			/delete-node/ romcp at 21ac000;
+			/delete-node/ tzasc at 21d0000;
+			/delete-node/ tzasc at 21d4000;
+			/delete-node/ vdoa at 21e4000;
+		};
+	};
+};
+
+&anatop {
+	/delete-node/ regulator-1p1;
+	/delete-node/ regulator-2p5;
+	/delete-node/ regulator-3p0;
+	/delete-node/ regulator-vddcore;
+	/delete-node/ regulator-vddpu;
+	/delete-node/ regulator-vddsoc;
+};
+
+&sata {
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ interrupts;
+	/delete-property/ interrupts;
+	/delete-property/ fsl,transmit-level-mV;
+	/delete-property/ fsl,transmit-boost-mdB;
+	/delete-property/ fsl,transmit-atten-16ths;
+	/delete-property/ fsl,receive-eq-mdB;
+};
+
+&pcie {
+	/delete-property/ reg-names;
+	/delete-property/ device_type;
+	/delete-property/ bus-range;
+	/delete-property/ ranges;
+	/delete-property/ num-lanes;
+	/delete-property/ interrupts;
+	/delete-property/ interrupt-names;
+	/delete-property/ #interrupt-cells;
+	/delete-property/ interrupt-map-mask;
+	/delete-property/ interrupt-map;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+};
+
+&uart1 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+&uart2 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+/delete-node/ &L2;
+/delete-node/ &asrc;
+/delete-node/ &audmux;
+/delete-node/ &can1;
+/delete-node/ &can2;
+/delete-node/ &crypto;
+/delete-node/ &dcic1;
+/delete-node/ &dcic2;
+/delete-node/ &dma_apbh;
+/delete-node/ &ecspi1;
+/delete-node/ &ecspi2;
+/delete-node/ &ecspi3;
+/delete-node/ &ecspi4;
+/delete-node/ &ecspi5;
+/delete-node/ &epit1;
+/delete-node/ &epit2;
+/delete-node/ &esai;
+/delete-node/ &gpt;
+/delete-node/ &gpio4;
+/delete-node/ &gpio5;
+/delete-node/ &gpio6;
+/delete-node/ &gpu_3d;
+/delete-node/ &gpu_2d;
+/delete-node/ &gpu_vg;
+/delete-node/ &gpmi;
+/delete-node/ &ipu2;
+/delete-node/ &kpp;
+/delete-node/ &ldb;
+/delete-node/ &mipi_csi;
+/delete-node/ &mmdc0;
+/delete-node/ &mmdc1;
+/delete-node/ &ocotp;
+/delete-node/ &ocram;
+/delete-node/ &pinctrl_gpio_fan;
+/delete-node/ &pinctrl_ir;
+/delete-node/ &pinctrl_gpio_leds;
+/delete-node/ &pinctrl_sgtl5000;
+/delete-node/ &pinctrl_spdif;
+/delete-node/ &pmu;
+/delete-node/ &pwm1;
+/delete-node/ &pwm2;
+/delete-node/ &pwm3;
+/delete-node/ &pwm4;
+/delete-node/ &sdma;
+/delete-node/ &reg_2p5v;
+/delete-node/ &sgtl5000;
+/delete-node/ &snvs;
+/delete-node/ &spdif;
+/delete-node/ &src;
+/delete-node/ &ssi1;
+/delete-node/ &ssi2;
+/delete-node/ &ssi3;
+/delete-node/ &tempmon;
+/delete-node/ &uart3;
+/delete-node/ &uart4;
+/delete-node/ &uart5;
+/delete-node/ &usbh2;
+/delete-node/ &usbh3;
+/delete-node/ &usdhc1;
+/delete-node/ &vpu;
+/delete-node/ &wdog2;
+/delete-node/ &weim;
+
+&gpr {
+	/delete-node/ ipu1_csi0_mux;
+	/delete-node/ ipu2_csi1_mux;
+};
+
+&gpc {
+	/delete-node/ pgc;
+};
+
+&hdmi {
+	/delete-node/ port at 2;
+	/delete-node/ port at 3;
+};
+
+&mipi_dsi {
+	ports {
+		/delete-node/ port at 2;
+		/delete-node/ port at 3;
+	};
+};
+
+&ipu1 {
+	u-boot,dm-pre-reloc;
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ resets;
+	/delete-node/ port at 0;
+	/delete-node/ port at 1;
+
+	port at 2 {
Quoted 8 lines

arch/arm/dts/imx6q-tbs2910-u-boot.dtsi line 219

Quoted 8 lines
arch/arm/dts/imx6q-tbs2910-u-boot.dtsi new file +8 -0
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+	port at 3 {
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+};

Oh, most of the deleted properties and nodes are not defined in the board dts, but in the soc dtsi instead.
So for me it would make more sense to also split the "delete dtsi" in a board and soc part, if this really is the way to go.

Quoted 4 lines

This gets an important conversation started. Perhaps we should expand OF_SPL_REMOVE_PROPS for full U-Boot, with some gating symbol for the platforms that do want to pass through the full DT to the OS?

I also already looked at OF_SPL_REMOVE_PROPS, would make much sense to have this for full u-boot. To duplicate each device tree with an almost identical "delete dtsi" looks like a huge maintenance burden for me.

Maybe the build system can at least automatically remove disabled nodes and nodes without compatible in enabled DM drivers. This would not help for unneeded properties in enabled nodes, but probably automatically give the biggest part of size reduction.

 Soeren

#3 lore raw

PATCH 1/1 imx: dts: tbs2910: add u-boot dtsi to shrink image size

Quoted 262 lines · Soeren Moch
Quoted 243 lines · Tom Rini
Quoted 241 lines · Anatolij Gustschin

Use U-Boot specific board dtsi to remove some not used nodes and properties. With this change applied considerable size reduction has been observed:

   $ ./tools/buildman/buildman -b tbs2910 -f tbs2910 || \
     ./tools/buildman/buildman -b tbs2910 -sS tbs2910
   ...
   Summary of 2 commits for 1 boards (1 thread, 12 jobs per thread)
   01: Merge branch '2019-12-05-master-imports'
          arm:  w+   tbs2910
   02: imx: dts: tbs2910: add u-boot dtsi to shrink image size
          arm: (for 1/1 boards) all -24448.0 text -24448.0

---
This patch was only build-tested, maybe this removes to much and needs some tweaking. I'd appreciate if someone could test it on actual hardware and finish the work, so we hopefully can solve frequent CI build breakage caused by this target.

  arch/arm/dts/imx6q-tbs2910-u-boot.dtsi | 219 +++++++++++++++++++++++++
  1 file changed, 219 insertions(+)

create mode 100644 arch/arm/dts/imx6q-tbs2910-u-boot.dtsi

arch/arm/dts/imx6q-tbs2910-u-boot.dtsi new file +211 -0
new file mode 100644
index 0000000000..3e9307f17f
@@ -0,0 +1,219 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * U-Boot specific modifications for original tbs2910 DTS.
+ * This drops not used nodes/properties to reduce the image size.
+ */
+
+/ {
+	/delete-property/ model;
+	/delete-property/ compatible;
+
+	aliases {
+		/delete-property/ can0;
+		/delete-property/ can1;
+		/delete-property/ gpio3;
+		/delete-property/ gpio4;
+		/delete-property/ gpio5;
+		/delete-property/ ipu1;
+		/delete-property/ mmc3;
+		/delete-property/ spi0;
+		/delete-property/ spi1;
+		/delete-property/ spi2;
+		/delete-property/ spi3;
+		/delete-property/ spi4;
+		/delete-property/ serial2;
+		/delete-property/ serial3;
+		/delete-property/ serial4;
+		/delete-property/ video1;
+	};
+
+	/delete-node/ cpus;
+	/delete-node/ capture-subsystem;
+	/delete-node/ chosen;
+	/delete-node/ display-subsystem;
+	/delete-node/ fan;
+	/delete-node/ ir_recv;
+	/delete-node/ leds;
+	/delete-node/ memory;
+	/delete-node/ sound-sgtl5000;
+	/delete-node/ sound-spdif;
+
+	soc {
+		u-boot,dm-pre-reloc;
+		/delete-property/ ranges;
+		/delete-node/ timer at a00600;
+
+		aips-bus at 2000000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 207c000;
+			spba-bus at 2000000 {
+				/delete-property/ ranges;
+				/delete-node/ spba at 203c000;
+			};
+		};
+
+		aips-bus at 2100000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 217c000;
+			/delete-node/ mlb at 218c000;
+			/delete-node/ romcp at 21ac000;
+			/delete-node/ tzasc at 21d0000;
+			/delete-node/ tzasc at 21d4000;
+			/delete-node/ vdoa at 21e4000;
+		};
+	};
+};
+
+&anatop {
+	/delete-node/ regulator-1p1;
+	/delete-node/ regulator-2p5;
+	/delete-node/ regulator-3p0;
+	/delete-node/ regulator-vddcore;
+	/delete-node/ regulator-vddpu;
+	/delete-node/ regulator-vddsoc;
+};
+
+&sata {
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ interrupts;
+	/delete-property/ interrupts;
+	/delete-property/ fsl,transmit-level-mV;
+	/delete-property/ fsl,transmit-boost-mdB;
+	/delete-property/ fsl,transmit-atten-16ths;
+	/delete-property/ fsl,receive-eq-mdB;
+};
+
+&pcie {
+	/delete-property/ reg-names;
+	/delete-property/ device_type;
+	/delete-property/ bus-range;
+	/delete-property/ ranges;
+	/delete-property/ num-lanes;
+	/delete-property/ interrupts;
+	/delete-property/ interrupt-names;
+	/delete-property/ #interrupt-cells;
+	/delete-property/ interrupt-map-mask;
+	/delete-property/ interrupt-map;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+};
+
+&uart1 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+&uart2 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+/delete-node/ &L2;
+/delete-node/ &asrc;
+/delete-node/ &audmux;
+/delete-node/ &can1;
+/delete-node/ &can2;
+/delete-node/ &crypto;
+/delete-node/ &dcic1;
+/delete-node/ &dcic2;
+/delete-node/ &dma_apbh;
+/delete-node/ &ecspi1;
+/delete-node/ &ecspi2;
+/delete-node/ &ecspi3;
+/delete-node/ &ecspi4;
+/delete-node/ &ecspi5;
+/delete-node/ &epit1;
+/delete-node/ &epit2;
+/delete-node/ &esai;
+/delete-node/ &gpt;
+/delete-node/ &gpio4;
+/delete-node/ &gpio5;
+/delete-node/ &gpio6;
+/delete-node/ &gpu_3d;
+/delete-node/ &gpu_2d;
+/delete-node/ &gpu_vg;
+/delete-node/ &gpmi;
+/delete-node/ &ipu2;
+/delete-node/ &kpp;
+/delete-node/ &ldb;
+/delete-node/ &mipi_csi;
+/delete-node/ &mmdc0;
+/delete-node/ &mmdc1;
+/delete-node/ &ocotp;
+/delete-node/ &ocram;
+/delete-node/ &pinctrl_gpio_fan;
+/delete-node/ &pinctrl_ir;
+/delete-node/ &pinctrl_gpio_leds;
+/delete-node/ &pinctrl_sgtl5000;
+/delete-node/ &pinctrl_spdif;
+/delete-node/ &pmu;
+/delete-node/ &pwm1;
+/delete-node/ &pwm2;
+/delete-node/ &pwm3;
+/delete-node/ &pwm4;
+/delete-node/ &sdma;
+/delete-node/ &reg_2p5v;
+/delete-node/ &sgtl5000;
+/delete-node/ &snvs;
+/delete-node/ &spdif;
+/delete-node/ &src;
+/delete-node/ &ssi1;
+/delete-node/ &ssi2;
+/delete-node/ &ssi3;
+/delete-node/ &tempmon;
+/delete-node/ &uart3;
+/delete-node/ &uart4;
+/delete-node/ &uart5;
+/delete-node/ &usbh2;
+/delete-node/ &usbh3;
+/delete-node/ &usdhc1;
+/delete-node/ &vpu;
+/delete-node/ &wdog2;
+/delete-node/ &weim;
+
+&gpr {
+	/delete-node/ ipu1_csi0_mux;
+	/delete-node/ ipu2_csi1_mux;
+};
+
+&gpc {
+	/delete-node/ pgc;
+};
+
+&hdmi {
+	/delete-node/ port at 2;
+	/delete-node/ port at 3;
+};
+
+&mipi_dsi {
+	ports {
+		/delete-node/ port at 2;
+		/delete-node/ port at 3;
+	};
+};
+
+&ipu1 {
+	u-boot,dm-pre-reloc;
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ resets;
+	/delete-node/ port at 0;
+	/delete-node/ port at 1;
+
+	port at 2 {
Quoted 8 lines

arch/arm/dts/imx6q-tbs2910-u-boot.dtsi line 219

Quoted 8 lines
arch/arm/dts/imx6q-tbs2910-u-boot.dtsi new file +8 -0
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+	port at 3 {
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+};

Oh, most of the deleted properties and nodes are not defined in the board dts, but in the soc dtsi instead.
So for me it would make more sense to also split the "delete dtsi" in a board and soc part, if this really is the way to go.

Quoted 4 lines

This gets an important conversation started. Perhaps we should expand OF_SPL_REMOVE_PROPS for full U-Boot, with some gating symbol for the platforms that do want to pass through the full DT to the OS?

Quoted 9 lines

I also already looked at OF_SPL_REMOVE_PROPS, would make much sense to have this for full u-boot. To duplicate each device tree with an almost identical "delete dtsi" looks like a huge maintenance burden for me.

Maybe the build system can at least automatically remove disabled nodes and nodes without compatible in enabled DM drivers. This would not help for unneeded properties in enabled nodes, but probably automatically give the biggest part of size reduction.

In an ideal world the firmware and not the operating system would supply the device tree for booting the operating system. Currently for many boards the U-Boot supplied device tree is enough to boot Linux. Deleting nodes not used by U-Boot would not be helpful in this context.

Best regards

Heinrich

#4 lore raw

PATCH 1/1 imx: dts: tbs2910: add u-boot dtsi to shrink image size

Quoted 273 lines · Heinrich Schuchardt
Quoted 262 lines · Soeren Moch
Quoted 243 lines · Tom Rini
Quoted 241 lines · Anatolij Gustschin

Use U-Boot specific board dtsi to remove some not used nodes and properties. With this change applied considerable size reduction has been observed:

   $ ./tools/buildman/buildman -b tbs2910 -f tbs2910 || \
     ./tools/buildman/buildman -b tbs2910 -sS tbs2910
   ...
   Summary of 2 commits for 1 boards (1 thread, 12 jobs per thread)
   01: Merge branch '2019-12-05-master-imports'
          arm:  w+   tbs2910
   02: imx: dts: tbs2910: add u-boot dtsi to shrink image size
          arm: (for 1/1 boards) all -24448.0 text -24448.0

---
This patch was only build-tested, maybe this removes to much and needs some tweaking. I'd appreciate if someone could test it on actual hardware and finish the work, so we hopefully can solve frequent CI build breakage caused by this target.

  arch/arm/dts/imx6q-tbs2910-u-boot.dtsi | 219 +++++++++++++++++++++++++
  1 file changed, 219 insertions(+)

create mode 100644 arch/arm/dts/imx6q-tbs2910-u-boot.dtsi

arch/arm/dts/imx6q-tbs2910-u-boot.dtsi new file +211 -0
new file mode 100644
index 0000000000..3e9307f17f
@@ -0,0 +1,219 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * U-Boot specific modifications for original tbs2910 DTS.
+ * This drops not used nodes/properties to reduce the image size.
+ */
+
+/ {
+	/delete-property/ model;
+	/delete-property/ compatible;
+
+	aliases {
+		/delete-property/ can0;
+		/delete-property/ can1;
+		/delete-property/ gpio3;
+		/delete-property/ gpio4;
+		/delete-property/ gpio5;
+		/delete-property/ ipu1;
+		/delete-property/ mmc3;
+		/delete-property/ spi0;
+		/delete-property/ spi1;
+		/delete-property/ spi2;
+		/delete-property/ spi3;
+		/delete-property/ spi4;
+		/delete-property/ serial2;
+		/delete-property/ serial3;
+		/delete-property/ serial4;
+		/delete-property/ video1;
+	};
+
+	/delete-node/ cpus;
+	/delete-node/ capture-subsystem;
+	/delete-node/ chosen;
+	/delete-node/ display-subsystem;
+	/delete-node/ fan;
+	/delete-node/ ir_recv;
+	/delete-node/ leds;
+	/delete-node/ memory;
+	/delete-node/ sound-sgtl5000;
+	/delete-node/ sound-spdif;
+
+	soc {
+		u-boot,dm-pre-reloc;
+		/delete-property/ ranges;
+		/delete-node/ timer at a00600;
+
+		aips-bus at 2000000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 207c000;
+			spba-bus at 2000000 {
+				/delete-property/ ranges;
+				/delete-node/ spba at 203c000;
+			};
+		};
+
+		aips-bus at 2100000 {
+			/delete-property/ ranges;
+			/delete-node/ aipstz at 217c000;
+			/delete-node/ mlb at 218c000;
+			/delete-node/ romcp at 21ac000;
+			/delete-node/ tzasc at 21d0000;
+			/delete-node/ tzasc at 21d4000;
+			/delete-node/ vdoa at 21e4000;
+		};
+	};
+};
+
+&anatop {
+	/delete-node/ regulator-1p1;
+	/delete-node/ regulator-2p5;
+	/delete-node/ regulator-3p0;
+	/delete-node/ regulator-vddcore;
+	/delete-node/ regulator-vddpu;
+	/delete-node/ regulator-vddsoc;
+};
+
+&sata {
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ interrupts;
+	/delete-property/ interrupts;
+	/delete-property/ fsl,transmit-level-mV;
+	/delete-property/ fsl,transmit-boost-mdB;
+	/delete-property/ fsl,transmit-atten-16ths;
+	/delete-property/ fsl,receive-eq-mdB;
+};
+
+&pcie {
+	/delete-property/ reg-names;
+	/delete-property/ device_type;
+	/delete-property/ bus-range;
+	/delete-property/ ranges;
+	/delete-property/ num-lanes;
+	/delete-property/ interrupts;
+	/delete-property/ interrupt-names;
+	/delete-property/ #interrupt-cells;
+	/delete-property/ interrupt-map-mask;
+	/delete-property/ interrupt-map;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+};
+
+&uart1 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+&uart2 {
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ dmas;
+	/delete-property/ dma-names;
+};
+
+/delete-node/ &L2;
+/delete-node/ &asrc;
+/delete-node/ &audmux;
+/delete-node/ &can1;
+/delete-node/ &can2;
+/delete-node/ &crypto;
+/delete-node/ &dcic1;
+/delete-node/ &dcic2;
+/delete-node/ &dma_apbh;
+/delete-node/ &ecspi1;
+/delete-node/ &ecspi2;
+/delete-node/ &ecspi3;
+/delete-node/ &ecspi4;
+/delete-node/ &ecspi5;
+/delete-node/ &epit1;
+/delete-node/ &epit2;
+/delete-node/ &esai;
+/delete-node/ &gpt;
+/delete-node/ &gpio4;
+/delete-node/ &gpio5;
+/delete-node/ &gpio6;
+/delete-node/ &gpu_3d;
+/delete-node/ &gpu_2d;
+/delete-node/ &gpu_vg;
+/delete-node/ &gpmi;
+/delete-node/ &ipu2;
+/delete-node/ &kpp;
+/delete-node/ &ldb;
+/delete-node/ &mipi_csi;
+/delete-node/ &mmdc0;
+/delete-node/ &mmdc1;
+/delete-node/ &ocotp;
+/delete-node/ &ocram;
+/delete-node/ &pinctrl_gpio_fan;
+/delete-node/ &pinctrl_ir;
+/delete-node/ &pinctrl_gpio_leds;
+/delete-node/ &pinctrl_sgtl5000;
+/delete-node/ &pinctrl_spdif;
+/delete-node/ &pmu;
+/delete-node/ &pwm1;
+/delete-node/ &pwm2;
+/delete-node/ &pwm3;
+/delete-node/ &pwm4;
+/delete-node/ &sdma;
+/delete-node/ &reg_2p5v;
+/delete-node/ &sgtl5000;
+/delete-node/ &snvs;
+/delete-node/ &spdif;
+/delete-node/ &src;
+/delete-node/ &ssi1;
+/delete-node/ &ssi2;
+/delete-node/ &ssi3;
+/delete-node/ &tempmon;
+/delete-node/ &uart3;
+/delete-node/ &uart4;
+/delete-node/ &uart5;
+/delete-node/ &usbh2;
+/delete-node/ &usbh3;
+/delete-node/ &usdhc1;
+/delete-node/ &vpu;
+/delete-node/ &wdog2;
+/delete-node/ &weim;
+
+&gpr {
+	/delete-node/ ipu1_csi0_mux;
+	/delete-node/ ipu2_csi1_mux;
+};
+
+&gpc {
+	/delete-node/ pgc;
+};
+
+&hdmi {
+	/delete-node/ port at 2;
+	/delete-node/ port at 3;
+};
+
+&mipi_dsi {
+	ports {
+		/delete-node/ port at 2;
+		/delete-node/ port at 3;
+	};
+};
+
+&ipu1 {
+	u-boot,dm-pre-reloc;
+	/delete-property/ interrupts;
+	/delete-property/ clocks;
+	/delete-property/ clock-names;
+	/delete-property/ resets;
+	/delete-node/ port at 0;
+	/delete-node/ port at 1;
+
+	port at 2 {
Quoted 8 lines

arch/arm/dts/imx6q-tbs2910-u-boot.dtsi line 219

Quoted 8 lines
arch/arm/dts/imx6q-tbs2910-u-boot.dtsi new file +8 -0
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+	port at 3 {
+		/delete-node/ endpoint at 3;
+		/delete-node/ endpoint at 4;
+	};
+};

Oh, most of the deleted properties and nodes are not defined in the board dts, but in the soc dtsi instead.
So for me it would make more sense to also split the "delete dtsi" in a board and soc part, if this really is the way to go.

Quoted 4 lines

This gets an important conversation started. Perhaps we should expand OF_SPL_REMOVE_PROPS for full U-Boot, with some gating symbol for the platforms that do want to pass through the full DT to the OS?

Quoted 9 lines

I also already looked at OF_SPL_REMOVE_PROPS, would make much sense to have this for full u-boot. To duplicate each device tree with an almost identical "delete dtsi" looks like a huge maintenance burden for me.

Maybe the build system can at least automatically remove disabled nodes and nodes without compatible in enabled DM drivers. This would not help for unneeded properties in enabled nodes, but probably automatically give the biggest part of size reduction.

Quoted 4 lines

In an ideal world the firmware and not the operating system would supply the device tree for booting the operating system. Currently for many boards the U-Boot supplied device tree is enough to boot Linux. Deleting nodes not used by U-Boot would not be helpful in this context.

Some boards today ship a DTB file. Some more boards in the future may. Some existing boards might even figure they want to. But, some existing boards will not want to. If at some future point tbs2910 switches to "lets put the DTB on flash somewhere", it will need sorting. But for now this seems like a reasonable path forward for existing hardware.

Quoted 4 lines

Best regards

Heinrich

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20191206/552e191a/attachment.sig>
#5 lore raw

PATCH 1/1 imx: dts: tbs2910: add u-boot dtsi to shrink image size

In reply to Tom Rini

On Fri, 6 Dec 2019 13:43:05 -0500
Tom Rini trini at konsulko.com wrote:
...

Quoted 3 lines

This gets an important conversation started. Perhaps we should expand OF_SPL_REMOVE_PROPS for full U-Boot, with some gating symbol for the platforms that do want to pass through the full DT to the OS?

I've sent patches [1] to add CONFIG_OF_REMOVE_PROPS option.

[1] http://patchwork.ozlabs.org/project/uboot/list/?series=152007

--
Anatolij

#6 lore raw

PATCH 1/1 imx: dts: tbs2910: add u-boot dtsi to shrink image size

Quoted 10 lines · Anatolij Gustschin

On Fri, 6 Dec 2019 13:43:05 -0500
Tom Rini trini at konsulko.com wrote:
...

Quoted 3 lines

This gets an important conversation started. Perhaps we should expand OF_SPL_REMOVE_PROPS for full U-Boot, with some gating symbol for the platforms that do want to pass through the full DT to the OS?

I've sent patches [1] to add CONFIG_OF_REMOVE_PROPS option.

[1] http://patchwork.ozlabs.org/project/uboot/list/?series=152007

Thanks.

Looks good for tbs2910 and clearly is a way in the right direction. However, the (conditional) default value for OF_REMOVE_PROPS could hurt the use case of passing on the whole DT to the OS.

Soeren