Skip to contentSkip to conversation

Add support for Solidrun CEX7 platforms

PATCH Superseded Russell King - ARM Linux admin 3 participants 11 messages Dec 9, 2019 – Dec 23, 2019

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Add support for Solidrun CEX7 platforms

Hi,

This series adds support for the Solidrun Clearfog CX and Honeycomb platforms that various developers have access to.

 arch/arm64/boot/dts/freescale/Makefile             |   2 +
 .../arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi | 123 +++++++++++++++++++++
 .../boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
 .../dts/freescale/fsl-lx2160a-clearfog-itx.dtsi    |  57 ++++++++++
 .../boot/dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi     |  20 ++++
 6 files changed, 232 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#1 lore raw

PATCH 1/2 arm64: dts: lx2160a: add MDIO descriptions

Add MDIO descriptions to the lx2160a dtsi file, so we can use them in the SolidRun Clearfog CX platform.

---
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +20 -0
index 0bd98f179bfa..617e1f1a2339 100644
@@ -863,6 +863,26 @@
 			fsl,extts-fifo;
 		};
 
+		emdio1: mdio@8b96000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b96000 0x00 0x1000>;
+			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+
+		emdio2: mdio@8b97000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b97000 0x00 0x1000>;
+			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+
 		fsl_mc: fsl-mc@80c000000 {
 			compatible = "fsl,qoriq-mc";
 			reg = <0x00000008 0x0c000000 0 0x40>,
Signature · 1 line
2.20.1
#7 lore raw

PATCH 2/2 arm64: dts: lx2160a: add dts for CEX7 platforms

In reply to Russell King - ARM Linux admin

From: Rabeeh Khoury <[email protected]>

The device tree enables the following features -
1. dpmac17 RGMII MAC connected to Atheros AR8035 phy
2. 2x MDIO busses
3. 2x USB 3.0 controllers
4. 4x SATA ports
5. MT35X 512Mb SPI flash
6. Temperature sensor on i2c0 channel 3
7. AMC6821 temperature and PWM fan controller (not fitted)

The module supports AMC6821 PWM controller which is not currently assembled on currently available Com Express 7 hardware.

This commit adds support for the Clearfog CX and Honeycomb variants, which are indentical in this patch, but once QSFP support is finished, only the Clearfog CX will have a QSFP description.

[Add Makefile patch, split into clearfog-cx and honeycomb variants, reworded commit -- rmk]

---
 arch/arm64/boot/dts/freescale/Makefile        |   2 +
 .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 123 ++++++++++++++++++
 .../dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
 .../freescale/fsl-lx2160a-clearfog-itx.dtsi   |  57 ++++++++
 .../dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
 5 files changed, 212 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
arch/arm64/boot/dts/freescale/Makefile +2 -0
index 93fce8f0c66d..b4d696e64625 100644
@@ -18,6 +18,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
 
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +123 -0

123 lines not on this page · raw message

arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts new file +15 -0
new file mode 100644
index 000000000000..86a9b771428d
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Clearfog CX board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Clearfog CX";
+	compatible = "solidrun,clearfog-cx",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi new file +57 -0

57 lines not on this page · raw message

arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts new file +15 -0
new file mode 100644
index 000000000000..fe19f3009ea5
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Honeycomb board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Honeycomb";
+	compatible = "solidrun,honeycomb",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
Signature · 1 line
2.20.1
#2 lore raw

Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions

In reply to Russell King
Quoted 26 lines · Russell King

Add MDIO descriptions to the lx2160a dtsi file, so we can use them in the SolidRun Clearfog CX platform.

---
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +10 -0
index 0bd98f179bfa..617e1f1a2339 100644
@@ -863,6 +863,26 @@
 			fsl,extts-fifo;
 		};
 
+		emdio1: mdio@8b96000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b96000 0x00 0x1000>;
+			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 885

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +10 -0
+		emdio2: mdio@8b97000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b97000 0x00 0x1000>;
+			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+

Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately, emdio2 was missing from there.

Shawn

[1] https://lkml.org/lkml/2019/12/4/675

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +0 -0
 		fsl_mc: fsl-mc@80c000000 {
 			compatible = "fsl,qoriq-mc";
 			reg = <0x00000008 0x0c000000 0 0x40>,
Signature · 1 line
2.20.1
#8 lore raw

Re: [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms

In reply to Russell King
Quoted 56 lines · Russell King

From: Rabeeh Khoury <[email protected]>

The device tree enables the following features -
1. dpmac17 RGMII MAC connected to Atheros AR8035 phy
2. 2x MDIO busses
3. 2x USB 3.0 controllers
4. 4x SATA ports
5. MT35X 512Mb SPI flash
6. Temperature sensor on i2c0 channel 3
7. AMC6821 temperature and PWM fan controller (not fitted)

The module supports AMC6821 PWM controller which is not currently assembled on currently available Com Express 7 hardware.

This commit adds support for the Clearfog CX and Honeycomb variants, which are indentical in this patch, but once QSFP support is finished, only the Clearfog CX will have a QSFP description.

[Add Makefile patch, split into clearfog-cx and honeycomb variants, reworded commit -- rmk]

---
 arch/arm64/boot/dts/freescale/Makefile        |   2 +
 .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 123 ++++++++++++++++++
 .../dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
 .../freescale/fsl-lx2160a-clearfog-itx.dtsi   |  57 ++++++++
 .../dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
 5 files changed, 212 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
arch/arm64/boot/dts/freescale/Makefile +2 -0
index 93fce8f0c66d..b4d696e64625 100644
@@ -18,6 +18,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
 
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +3 -0
new file mode 100644
index 000000000000..4761737e62e2
@@ -0,0 +1,123 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A-CEx7

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 13

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +10 -0
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a.dtsi"
+
+/ {
+	model = "SolidRun LX2160A COM Express Type 7 module";
+	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";

Any new compatible needs to be documented.

Quoted 29 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +29 -0
+
+	aliases {
+		crypto = &crypto;
+	};
+
+	sb_3v3: regulator-sb3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "RT7290";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+};
+
+&crypto {
+	status = "okay";
+};
+
+&esdhc1 {
+	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
+	bus-width = <8>;
+	status = "okay";
+};
+
+&i2c0 {
+	status = "okay";
+

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 52

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +10 -0
+	i2c-switch@77 {
+		compatible = "nxp,pca9547";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x77>;
+
+		i2c@1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;

As an idiomatic practice, we have a newline between properties and child node ...

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 60

Quoted 8 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +8 -0
+			fan-temperature-ctrlr@18 {
+				compatible = "ti,amc6821";
+				reg = <0x18>;
+				cooling-min-state = <0>;
+				cooling-max-state = <9>;
+				#cooling-cells = <2>;
+			};
+		};

... and in between nodes.

Quoted 21 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +21 -0
+		i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+
+			temperature-sensor@48 {
+				compatible = "nxp,sa56004";
+				reg = <0x48>;
+				vcc-supply = <&sb_3v3>;
+			};
+		};
+	};
+};
+
+&i2c2 {
+	status = "okay";
+};
+
+&i2c4 {
+	status = "okay";
+

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 91

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +10 -0
+	rtc@51 {
+		compatible = "nxp,pcf2129";
+		reg = <0x51>;
+		// IRQ10_B
+		interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
+	};
+};
+
+&fspi {
+	status = "okay";

Ditto

Quoted 13 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +13 -0
+	flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "micron,m25p80";
+		m25p,fast-read;
+		spi-max-frequency = <50000000>;
+		reg = <0>;
+		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+		spi-rx-bus-width = <8>;
+		spi-tx-bus-width = <1>;
+	};
+};
+

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 114

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +10 -0
+&usb0 {
+	status = "okay";
+};
+
+&usb1 {
+	status = "okay";
+};
+
+&emdio1 {
+	status = "okay";

Ditto

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 120

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +6 -0
+	rgmii_phy1: ethernet-phy@1 {
+		reg = <1>;
+	};
+};
+
+&dpmac17 {

Instead of putting labeled nodes arbitrarily, we want to keep them sorted alphabetically.

Shawn

Quoted 111 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +3 -0
+	phy-handle = <&rgmii_phy1>;
+	phy-connection-type = "rgmii-id";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts new file +15 -0
new file mode 100644
index 000000000000..86a9b771428d
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Clearfog CX board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Clearfog CX";
+	compatible = "solidrun,clearfog-cx",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi new file +57 -0
new file mode 100644
index 000000000000..10541f1345bf
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Clearfog ITX board; this contains the
+// common parts shared between the Clearfog CX and Honeycomb builds.
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-cex7.dtsi"
+
+/ {
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&esdhc0 {
+	sd-uhs-sdr104;
+	sd-uhs-sdr50;
+	sd-uhs-sdr25;
+	sd-uhs-sdr12;
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&emdio2 {
+	status = "okay";
+};
+
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts new file +15 -0
new file mode 100644
index 000000000000..fe19f3009ea5
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Honeycomb board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Honeycomb";
+	compatible = "solidrun,honeycomb",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
Signature · 1 line
2.20.1
#9 lore raw

Re: [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms

Quoted 61 lines · Shawn Guo
Quoted 60 lines · Russell King

From: Rabeeh Khoury <[email protected]>

The device tree enables the following features -
1. dpmac17 RGMII MAC connected to Atheros AR8035 phy
2. 2x MDIO busses
3. 2x USB 3.0 controllers
4. 4x SATA ports
5. MT35X 512Mb SPI flash
6. Temperature sensor on i2c0 channel 3
7. AMC6821 temperature and PWM fan controller (not fitted)

The module supports AMC6821 PWM controller which is not currently assembled on currently available Com Express 7 hardware.

This commit adds support for the Clearfog CX and Honeycomb variants, which are indentical in this patch, but once QSFP support is finished, only the Clearfog CX will have a QSFP description.

[Add Makefile patch, split into clearfog-cx and honeycomb variants, reworded commit -- rmk]

---
 arch/arm64/boot/dts/freescale/Makefile        |   2 +
 .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 123 ++++++++++++++++++
 .../dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
 .../freescale/fsl-lx2160a-clearfog-itx.dtsi   |  57 ++++++++
 .../dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
 5 files changed, 212 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
arch/arm64/boot/dts/freescale/Makefile +2 -0
index 93fce8f0c66d..b4d696e64625 100644
@@ -18,6 +18,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
 
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +7 -0
new file mode 100644
index 000000000000..4761737e62e2
@@ -0,0 +1,123 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A-CEx7
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
Quoted 8 lines

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 13

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +6 -0
+
+#include "fsl-lx2160a.dtsi"
+
+/ {
+	model = "SolidRun LX2160A COM Express Type 7 module";
+	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";

Any new compatible needs to be documented.

Grepping for "lx2160a-qds" and "lx2160a-rdb" in that tree shows no matches. Maybe all lx2160a boards should be documented together when a place for such documentation is decided upon. (In other words, no, I'm not going to do as you requested until the existing boards are given the same treatment you're requesting - otherwise it's unfair.)

Quoted 238 lines
Quoted 29 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +29 -0
+
+	aliases {
+		crypto = &crypto;
+	};
+
+	sb_3v3: regulator-sb3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "RT7290";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+};
+
+&crypto {
+	status = "okay";
+};
+
+&esdhc1 {
+	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
+	bus-width = <8>;
+	status = "okay";
+};
+
+&i2c0 {
+	status = "okay";
+

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 52

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +10 -0
+	i2c-switch@77 {
+		compatible = "nxp,pca9547";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x77>;
+
+		i2c@1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;

As an idiomatic practice, we have a newline between properties and child node ...

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 60

Quoted 8 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +8 -0
+			fan-temperature-ctrlr@18 {
+				compatible = "ti,amc6821";
+				reg = <0x18>;
+				cooling-min-state = <0>;
+				cooling-max-state = <9>;
+				#cooling-cells = <2>;
+			};
+		};

... and in between nodes.

Quoted 21 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +21 -0
+		i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+
+			temperature-sensor@48 {
+				compatible = "nxp,sa56004";
+				reg = <0x48>;
+				vcc-supply = <&sb_3v3>;
+			};
+		};
+	};
+};
+
+&i2c2 {
+	status = "okay";
+};
+
+&i2c4 {
+	status = "okay";
+

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 91

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +10 -0
+	rtc@51 {
+		compatible = "nxp,pcf2129";
+		reg = <0x51>;
+		// IRQ10_B
+		interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
+	};
+};
+
+&fspi {
+	status = "okay";

Ditto

Quoted 13 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +13 -0
+	flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "micron,m25p80";
+		m25p,fast-read;
+		spi-max-frequency = <50000000>;
+		reg = <0>;
+		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+		spi-rx-bus-width = <8>;
+		spi-tx-bus-width = <1>;
+	};
+};
+

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 114

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +10 -0
+&usb0 {
+	status = "okay";
+};
+
+&usb1 {
+	status = "okay";
+};
+
+&emdio1 {
+	status = "okay";

Ditto

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 120

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +6 -0
+	rgmii_phy1: ethernet-phy@1 {
+		reg = <1>;
+	};
+};
+
+&dpmac17 {

Instead of putting labeled nodes arbitrarily, we want to keep them sorted alphabetically.

Shawn

Quoted 111 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +3 -0
+	phy-handle = <&rgmii_phy1>;
+	phy-connection-type = "rgmii-id";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts new file +15 -0
new file mode 100644
index 000000000000..86a9b771428d
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Clearfog CX board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Clearfog CX";
+	compatible = "solidrun,clearfog-cx",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi new file +57 -0
new file mode 100644
index 000000000000..10541f1345bf
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Clearfog ITX board; this contains the
+// common parts shared between the Clearfog CX and Honeycomb builds.
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-cex7.dtsi"
+
+/ {
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&esdhc0 {
+	sd-uhs-sdr104;
+	sd-uhs-sdr50;
+	sd-uhs-sdr25;
+	sd-uhs-sdr12;
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&emdio2 {
+	status = "okay";
+};
+
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts new file +15 -0
new file mode 100644
index 000000000000..fe19f3009ea5
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Honeycomb board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Honeycomb";
+	compatible = "solidrun,honeycomb",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
Signature · 1 line
2.20.1
Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#3 lore raw

Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions

In reply to Shawn Guo
Quoted 41 lines · Shawn Guo
Quoted 26 lines · Russell King

Add MDIO descriptions to the lx2160a dtsi file, so we can use them in the SolidRun Clearfog CX platform.

---
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +10 -0
index 0bd98f179bfa..617e1f1a2339 100644
@@ -863,6 +863,26 @@
 			fsl,extts-fifo;
 		};
 
+		emdio1: mdio@8b96000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b96000 0x00 0x1000>;
+			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 885

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +10 -0
+		emdio2: mdio@8b97000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b97000 0x00 0x1000>;
+			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+

Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately, emdio2 was missing from there.

Quoted 3 lines

Shawn

[1] https://lkml.org/lkml/2019/12/4/675

Okay, I'll wait until after the next merge window before resubmitting. Thanks.

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#4 lore raw

Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions

Quoted 42 lines · Russell King - ARM Linux admin
Quoted 41 lines · Shawn Guo
Quoted 26 lines · Russell King

Add MDIO descriptions to the lx2160a dtsi file, so we can use them in the SolidRun Clearfog CX platform.

---
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +10 -0
index 0bd98f179bfa..617e1f1a2339 100644
@@ -863,6 +863,26 @@
 			fsl,extts-fifo;
 		};
 
+		emdio1: mdio@8b96000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b96000 0x00 0x1000>;
+			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 885

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +10 -0
+		emdio2: mdio@8b97000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b97000 0x00 0x1000>;
+			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+

Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately, emdio2 was missing from there.

Quoted 6 lines
Quoted 3 lines

Shawn

[1] https://lkml.org/lkml/2019/12/4/675

Okay, I'll wait until after the next merge window before resubmitting. Thanks.

Just to be clear: the reasons are:
1) Ioana's patch was _not_ copied to linux-arm-kernel as it should have been.
2) I can't download the patch off lkml.org to sanely rebase on top of it
3) I'm not hunting around to try and find it on another archive site
4) I'm not digging about in random git trees trying to find it.

This makes it unnecessarily difficult to progress these patches.

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#5 lore raw

Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions

Quoted 50 lines · Russell King - ARM Linux admin
Quoted 42 lines · Russell King - ARM Linux admin
Quoted 41 lines · Shawn Guo
Quoted 26 lines · Russell King

Add MDIO descriptions to the lx2160a dtsi file, so we can use them in the SolidRun Clearfog CX platform.

---
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +10 -0
index 0bd98f179bfa..617e1f1a2339 100644
@@ -863,6 +863,26 @@
 			fsl,extts-fifo;
 		};
 
+		emdio1: mdio@8b96000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b96000 0x00 0x1000>;
+			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+

arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi line 885

Quoted 10 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +10 -0
+		emdio2: mdio@8b97000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b97000 0x00 0x1000>;
+			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+

Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately, emdio2 was missing from there.

Quoted 6 lines
Quoted 3 lines

Shawn

[1] https://lkml.org/lkml/2019/12/4/675

Okay, I'll wait until after the next merge window before resubmitting. Thanks.

Quoted 8 lines

Just to be clear: the reasons are:
1) Ioana's patch was _not_ copied to linux-arm-kernel as it should have been.
2) I can't download the patch off lkml.org to sanely rebase on top of it
3) I'm not hunting around to try and find it on another archive site
4) I'm not digging about in random git trees trying to find it.

This makes it unnecessarily difficult to progress these patches.

Okay, I finally found it at:

https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/patch/?id=6e1b8fae892daa7ffb48570264b8e43b3f807e9a

Note that that was unnecessarily difficult - google was unable to find it. Ioana's patch should have been copied to linux-arm-kernel as per MAINTAINERS, but wasn't. Is copying the appropriate mailing lists for a patch now optional?

Signature · 3 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
#6 lore raw

Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions

Quoted 8 lines · Russell King - ARM Linux admin

Okay, I finally found it at:

https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/patch/?id=6e1b8fae892daa7ffb48570264b8e43b3f807e9a

Note that that was unnecessarily difficult - google was unable to find it. Ioana's patch should have been copied to linux-arm-kernel as per MAINTAINERS, but wasn't. Is copying the appropriate mailing lists for a patch now optional?

Absolutely no. I will remind people to copy appropriate mailing lists when sending patches. Sorry.

Shawn

#10 lore raw

Re: [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms

In reply to Russell King - ARM Linux admin
Quoted 22 lines · Russell King - ARM Linux admin
Quoted 13 lines
Quoted 13 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +7 -0
new file mode 100644
index 000000000000..4761737e62e2
@@ -0,0 +1,123 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A-CEx7
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
Quoted 8 lines

arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi line 13

Quoted 6 lines
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi new file +6 -0
+
+#include "fsl-lx2160a.dtsi"
+
+/ {
+	model = "SolidRun LX2160A COM Express Type 7 module";
+	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";

Any new compatible needs to be documented.

Quoted 6 lines

Grepping for "lx2160a-qds" and "lx2160a-rdb" in that tree shows no matches. Maybe all lx2160a boards should be documented together when a place for such documentation is decided upon. (In other words, no, I'm not going to do as you requested until the existing boards are given the same treatment you're requesting - otherwise it's unfair.)

Okay, I will create a patch to document "lx2160a-qds" and "lx2160a-rdb".

Shawn