Skip to contentSkip to conversation

librsync: new package

PATCH In review Bartosz Golaszewski 2 participants 4 messages Dec 9, 2019 – Dec 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 librsync: new package

From: Bartosz Golaszewski <[email protected]>

rdiff is a popular tool for calculating binary delta patches. It's provided by the librsync package (unrelated to rsync already available in poky).

This recipe adds new packages for librsync and rdiff.

---
 .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +18 -0
new file mode 100644
index 000000000..9d224767c
@@ -0,0 +1,18 @@
+SUMMARY = "Remote delta-compression library."
+AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert"
+
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499"
+
+SRC_URI = "git://github.com/librsync/librsync.git"
+SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d"
+S = "${WORKDIR}/git"
+
+DEPENDS = "popt"
+
+inherit cmake
+
+BBCLASSEXTEND = "native nativesdk"
+
+PACKAGES =+ "rdiff"
+FILES_rdiff = "/usr/bin/rdiff"
Signature · 1 line
2.23.0
#1 lore raw
Quoted 29 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

rdiff is a popular tool for calculating binary delta patches. It's provided by the librsync package (unrelated to rsync already available in poky).

This recipe adds new packages for librsync and rdiff.

---
 .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +8 -0
new file mode 100644
index 000000000..9d224767c
@@ -0,0 +1,18 @@
+SUMMARY = "Remote delta-compression library."
+AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert"
+
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499"
+
+SRC_URI = "git://github.com/librsync/librsync.git"
+SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d"

meta-oe/recipes-support/librsync/librsync_2.2.1.bb line 18

Quoted 10 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +10 -0
+S = "${WORKDIR}/git"
+
+DEPENDS = "popt"
+
+inherit cmake
+
+BBCLASSEXTEND = "native nativesdk"
+
+PACKAGES =+ "rdiff"
+FILES_rdiff = "/usr/bin/rdiff"

Please use ${bindir} instead of /usr/bin

Quoted 3 lines

--
2.23.0

#2 lore raw

pon., 9 gru 2019 o 20:24 Khem Raj <[email protected]> napisał(a):

Quoted 35 lines · Bartosz Golaszewski
Quoted 33 lines

From: Bartosz Golaszewski <[email protected]>

rdiff is a popular tool for calculating binary delta patches. It's provided by the librsync package (unrelated to rsync already available in poky).

This recipe adds new packages for librsync and rdiff.

---
 .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +12 -0
new file mode 100644
index 000000000..9d224767c
@@ -0,0 +1,18 @@
+SUMMARY = "Remote delta-compression library."
+AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert"
+
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499"
+
+SRC_URI = "git://github.com/librsync/librsync.git"
+SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d"
+S = "${WORKDIR}/git"
+
+DEPENDS = "popt"
+
Quoted 9 lines

meta-oe/recipes-support/librsync/librsync_2.2.1.bb line 18

Quoted 6 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +6 -0
+inherit cmake
+
+BBCLASSEXTEND = "native nativesdk"
+
+PACKAGES =+ "rdiff"
+FILES_rdiff = "/usr/bin/rdiff"

Please use ${bindir} instead of /usr/bin

Will do.

While at it: I noticed another problem and I'm not sure how to approach it: the recipe provides the librsync package as well as librsync-native by using BBCLASSEXTEND = "native". We also use PACKAGES = "rdiff" to provide the rdiff executable in a separate package, but it doesn't seem to provide the native package for rdiff automatically. What is the right way to provide librsync, librsync-native, rdiff and rdiff-native here?

This is needed as native rdiff will be used to actually create the delta update images in the system I'm working on.

Thanks in advance,
Bartosz Golaszewski

Quoted 3 lines
Quoted 3 lines

--
2.23.0

#3 lore raw
Quoted 60 lines · Bartosz Golaszewski

pon., 9 gru 2019 o 20:24 Khem Raj <[email protected]> napisał(a):

Quoted 2 lines

On Mon, Dec 9, 2019 at 6:45 AM Bartosz Golaszewski <[email protected]>

Quoted 7 lines · wrote:
Quoted 7 lines

From: Bartosz Golaszewski <[email protected]>

rdiff is a popular tool for calculating binary delta patches. It's provided by the librsync package (unrelated to rsync already available in poky).

Quoted 5 lines
Quoted 5 lines

This recipe adds new packages for librsync and rdiff.

---
 .../recipes-support/librsync/librsync_2.2.1.bb | 18

++++++++++++++++++

Quoted 4 lines

Review

Quoted 4 lines
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb
(quoted diff) +0 -0

b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb

Quoted 10 lines

meta-oe/recipes-support/librsync/librsync_2.2.1.bb line 5

Quoted 10 lines

new file mode 100644
index 000000000..9d224767c

meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +5 -0
@@ -0,0 +1,18 @@
+SUMMARY = "Remote delta-compression library."
+AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert"
+
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM =

"file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499"

Quoted 7 lines
Quoted 7 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +7 -0
+
+SRC_URI = "git://github.com/librsync/librsync.git"
+SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d"
+S = "${WORKDIR}/git"
+
+DEPENDS = "popt"
+
Quoted 9 lines

meta-oe/recipes-support/librsync/librsync_2.2.1.bb line 18

Quoted 6 lines
meta-oe/recipes-support/librsync/librsync_2.2.1.bb new file +6 -0
+inherit cmake
+
+BBCLASSEXTEND = "native nativesdk"
+
+PACKAGES =+ "rdiff"
+FILES_rdiff = "/usr/bin/rdiff"

Please use ${bindir} instead of /usr/bin

Will do.

While at it: I noticed another problem and I'm not sure how to approach it: the recipe provides the librsync package as well as librsync-native by using BBCLASSEXTEND = "native". We also use PACKAGES = "rdiff" to provide the rdiff executable in a separate package, but it doesn't seem to provide the native package for rdiff automatically. What is the right way to provide librsync, librsync-native, rdiff and rdiff-native here?

Quoted 3 lines

This is needed as native rdiff will be used to actually create the delta update images in the system I'm working on.

Use librsync-native

Quoted 8 lines

Thanks in advance,
Bartosz Golaszewski

Quoted 3 lines
Quoted 3 lines

--
2.23.0