Fix a compiler warning triggered by the SCSI logging code
PATCH 1/1 Fix a compiler warning triggered by the SCSI logging code
This patch fixes the following compiler warning:
In file included from drivers/scsi/scsi_error.c:46:drivers/scsi/scsi_error.c: In function 'scsi_eh_target_reset':drivers/scsi/scsi_logging.h:65:81: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
65 | LOGGING(SCSI_LOG_ERROR_SHIFT, SCSI_LOG_ERROR_BITS, LEVEL,CMD);
| ^
drivers/scsi/scsi_error.c:1562:4: note: in expansion of macro 'SCSI_LOG_ERROR_RECOVERY'
1562 | SCSI_LOG_ERROR_RECOVERY(3,
| ^~~~~~~~~~~~~~~~~~~~~~~--- drivers/scsi/scsi_logging.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/scsi_logging.h +1 -1
@@ -53,7 +53,7 @@ do { \ } while (0)#else #define SCSI_LOG_LEVEL (SHIFT ,BITS ) 0 -#define SCSI_CHECK_LOGGING (SHIFT ,BITS ,LEVEL ,CMD ) +#define SCSI_CHECK_LOGGING (SHIFT ,BITS ,LEVEL ,CMD ) do { } while (0)#endif /* CONFIG_SCSI_LOGGING */ /*
Martin K. Petersen
AppliedBart,
Quoted 7 lines
This patch fixes the following compiler warning:
In file included from
drivers/scsi/scsi_error.c:46:drivers/scsi/scsi_error.c: In function 'scsi_eh_target_reset':drivers/scsi/scsi_logging.h:65:81: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
65 |LOGGING(SCSI_LOG_ERROR_SHIFT, SCSI_LOG_ERROR_BITS, LEVEL,CMD);
| ^
Applied to 5.6/scsi-queue, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering