cros_ec: use uint instead of uint8_t for cmd param
Subsystems (2)
PATCH 1/1 cros_ec: use uint instead of uint8_t for cmd param
Chromium EC commands can be up to 16-bits, so using a uint8_t here can cause truncation. Update to use a uint instead.
It looks like this should likely have been done as a part of 9fea76f5d30264dc08ac591a7a89427b8441555b, but this function was skipped for some reason.
Signed-off-by Michael Auchter <[email protected]>
Cc Simon Glass <[email protected]>
--- drivers/misc/cros_ec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/cros_ec.c +1 -1
@@ -316,7 +316,7 @@ static int send_command(struct cros_ec_dev *dev, uint cmd, int cmd_version,* @param din_len Maximum size of response in bytes * @return number of bytes in response, or -ve on error */ -static int ec_command_inptr (struct udevice *dev,uint8_t cmd, +static int ec_command_inptr (struct udevice *dev,uint cmd,int cmd_version,const void *dout,int dout_len,uint8_t **dinp,int din_len) {
Signature · 1 line
2.23.0
PATCH 1/1 cros_ec: use uint instead of uint8_t for cmd param
Quoted 8 lines · Michael Auchter
Chromium EC commands can be up to 16-bits, so using a
uint8_there can cause truncation. Update to use a uint instead.It looks like this should likely have been done as a part of
9fea76f5d30264dc08ac591a7a89427b8441555b, but this function was skipped for some reason.
Quoted 5 lines
Signed-off-by Michael Auchter <[email protected]>Cc Simon Glass <[email protected]>--- drivers/misc/cros_ec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by Simon Glass <[email protected]>