Skip to contentSkip to conversation

drm: msm: mdp4: Adjust indentation in mdp4_dsi_encoder_enable

PATCH In review Nathan Chancellor 2 participants 2 messages Dec 9, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: msm: mdp4: Adjust indentation in mdp4_dsi_encoder_enable

Clang warns:

../drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:124:3: warning:
misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         mdp4_crtc_set_config(encoder->crtc,
         ^
../drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:121:2: note:
previous statement is here
        if (mdp4_dsi_encoder->enabled)
        ^

This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.

Fixes 776638e73a19 ("drm/msm/dsi: Add a mdp4 encoder for DSI")
---
 drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c +1 -1
index 772f0753ed38..aaf2f26f8505 100644
@@ -121,7 +121,7 @@ static void mdp4_dsi_encoder_enable(struct drm_encoder *encoder)
 	if (mdp4_dsi_encoder->enabled)
 		return;
 
-	 mdp4_crtc_set_config(encoder->crtc,
+	mdp4_crtc_set_config(encoder->crtc,
 			MDP4_DMA_CONFIG_PACK_ALIGN_MSB |
 			MDP4_DMA_CONFIG_DEFLKR_EN |
 			MDP4_DMA_CONFIG_DITHER_EN |
Signature · 1 line
2.24.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Nathan Chancellor

Clang warns:

../drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:124:3: warning:
misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]

         mdp4_crtc_set_config(encoder->crtc,
         ^
../drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c:121:2: note:
previous statement is here
        if (mdp4_dsi_encoder->enabled)
        ^
Quoted 3 lines

This warning occurs because there is a space after the tab on this line. Remove it so that the indentation is consistent with the Linux kernel coding style and clang no longer warns.

Thanks for the cleanup. Nothing to see here, but should help us find more interesting cases.

(If there are other instances in drivers/gpu/drm/msm, they should be rolled up into this commit)

Quoted 28 lines
Fixes 776638e73a19 ("drm/msm/dsi: Add a mdp4 encoder for DSI")
---
 drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/msm/disp/mdp4/mdp4_dsi_encoder.c +1 -2
index 772f0753ed38..aaf2f26f8505 100644
@@ -121,7 +121,7 @@ static void mdp4_dsi_encoder_enable(struct drm_encoder *encoder)
        if (mdp4_dsi_encoder->enabled)
                return;
 
-        mdp4_crtc_set_config(encoder->crtc,
+       mdp4_crtc_set_config(encoder->crtc,
                        MDP4_DMA_CONFIG_PACK_ALIGN_MSB |
                        MDP4_DMA_CONFIG_DEFLKR_EN |
                        MDP4_DMA_CONFIG_DITHER_EN |
--

2.24.0

--
You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20191209203230.1593-1-natechancellor%40gmail.com.

Signature · 2 lines
Thanks,
~Nick Desaulniers