Skip to contentSkip to conversation

eap-gtc: Try to auth even if request not Password

PATCH In review xdavidwu 2 participants 4 messages Dec 11, 2019 – Dec 12, 2019

lore
Share & tools
lore

xdavidwu

author
#0 lore raw

PATCH 1/1 eap-gtc: Try to auth even if request not Password

There are some server implementations that send requests that are not "Password" but still want us send password. This commit modify the behavior to send a warning and still try to auth with password.

This makes me able to auth with server in my school which sends "Enter Aruba Login".

wpa_supplicant does not check if it is "Password".

---
 src/eap-gtc.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
src/eap-gtc.c +3 -9
index 9302257e..7788d44c 100644
@@ -56,11 +56,9 @@ static void eap_gtc_handle_request(struct eap_state *eap,
 	size_t secret_len = strlen(gtc->password);
 	uint8_t response[5 + secret_len];
 
-	if (len < 8)
-		goto error;
-
-	if (strncmp((const char *)pkt, "Password", 8))
-		goto error;
+	if (len < 8 || strncmp((const char *)pkt, "Password", 8))
+		l_warn("GTC request not understood, proceeding anyway: %.*s",
+				(int) len, (const char *) pkt);
 
 	memcpy(response + 5, gtc->password, secret_len);
 
@@ -69,10 +67,6 @@ static void eap_gtc_handle_request(struct eap_state *eap,
 	eap_method_success(eap);
 
 	return;
-
-error:
-	l_error("invalid GTC request");
-	eap_method_error(eap);
 }
 
 static int eap_gtc_check_settings(struct l_settings *settings,
Signature · 1 line
2.24.1
#1 lore raw

Hi,

Quoted 4 lines · xdavidwu

There are some server implementations that send requests that are not "Password" but still want us send password. This commit modify the behavior to send a warning and still try to auth with password.

Quoted 8 lines

This makes me able to auth with server in my school which sends "Enter Aruba Login".

wpa_supplicant does not check if it is "Password".

---
  src/eap-gtc.c | 12 +++---------
  1 file changed, 3 insertions(+), 9 deletions(-)

Thanks for the patch. Looks good. Any chance you can resubmit with your real name as the author info so I can apply this? While we don't use Signed-off-by, our expectation for submissions are similar to [1], including the real name requirement.

[1]
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Regards,
-Denis

author
#2 lore raw

PATCH 1/1 eap-gtc: Try to auth even if request not Password

There are some server implementations that send requests that are not "Password" but still want us send password. This commit modify the behavior to send a warning and still try to auth with password.

This makes me able to auth with server in my school which sends "Enter Aruba Login".

wpa_supplicant does not check if it is "Password".

---
 src/eap-gtc.c | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)
src/eap-gtc.c +3 -9
index 9302257e..7788d44c 100644
@@ -56,11 +56,9 @@ static void eap_gtc_handle_request(struct eap_state *eap,
 	size_t secret_len = strlen(gtc->password);
 	uint8_t response[5 + secret_len];
 
-	if (len < 8)
-		goto error;
-
-	if (strncmp((const char *)pkt, "Password", 8))
-		goto error;
+	if (len < 8 || strncmp((const char *)pkt, "Password", 8))
+		l_warn("GTC request not understood, proceeding anyway: %.*s",
+				(int) len, (const char *) pkt);
 
 	memcpy(response + 5, gtc->password, secret_len);
 
@@ -69,10 +67,6 @@ static void eap_gtc_handle_request(struct eap_state *eap,
 	eap_method_success(eap);
 
 	return;
-
-error:
-	l_error("invalid GTC request");
-	eap_method_error(eap);
 }
 
 static int eap_gtc_check_settings(struct l_settings *settings,
Signature · 1 line
2.24.1
#3 lore raw

Hi Pinghao,

Quoted 4 lines · Pinghao Wu

There are some server implementations that send requests that are not "Password" but still want us send password. This commit modify the behavior to send a warning and still try to auth with password.

Quoted 8 lines

This makes me able to auth with server in my school which sends "Enter Aruba Login".

wpa_supplicant does not check if it is "Password".

---
  src/eap-gtc.c | 12 +++---------
  1 file changed, 3 insertions(+), 9 deletions(-)

Applied, thanks.

Regards,
-Denis