Skip to contentSkip to conversation

imx8mq_evk: Update the required ATF branch

PATCH New Fabio Estevam 7 participants 17 messages Dec 11, 2019 – Apr 21, 2020 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

Following the README instructions leads to a non-booting U-Boot:

U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
PMIC: PFUZE100 ID=0x10
DDRINFO: start DRAM init
DDRINFO:ddrphy calibration done
DDRINFO: ddrmix config done
Normal Boot
Trying to boot from MMC2

(It hangs here)

Use the "imx_4.19.35_1.0.0" ATF branch instead, which fixes such problem and allow the boot to complete again.

---
 board/freescale/imx8mq_evk/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/imx8mq_evk/README +1 -1
index c1d400bcf9..4f671b069c 100644
@@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware
 ======================================
 Note: srctree is U-Boot source directory
 Get ATF from: https://source.codeaurora.org/external/imx/imx-atf
-branch: imx_4.14.62_1.0.0_beta
+branch: imx_4.19.35_1.0.0
 $ make PLAT=imx8mq bl31
 $ cp build/imx8mq/release/bl31.bin $(srctree)
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

Quoted 12 lines · Fabio Estevam

Following the README instructions leads to a non-booting U-Boot:

U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
PMIC: PFUZE100 ID=0x10
DDRINFO: start DRAM init
DDRINFO:ddrphy calibration done
DDRINFO: ddrmix config done
Normal Boot
Trying to boot from MMC2

Quoted 4 lines

(It hangs here)

Use the "imx_4.19.35_1.0.0" ATF branch instead, which fixes such problem and allow the boot to complete again.

Shouldn't we address the mix-match of the firmware-imx versions as well?

I just increasing numbers over and over, and I was able to use firmware 8.5 which.

The readme lists both 7.9 and 8.0. There is also a typo on the line that reads "./firmware-imx-8.0" which should have a .bin appended to it.

It would nice to know what the differences are between the versions.

adam

Quoted 23 lines
---
 board/freescale/imx8mq_evk/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/imx8mq_evk/README +1 -2
index c1d400bcf9..4f671b069c 100644
@@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware
 ======================================
 Note: srctree is U-Boot source directory
 Get ATF from: https://source.codeaurora.org/external/imx/imx-atf
-branch: imx_4.14.62_1.0.0_beta
+branch: imx_4.19.35_1.0.0
 $ make PLAT=imx8mq bl31
 $ cp build/imx8mq/release/bl31.bin $(srctree)
 
--

2.17.1

#2 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

Quoted 21 lines

Subject: Re: [PATCH] imx8mq_evk: Update the required ATF branch

Quoted 17 lines · Fabio Estevam

Following the README instructions leads to a non-booting U-Boot:

U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
PMIC: PFUZE100 ID=0x10
DDRINFO: start DRAM init
DDRINFO:ddrphy calibration done
DDRINFO: ddrmix config done
Normal Boot
Trying to boot from MMC2

(It hangs here)

Use the "imx_4.19.35_1.0.0" ATF branch instead, which fixes such problem and allow the boot to complete again.

We might need to switch upstream ATF, or stick to NXP vendor release one?

Quoted 10 lines

Shouldn't we address the mix-match of the firmware-imx versions as well?

I just increasing numbers over and over, and I was able to use firmware 8.5 which.

The readme lists both 7.9 and 8.0. There is also a typo on the line that reads "./firmware-imx-8.0" which should have a .bin appended to it.

It would nice to know what the differences are between the versions.

The version should already be in yocto release. I just use the new one when I upstream code.

Thanks,
Peng.

Quoted 36 lines

adam

Quoted 13 lines
---
 board/freescale/imx8mq_evk/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/imx8mq_evk/README +0 -0
index c1d400bcf9..4f671b069c 100644
@@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware
Quoted 4 lines

======================================
Note: srctree is U-Boot source directory Get ATF from:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour

ce.codeaurora.org%2Fexternal%2Fimx%2Fimx-atf&data=02%7C01%7Cp eng.f

Quoted 1 line

an%40nxp.com%7C56fbd5d0b17c4949cc1708d77e41f5c5%7C686ea1d3bc2b 4c6fa92c

Quoted 1 line

d99c5c301635%7C0%7C0%7C637116694069333717&sdata=PxZh7ldsxb %2FxZK7c

Quoted 9 lines

J5OpJxblskZJkHZHuXvMqGQC5H4%3D&reserved=0

board/freescale/imx8mq_evk/README +1 -2
-branch: imx_4.14.62_1.0.0_beta
+branch: imx_4.19.35_1.0.0
 $ make PLAT=imx8mq bl31
 $ cp build/imx8mq/release/bl31.bin $(srctree)
 
--

2.17.1

author reviewer
#14 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

In reply to Adam Ford

Hi Adam,

Quoted 8 lines · Adam Ford

Shouldn't we address the mix-match of the firmware-imx versions as well?

I just increasing numbers over and over, and I was able to use firmware 8.5 which.

The readme lists both 7.9 and 8.0. There is also a typo on the line that reads "./firmware-imx-8.0" which should have a .bin appended to it.

This error comes from the imx8mm-evk README. I am patching imx8mq-evk README instead.

Quoted 1 line

It would nice to know what the differences are between the versions.

Yes, it is becoming painful to find the exact combination that works.

#3 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

In reply to Peng Fan
Quoted 30 lines · Peng Fan
Quoted 22 lines

Subject: Re: [PATCH] imx8mq_evk: Update the required ATF branch

Quoted 17 lines · Fabio Estevam

Following the README instructions leads to a non-booting U-Boot:

U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
PMIC: PFUZE100 ID=0x10
DDRINFO: start DRAM init
DDRINFO:ddrphy calibration done
DDRINFO: ddrmix config done
Normal Boot
Trying to boot from MMC2

(It hangs here)

Use the "imx_4.19.35_1.0.0" ATF branch instead, which fixes such problem and allow the boot to complete again.

We might need to switch upstream ATF, or stick to NXP vendor release one?

Quoted 6 lines

Shouldn't we address the mix-match of the firmware-imx versions as well?

I just increasing numbers over and over, and I was able to use firmware 8.5 which.

Quoted 7 lines
Quoted 4 lines

The readme lists both 7.9 and 8.0. There is also a typo on the line that reads "./firmware-imx-8.0" which should have a .bin appended to it.

It would nice to know what the differences are between the versions.

The version should already be in yocto release. I just use the new one when I upstream code.

Either way, the README file is currently wrong as it sits because it's pulling one version of firmware and using a different version.

Is there a way to point to the release notes in a static location that doesn't change with each release? I don't use Yocto, so I don't always notice when newer versions are available.

adam

Quoted 40 lines

Thanks,
Peng.

Quoted 36 lines

adam

Quoted 13 lines
---
 board/freescale/imx8mq_evk/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/imx8mq_evk/README +0 -0
index c1d400bcf9..4f671b069c 100644
@@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware
Quoted 4 lines

======================================
Note: srctree is U-Boot source directory Get ATF from:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsour

ce.codeaurora.org%2Fexternal%2Fimx%2Fimx-atf&data=02%7C01%7Cp eng.f

Quoted 1 line

an%40nxp.com%7C56fbd5d0b17c4949cc1708d77e41f5c5%7C686ea1d3bc2b 4c6fa92c

Quoted 1 line

d99c5c301635%7C0%7C0%7C637116694069333717&sdata=PxZh7ldsxb %2FxZK7c

Quoted 9 lines

J5OpJxblskZJkHZHuXvMqGQC5H4%3D&reserved=0

board/freescale/imx8mq_evk/README +1 -2
-branch: imx_4.14.62_1.0.0_beta
+branch: imx_4.19.35_1.0.0
 $ make PLAT=imx8mq bl31
 $ cp build/imx8mq/release/bl31.bin $(srctree)
 
--

2.17.1

author reviewer
#4 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

In reply to Peng Fan

Hi Peng,

Quoted 1 line · Peng Fan

We might need to switch upstream ATF, or stick to NXP vendor release one?

I don't have much background about the ATF upstream status on i.MX8 to provide an opinion.

Does upstream ATF allow booting a U-Boot and mainline kernel?

This patch is the minimum change needed for booting mainline U-Boot. If someone thinks that ATF upstream is a good choice, then feel free to send a patch updating the README.

Quoted 2 lines

The version should already be in yocto release. I just use the new one when I upstream code.

Please keep in mind that not everyone uses Yocto.

How do we know what is the correct firmware version we need to use?

#5 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

Quoted 4 lines

Subject: Re: [PATCH] imx8mq_evk: Update the required ATF branch

Hi Peng,

Quoted 8 lines
Quoted 1 line · Peng Fan

We might need to switch upstream ATF, or stick to NXP vendor release one?

I don't have much background about the ATF upstream status on i.MX8 to provide an opinion.

Does upstream ATF allow booting a U-Boot and mainline kernel?

Not tried. Keep vendor version is fine for now.

Quoted 11 lines

This patch is the minimum change needed for booting mainline U-Boot. If someone thinks that ATF upstream is a good choice, then feel free to send a patch updating the README.

Quoted 2 lines

The version should already be in yocto release. I just use the new one when I upstream code.

Please keep in mind that not everyone uses Yocto.

How do we know what is the correct firmware version we need to use?

I need to check with Yocto team, then back.

Thanks,
Peng.

author reviewer
#6 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

Hi Peng,

Quoted 1 line · Peng Fan

Not tried. Keep vendor version is fine for now.

If you are happy with this patch, could you please provide your Acked-by?

I would like to keep the README accurate for the upcoming 2020.01 release.

Thanks

#7 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

Hi Peng,

Quoted 1 line · Peng Fan

We might need to switch upstream ATF, or stick to NXP vendor release one?

Quoted 8 lines

I don't have much background about the ATF upstream status on i.MX8 to provide an opinion.

Does upstream ATF allow booting a U-Boot and mainline kernel?

This patch is the minimum change needed for booting mainline U-Boot. If someone thinks that ATF upstream is a good choice, then feel free to send a patch updating the README.

Just for the record: I am using upstream ATF for my custom i.MX8MM board with mainline U-Boot and it just works fine. I didn't run into any issues so far and I'm still on ATF revision 3441952f61a6 and haven't updated for quite a while.

Quoted 8 lines
Quoted 3 lines

The version should already be in yocto release. I just use the new one when I upstream code.

Please keep in mind that not everyone uses Yocto.

How do we know what is the correct firmware version we need to use?

author reviewer
#8 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

Quoted 4 lines · Schrempf Frieder

Just for the record: I am using upstream ATF for my custom i.MX8MM board with mainline U-Boot and it just works fine. I didn't run into any issues so far and I'm still on ATF revision 3441952f61a6 and haven't updated for quite a while.

Thanks for the feedback.

Perhaps we can consider moving to mainline ATF after 2020.01 is released.

#9 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

Quoted 4 lines · Fabio Estevam

On Wed, Dec 11, 2019 at 11:14 AM Schrempf Frieder
<[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines

Just for the record: I am using upstream ATF for my custom i.MX8MM board with mainline U-Boot and it just works fine. I didn't run into any issues so far and I'm still on ATF revision 3441952f61a6 and haven't updated for quite a while.

Thanks for the feedback.

Perhaps we can consider moving to mainline ATF after 2020.01 is released.

It would be useful to test against the upstream releases and document against those rather than random vendor forks, upstream has fairly consistent 6 monthly releases around March/October with the last one being 2.2.

Peter

#15 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

In reply to Fabio Estevam
Quoted 13 lines

Subject: [PATCH] imx8mq_evk: Update the required ATF branch

Following the README instructions leads to a non-booting U-Boot:

U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
PMIC: PFUZE100 ID=0x10
DDRINFO: start DRAM init
DDRINFO:ddrphy calibration done
DDRINFO: ddrmix config done
Normal Boot
Trying to boot from MMC2

Quoted 7 lines

(It hangs here)

Use the "imx_4.19.35_1.0.0" ATF branch instead, which fixes such problem and allow the boot to complete again.

Quoted 25 lines
---
 board/freescale/imx8mq_evk/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/freescale/imx8mq_evk/README +0 -0
index c1d400bcf9..4f671b069c 100644
@@ -11,7 +11,7 @@ Get and Build the ARM Trusted firmware

======================================
Note: srctree is U-Boot source directory Get ATF from:
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource
.codeaurora.org%2Fexternal%2Fimx%2Fimx-atf&amp;data=02%7C01%7Cpen g.fan%40nxp.com%7C15caa498b49343fabede08d77e40facf%7C686ea1d3bc 2b4c6fa92cd99c5c301635%7C0%7C0%7C637116689861712196&amp;sdata =GNw4g1oDo9ceM1VIEB9A11716fQQF1GNzpJ4L3n8FTM%3D&amp;reserved =0

board/freescale/imx8mq_evk/README +1 -2
-branch: imx_4.14.62_1.0.0_beta
+branch: imx_4.19.35_1.0.0
 $ make PLAT=imx8mq bl31
 $ cp build/imx8mq/release/bl31.bin $(srctree)
 
--

2.17.1

author reviewer
#10 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

In reply to Peter Robinson

Hi Peter,

Quoted 4 lines · Peter Robinson

It would be useful to test against the upstream releases and document against those rather than random vendor forks, upstream has fairly consistent 6 monthly releases around March/October with the last one being 2.2.

I agree.

I plan to test the NXP i.MX8 boards with upstream ATF.

As we are at rc4 at the moment, I prefer we go with the updated vendor ATF version as proposed in this patch and then after 2020.01 I plan to test and switch to mainline ATF, so that we can have more time for testing.

author reviewer
#11 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

Quoted 10 lines · Fabio Estevam

Hi Peter,

Quoted 4 lines · Peter Robinson

It would be useful to test against the upstream releases and document against those rather than random vendor forks, upstream has fairly consistent 6 monthly releases around March/October with the last one being 2.2.

Quoted 8 lines

I agree.

I plan to test the NXP i.MX8 boards with upstream ATF.

As we are at rc4 at the moment, I prefer we go with the updated vendor ATF version as proposed in this patch and then after 2020.01 I plan to test and switch to mainline ATF, so that we can have more time for testing.

Just did a quick boot test on a imx8mq-evk with v2.2 upstream ATF and it booted fine.

author reviewer
#12 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

Quoted 2 lines · Fabio Estevam

Just did a quick boot test on a imx8mq-evk with v2.2 upstream ATF and it booted fine.

Actually I do see some power domain issues when using upstream ATF and booting mainline kernel:

[    1.573227] imx-pgc imx-pgc-domain.3: failed to command PGC
[    1.813816] imx-pgc imx-pgc-domain.3: failed to command PGC
[    1.931568] imx-pgc imx-pgc-domain.3: failed to command PGC

So it seems there are some more work to do on the i.MX8M ATF upstream front.

#16 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

In reply to Fabio Estevam
Quoted 12 lines

Following the README instructions leads to a non-booting U-Boot:
U-Boot SPL 2020.01-rc3-00070-g9a0cbae22a (Nov 25 2019 - 13:08:24 -0300)
PMIC: PFUZE100 ID=0x10
DDRINFO: start DRAM init
DDRINFO:ddrphy calibration done
DDRINFO: ddrmix config done
Normal Boot
Trying to boot from MMC2
(It hangs here)
Use the "imx_4.19.35_1.0.0" ATF branch instead, which
fixes such problem and allow the boot to complete again.

Quoted 3 lines

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#13 lore raw

PATCH 1/1 imx8mq_evk: Update the required ATF branch

In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam
Quoted 2 lines · Fabio Estevam

Just did a quick boot test on a imx8mq-evk with v2.2 upstream ATF and it booted fine.

Actually I do see some power domain issues when using upstream ATF and booting mainline kernel:

Quoted 8 lines
[    1.573227] imx-pgc imx-pgc-domain.3: failed to command PGC
[    1.813816] imx-pgc imx-pgc-domain.3: failed to command PGC
[    1.931568] imx-pgc imx-pgc-domain.3: failed to command PGC

So it seems there are some more work to do on the i.MX8M ATF upstream front.

I think mainline ATF is also still missing DDR frequency scaling

https://lore.kernel.org/linux-arm-kernel/cover.1573761527.git.leonard.crestez at nxp.com/T/#m2b7ce4204632cad49888745a89f833cc95a2ff32