Skip to contentSkip to conversation

public/io/netif.h: document a mechanism to advertise carrier state

PATCH In review Paul Durrant 2 participants 3 messages Dec 13, 2019

lore
Share & tools
lore
#2 lore raw
In reply to Jürgen Groß
Quoted 34 lines

-----Original Message-----
From: Jürgen Groß <[email protected]>
Sent: 13 December 2019 14:17
To: Durrant, Paul <[email protected]>; [email protected]
Cc: Konrad Rzeszutek Wilk <[email protected]>
Subject: Re: [PATCH] public/io/netif.h: document a mechanism to advertise carrier state

Quoted 1 line · Paul Durrant

This patch adds a specification for a 'carrier' node in xenstore to

allow

Quoted 7 lines

a backend to notify a frontend of it's virtual carrier/link state. E.g. a backend that is unable to forward packets from the guest because it is not attached to a bridge may wish to advertise 'no carrier'.

NOTE: This is purely a documentation patch. No functional change.

Review

Quoted 8 lines

---
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Juergen Gross <[email protected]>

---
  xen/include/public/io/netif.h | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
(quoted diff) +0 -0

b/xen/include/public/io/netif.h

Quoted 7 lines

index 2454448baa..e587055f68 100644

xen/include/public/io/netif.h +0 -0
@@ -190,6 +190,20 @@
   * order as requests.
   */
 
Quoted 8 lines

xen/include/public/io/netif.h line 197

Quoted 5 lines
xen/include/public/io/netif.h +5 -0
+/*
+ * Link state
+ * ==========
+ *
+ * The backend can advertise it is current link (carrier) state to the

s/it is/its/ ?

Oh yes.

Quoted 8 lines

xen/include/public/io/netif.h line 198

Quoted 1 line
xen/include/public/io/netif.h +1 -0
+ * frontend using the /local/domain/X/backend/<domid>/<vif>/carrier

node.

Hmm, I just realized that the other mentioned backend path in this file is wrong, it should be: /local/domain/X/backend/vif/<domid>/<vif>/...

Mind correcting that in your patch, too?

Sure.

Paul
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#1 lore raw
In reply to Paul Durrant
Quoted 20 lines · Paul Durrant

This patch adds a specification for a 'carrier' node in xenstore to allow a backend to notify a frontend of it's virtual carrier/link state. E.g. a backend that is unable to forward packets from the guest because it is not attached to a bridge may wish to advertise 'no carrier'.

NOTE: This is purely a documentation patch. No functional change.

---
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Juergen Gross <[email protected]>

---
  xen/include/public/io/netif.h | 14 ++++++++++++++
  1 file changed, 14 insertions(+)
xen/include/public/io/netif.h +0 -0
index 2454448baa..e587055f68 100644

xen/include/public/io/netif.h line 197

Quoted 8 lines
xen/include/public/io/netif.h +5 -0
@@ -190,6 +190,20 @@
   * order as requests.
   */
 
+/*
+ * Link state
+ * ==========
+ *
+ * The backend can advertise it is current link (carrier) state to the

s/it is/its/ ?

xen/include/public/io/netif.h line 198

Quoted 1 line
xen/include/public/io/netif.h +1 -0
+ * frontend using the /local/domain/X/backend/<domid>/<vif>/carrier node.

Hmm, I just realized that the other mentioned backend path in this file is wrong, it should be: /local/domain/X/backend/vif/<domid>/<vif>/...

Mind correcting that in your patch, too?

xen/include/public/io/netif.h line 206

Quoted 8 lines
xen/include/public/io/netif.h +8 -0
+ * If this node is not present, then the frontend should assume that the
+ * link is up (for compatibility with backends that do no implement this
+ * feature). If this node is present, then a value of "0" should be
+ * interpreted by the frontend as the link being down (no carrier) and a
+ * value of "1" should be interpreted as the link being up (carrier
+ * present).
+ */
+

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#0 lore raw

PATCH 1/1 public/io/netif.h: document a mechanism to advertise carrier state

This patch adds a specification for a 'carrier' node in xenstore to allow a backend to notify a frontend of it's virtual carrier/link state. E.g. a backend that is unable to forward packets from the guest because it is not attached to a bridge may wish to advertise 'no carrier'.

NOTE: This is purely a documentation patch. No functional change.

---
Cc: Konrad Rzeszutek Wilk <[email protected]>
Cc: Juergen Gross <[email protected]>

---
 xen/include/public/io/netif.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
xen/include/public/io/netif.h +14 -0
index 2454448baa..e587055f68 100644
@@ -190,6 +190,20 @@
  * order as requests.
  */
 
+/*
+ * Link state
+ * ==========
+ *
+ * The backend can advertise it is current link (carrier) state to the
+ * frontend using the /local/domain/X/backend/<domid>/<vif>/carrier node.
+ * If this node is not present, then the frontend should assume that the
+ * link is up (for compatibility with backends that do no implement this
+ * feature). If this node is present, then a value of "0" should be
+ * interpreted by the frontend as the link being down (no carrier) and a
+ * value of "1" should be interpreted as the link being up (carrier
+ * present).
+ */
+
 /*
  * Hash types
  * ==========
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel