Skip to contentSkip to conversation

tune-cortexa72-cortexa53: Add tune

PATCH Superseded Joshua Watt 4 participants 13 messages Dec 13, 2019 – Dec 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tune-cortexa72-cortexa53: Add tune

Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip RK3399

---
 .../include/tune-cortexa72-cortexa53.inc       | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +18 -0
new file mode 100644
index 00000000000..30e49d20769
@@ -0,0 +1,18 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa72-cortexa53"
+ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"
+TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa72-cortexa53"
+BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
Signature · 1 line
2.23.0
#1 lore raw
Quoted 20 lines · Joshua Watt

Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip RK3399

---
 .../include/tune-cortexa72-cortexa53.inc       | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +5 -0
new file mode 100644
index 00000000000..30e49d20769
@@ -0,0 +1,18 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 15

Quoted 10 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +10 -0
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa72-cortexa53"
+ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"

I'm wondering if the pkgarch should be shorter.. This really does make package names very long. (I don't know offhand if that is an actual problem or not.)

Also a similar tune has been used by NXP and Wind River. So hopefully we don't end up with conflicts.

--Mark

Quoted 4 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +3 -0
+TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa72-cortexa53"
+BASE_LIB_tune-cortexa72-cortexa53 = "lib64"
#2 lore raw
Quoted 29 lines · Mark Hatle
Quoted 25 lines · Joshua Watt

Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip RK3399

---
 .../include/tune-cortexa72-cortexa53.inc       | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +10 -0
new file mode 100644
index 00000000000..30e49d20769
@@ -0,0 +1,18 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
+
Quoted 8 lines

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 15

Quoted 5 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +5 -0
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa72-cortexa53"
+ARMPKGARCH_tune-cortexa72-cortexa53 = "cortexa72-cortexa53"

I'm wondering if the pkgarch should be shorter.. This really does make package names very long. (I don't know offhand if that is an actual problem or not.)

I chose this name because there is already a tune-cortexa57-cortexa53.inc, so the consistency is nice.

Quoted 15 lines

Also a similar tune has been used by NXP and Wind River. So hopefully we don't end up with conflicts.

--Mark

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 18

Quoted 4 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +3 -0
+TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53 = "${PACKAGE_EXTRA_ARCHS_tune-aarch64} cortexa72-cortexa53"
+BASE_LIB_tune-cortexa72-cortexa53 = "lib64"

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
In reply to Joshua Watt
Quoted 5 lines · Joshua Watt

Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
RK3399
...
+TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
...

Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled, so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.

The RK3399 implements the optional crypto extensions, it needs a TUNE_FEATURES_tune-cortexa72-cortexa53-crypto.

cu
Adrian

#4 lore raw
Quoted 10 lines · Adrian Bunk
Quoted 5 lines · Joshua Watt

Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
RK3399
...
+TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
...

Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled, so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.

I think that's armv8.1-a, the cortex A72 is only armv8-a (at least AFAICT), so I think crc would still be an optional feature.

Quoted 3 lines

The RK3399 implements the optional crypto extensions, it needs a TUNE_FEATURES_tune-cortexa72-cortexa53-crypto.

Ok, I've rewritten the patch to more closely align with the arch-armv8a.inc tune file, which looks a lot cleaner.

Quoted 3 lines

cu
Adrian

#5 lore raw
Quoted 9 lines · Joshua Watt
Quoted 8 lines · Adrian Bunk
Quoted 5 lines · Joshua Watt

Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip
RK3399
...
+TUNE_FEATURES_tune-cortexa72-cortexa53 = "${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"
...

Quoted 6 lines
Quoted 2 lines

Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled, so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.

I think that's armv8.1-a, the cortex A72 is only armv8-a (at least AFAICT), so I think crc would still be an optional feature.
...

It is optional for armv8-a, but not for Cortex A53 or A72.

What matters in practice is that gcc automatically enables it for cortex-a72.cortex-a53, so the resulting code might not run on armv8-a hardware without support for crc - things will break if the tune features are not 100% aligned with whatever gcc is doing.

cu
Adrian

#6 lore raw
Quoted 18 lines · Adrian Bunk
Quoted 7 lines · Joshua Watt
Quoted 6 lines · Adrian Bunk
Quoted 4 lines · Joshua Watt

Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip RK3399
...
+TUNE_FEATURES_tune-cortexa72-cortexa53 =

"${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

...

Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled, so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.

I think that's armv8.1-a, the cortex A72 is only armv8-a (at least AFAICT), so I think crc would still be an optional feature.
...

Quoted 8 lines

It is optional for armv8-a, but not for Cortex A53 or A72.

What matters in practice is that gcc automatically enables it for cortex-a72.cortex-a53, so the resulting code might not run on armv8-a hardware without support for crc - things will break if the tune features are not 100% aligned with whatever gcc is doing.

I agree, but I can't find anywhere that says crc is enabled by default when the tune is cortexa72.cortexa53. Maybe I'm looking in the wrong location?

Thanks

Quoted 3 lines

cu
Adrian

#7 lore raw
Quoted 22 lines · Joshua Watt
Quoted 20 lines · Adrian Bunk
Quoted 7 lines · Joshua Watt
Quoted 6 lines · Adrian Bunk
Quoted 4 lines · Joshua Watt

Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g. Rockchip RK3399
...
+TUNE_FEATURES_tune-cortexa72-cortexa53 =

"${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

...

Looking at the gcc sources cortexa72-cortexa53 defaults to crc enabled, so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.

I think that's armv8.1-a, the cortex A72 is only armv8-a (at least AFAICT), so I think crc would still be an optional feature.
...

It is optional for armv8-a, but not for Cortex A53 or A72.

Quoted 8 lines
Quoted 5 lines

What matters in practice is that gcc automatically enables it for cortex-a72.cortex-a53, so the resulting code might not run on armv8-a hardware without support for crc - things will break if the tune features are not 100% aligned with whatever gcc is doing.

I agree, but I can't find anywhere that says crc is enabled by default when the tune is cortexa72.cortexa53. Maybe I'm looking in the wrong location?

https://github.com/gcc-mirror/gcc/blob/master/gcc/config/arm/arm-cpus.in#L1278

Quoted 1 line

Thanks

cu
Adrian

#8 lore raw
Quoted 31 lines · Adrian Bunk
Quoted 7 lines · Joshua Watt
Quoted 5 lines · Adrian Bunk
Quoted 4 lines · Joshua Watt
Quoted 3 lines · Adrian Bunk
Quoted 1 line · Joshua Watt

Adds a tune for Cortex-A72 Cortex-A53 big.LITTLE SoCs, e.g.

Rockchip

Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

RK3399
...
+TUNE_FEATURES_tune-cortexa72-cortexa53 =

"${TUNE_FEATURES_tune-aarch64} cortexa72-cortexa53"

Quoted 3 lines
Quoted 3 lines
Quoted 1 line

...

Looking at the gcc sources cortexa72-cortexa53 defaults to crc

enabled,

Quoted 14 lines
Quoted 13 lines
Quoted 5 lines
Quoted 1 line

so TUNE_FEATURES_tune-cortexa72-cortexa53 must contain crc.

I think that's armv8.1-a, the cortex A72 is only armv8-a (at least AFAICT), so I think crc would still be an optional feature.
...

It is optional for armv8-a, but not for Cortex A53 or A72.

What matters in practice is that gcc automatically enables it for cortex-a72.cortex-a53, so the resulting code might not run on armv8-a hardware without support for crc - things will break if the tune features are not 100% aligned with whatever gcc is doing.

Quoted 6 lines
Quoted 1 line

I agree, but I can't find anywhere that says crc is enabled by default

when

Quoted 1 line

the tune is cortexa72.cortexa53. Maybe I'm looking in the wrong location?

https://github.com/gcc-mirror/gcc/blob/master/gcc/config/arm/arm-cpus.in#L1278

Excellent. I'll send v3.

Thanks for the help

Quoted 8 lines
Quoted 4 lines

Thanks

cu
Adrian

#9 lore raw

PATCH v2 1/1 tune-cortexa72-cortexa53: Add tunes

In reply to Joshua Watt

Adds tunes for Cortex-A72 Cortex-A53 big.LITTLE SoCs (with and without crypto extensions), e.g. Rockchip RK3399

---
 .../include/tune-cortexa72-cortexa53.inc      | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +24 -0
new file mode 100644
index 00000000000..6bf3b83abe9
@@ -0,0 +1,24 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
+
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
+ARMPKGARCH_tune-cortexa72-cortexa53                  = "cortexa72-cortexa53"
+ARMPKGARCH_tune-cortexa72-cortexa53-crypto           = "cortexa72-cortexa53"
+TUNE_FEATURES_tune-cortexa72-cortexa53               = "${TUNE_FEATURES_tune-armv8a}"
+TUNE_FEATURES_tune-cortexa72-cortexa53-crypto        = "${TUNE_FEATURES_tune-armv8a-crypto}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53         = "${PACKAGE_EXTRA_ARCHS_tune-armv8a} cortexa72-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto  = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crypto} cortexa72-cortexa53-crypto"
+BASE_LIB_tune-cortexa72-cortexa53                    = "lib64"
+BASE_LIB_tune-cortexa72-cortexa53-crypto             = "lib64"
+
Signature · 1 line
2.23.0
#10 lore raw

Re: [PATCH v2] tune-cortexa72-cortexa53: Add tunes

Quoted 27 lines · Joshua Watt

Adds tunes for Cortex-A72 Cortex-A53 big.LITTLE SoCs (with and without crypto extensions), e.g. Rockchip RK3399

---
 .../include/tune-cortexa72-cortexa53.inc      | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +11 -0
new file mode 100644
index 00000000000..6bf3b83abe9
@@ -0,0 +1,24 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", " -march=armv8-a", "" ,d)}"
+
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
+

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 21

Quoted 10 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +10 -0
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
+
+# Little Endian base configs
+AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
+ARMPKGARCH_tune-cortexa72-cortexa53                  = "cortexa72-cortexa53"
+ARMPKGARCH_tune-cortexa72-cortexa53-crypto           = "cortexa72-cortexa53"
+TUNE_FEATURES_tune-cortexa72-cortexa53               = "${TUNE_FEATURES_tune-armv8a}"
+TUNE_FEATURES_tune-cortexa72-cortexa53-crypto        = "${TUNE_FEATURES_tune-armv8a-crypto}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53         = "${PACKAGE_EXTRA_ARCHS_tune-armv8a} cortexa72-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto  = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crypto} cortexa72-cortexa53-crypto"

Shouldn't cortexa72-cortexa53-crypto also be able to use cortexa72-cortexa53 packages?

Quoted 11 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +3 -1
+BASE_LIB_tune-cortexa72-cortexa53                    = "lib64"
+BASE_LIB_tune-cortexa72-cortexa53-crypto             = "lib64"
+
--

2.23.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#11 lore raw

Re: [PATCH v2] tune-cortexa72-cortexa53: Add tunes

Quoted 25 lines · Andre McCurdy
Quoted 9 lines · Joshua Watt

Adds tunes for Cortex-A72 Cortex-A53 big.LITTLE SoCs (with and without crypto extensions), e.g. Rockchip RK3399

---
 .../include/tune-cortexa72-cortexa53.inc      | 24 +++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644

meta/conf/machine/include/tune-cortexa72-cortexa53.inc

Review

Quoted 2 lines
(quoted diff) +0 -0

b/meta/conf/machine/include/tune-cortexa72-cortexa53.inc

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 5

Quoted 10 lines

new file mode 100644
index 00000000000..6bf3b83abe9

meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +5 -0
@@ -0,0 +1,24 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE

Cortex-A72.Cortex-A53 specific processor optimizations"

Quoted 3 lines

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 6

Quoted 1 line
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +1 -0
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "aarch64", "

-march=armv8-a", "" ,d)}"

I also think this is redundant because arch-armv8a.inc does it already

Quoted 18 lines

+

meta/conf/machine/include/tune-cortexa72-cortexa53.inc

Quoted 3 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +3 -0
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES",

"cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 11

Quoted 2 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +2 -0
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES",

"cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"

meta/conf/machine/include/tune-cortexa72-cortexa53.inc

Quoted 4 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +4 -0
+
+# Little Endian base configs
+AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
+ARMPKGARCH_tune-cortexa72-cortexa53                  =

"cortexa72-cortexa53"

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 16

Quoted 1 line
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +1 -0
+ARMPKGARCH_tune-cortexa72-cortexa53-crypto           =

"cortexa72-cortexa53"

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 17

Quoted 1 line
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +1 -0
+TUNE_FEATURES_tune-cortexa72-cortexa53               =

"${TUNE_FEATURES_tune-armv8a}"

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 18

Quoted 1 line
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +1 -0
+TUNE_FEATURES_tune-cortexa72-cortexa53-crypto        =
Quoted 9 lines

"${TUNE_FEATURES_tune-armv8a-crypto}"

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 19

Quoted 1 line
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +1 -0
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53         =

"${PACKAGE_EXTRA_ARCHS_tune-armv8a} cortexa72-cortexa53"

meta/conf/machine/include/tune-cortexa72-cortexa53.inc line 20

Quoted 1 line
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +1 -0
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto  =

"${PACKAGE_EXTRA_ARCHS_tune-armv8a-crypto} cortexa72-cortexa53-crypto"

Shouldn't cortexa72-cortexa53-crypto also be able to use cortexa72-cortexa53 packages?

Yep. I'll send a v3

Quoted 12 lines
Quoted 11 lines
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +3 -1
+BASE_LIB_tune-cortexa72-cortexa53                    = "lib64"
+BASE_LIB_tune-cortexa72-cortexa53-crypto             = "lib64"
+
--

2.23.0

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#12 lore raw

PATCH v3 1/1 tune-cortexa72-cortexa53: Add tunes

In reply to Joshua Watt

Adds tunes for Cortex-A72 Cortex-A53 big.LITTLE SoCs (with and without crypto extensions), e.g. Rockchip RK3399

---
 .../include/tune-cortexa72-cortexa53.inc      | 23 +++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta/conf/machine/include/tune-cortexa72-cortexa53.inc
meta/conf/machine/include/tune-cortexa72-cortexa53.inc new file +23 -0
new file mode 100644
index 00000000000..0d43531be70
@@ -0,0 +1,23 @@
+DEFAULTTUNE ?= "cortexa72-cortexa53"
+
+require conf/machine/include/arm/arch-armv8a.inc
+
+TUNEVALID[cortexa72-cortexa53] = "Enable big.LITTLE Cortex-A72.Cortex-A53 specific processor optimizations"
+
+TUNECONFLICTS[aarch64] = "armv4 armv5 armv6 armv7 armv7a"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", "cortexa72-cortexa53:", "" ,d)}"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "cortexa72-cortexa53", " -mtune=cortex-a72.cortex-a53", "", d)}"
+
+# cortexa72.cortexa53 implies crc support
+AVAILTUNES += "cortexa72-cortexa53 cortexa72-cortexa53-crypto"
+ARMPKGARCH_tune-cortexa72-cortexa53                  = "cortexa72-cortexa53"
+ARMPKGARCH_tune-cortexa72-cortexa53-crypto           = "cortexa72-cortexa53"
+TUNE_FEATURES_tune-cortexa72-cortexa53               = "${TUNE_FEATURES_tune-armv8a-crc}"
+TUNE_FEATURES_tune-cortexa72-cortexa53-crypto        = "${TUNE_FEATURES_tune-armv8a-crc-crypto}"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53         = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc}        cortexa72-cortexa53"
+PACKAGE_EXTRA_ARCHS_tune-cortexa72-cortexa53-crypto  = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto} cortexa72-cortexa53 cortexa72-cortexa53-crypto"
+BASE_LIB_tune-cortexa72-cortexa53                    = "lib64"
+BASE_LIB_tune-cortexa72-cortexa53-crypto             = "lib64"
+
Signature · 1 line
2.23.0